chore: separate update and delete password

isomerpages · Jun 27, 2023 · 592ab87 · 592ab87
1 parent 323f364
commit 592ab87
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 22 deletions.
diff --git a/src/services/identity/DeploymentClient.ts b/src/services/identity/DeploymentClient.ts
@@ -90,27 +90,22 @@ class DeploymentClient {
     },
   })
 
+  generateDeletePasswordInput = (appId: string): UpdateBranchCommandInput => ({
+    appId,
+    branchName: "staging",
+    enableBasicAuth: false,
+    basicAuthCredentials: "",
+  })
+
   generateUpdatePasswordInput = (
     appId: string,
     password: string
-  ): UpdateBranchCommandInput => {
-    if (password) {
-      return {
-        appId,
-        branchName: "staging",
-        enableBasicAuth: true,
-        basicAuthCredentials: Buffer.from(`user:${password}`).toString(
-          "base64"
-        ),
-      }
-    }
-    return {
-      appId,
-      branchName: "staging",
-      enableBasicAuth: false,
-      basicAuthCredentials: "",
-    }
-  }
+  ): UpdateBranchCommandInput => ({
+    appId,
+    branchName: "staging",
+    enableBasicAuth: true,
+    basicAuthCredentials: Buffer.from(`user:${password}`).toString("base64"),
+  })
 }
 
 export default DeploymentClient
diff --git a/src/services/identity/DeploymentsService.ts b/src/services/identity/DeploymentsService.ts
@@ -157,10 +157,7 @@ class DeploymentsService {
     const { id, hostingId: appId } = deploymentInfo
     let updateAppInput
     if (!enablePassword) {
-      updateAppInput = this.deploymentClient.generateUpdatePasswordInput(
-        appId,
-        ""
-      )
+      updateAppInput = this.deploymentClient.generateDeletePasswordInput(appId)
     } else {
       const {
         encryptedPassword: oldEncryptedPassword,