Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would have been better if you had another example:
Reason being - some like myself prefer to have the redundancy obvious - being explicit over implicit. However, having the
true
as the l-value and the variable as the r-value prevents errors with=
vs==
from happening.So there should be a middle ground between the implicit
my_condition
and the explicit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenjamenMeyer Thank you for your suggestion. I know that
if (true == my_condition)
would prevent an accidental assignment, that would happen when doingif (my_condition = true)
, accidentally. But honestly, I still prefer to have the "unknown" (the variable) at the left side, and the "known value" (the constant) at the right side, because I find it more intuitive.