Add exceptions to F.15, F.16, and F.18 for shared_ptr
types
#2010
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these guidelines conflict with R.34, R.35, and R.36.
This conflict has led to confusion, where it's unclear which guidelines to prefer for
shared_ptr
types.In a previous PR I proposed preferring the "F" series of guidelines. This PR takes the opposite approach and prefers the "R" guidelines for
shared_ptr
types.I don't feel strongly about which guidelines to prefer, I just want to make sure the guidelines are internally consistent.