Feature/prepare pull request #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Honour preexpandSingleShowCardAction and weight of fact title from HostConfig * Addressed comments * Support OnParseAction * resolved minor comments
* make rendering to be syncronoush by default * updated custom textblock renderer * changes before CR * CR update * CR update
…oft#1561) * Prevent unobserved exceptions from taking down the process. If rendering fails, report the error but do not throw on a background thread. * Add configuration to sign nuget packages * fixed dll/project names in comments
…#1573) * Replace ContainerStyle string enum with class + static fields * Update default card * Improve hover behavior for Image with selectAction * Finalize support for width/height in Image and Column * Add support for icons on action buttons * Cleanup * Fix handling of buttons without title * Fix broken preExpandSingleShowCardAction handling * Fix actions parent not being set before actions are parsed
* Add vertical stretch to android * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests
* make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * CR comments fix
* make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * made headers public for customizing buttons * added ACRUILable.h * reverted wrong merge
* Enable Declaration warnings and first round of fixes * Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp
…microsoft#1581) * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * fixed build compatability issues below iOS 11.3 * fixes before CR * added UIScrollView to ActionSet * edits before CR * Added sample json and updates b4 CR
Add support for more properties in property sheet Add initial support for snippets
* Add vertical stretch to android * make rendering to be syncronoush by default * updated custom textblock renderer * optimized use of html rendering * fixed factset issue * Remove non related test file * Fix comments in FactSetRendered * Add tests as linked tests * Update tests results from TestApp with new tests * Add vertical stretch for items * Remove 'changes' from merge * Add vertical stretch tests to solution * Fix issue for image in columnsets rendering * Fix issue for images being shorter than other columns in columnset * Keep alignment leading for cards with no stretchable items * Add new test for auto size image
* Enable override checker and fix errors * Enable function hiding warning and fix errors * Enable all class warnings and fix errors
* Add missing test * Fix spaces in json
…soft#1583) * Update get resource method to include type and to support media
…osoft#1586) Handle opening media via resource resolver when play is pressed
* Test file updates
* XIB first commit * fixes merge error * updated InputView with XIB updated the style of UIButtons added UITableViewCell xib for compact mode removed comments * code clean up * added ACRbutton.xib * Added Xib for CompactCell * added ACRButton.xib
* allowed column with numeric width value to stretch * fix merge and remove spacing for the first item
* Add aesthetic fix to UWP * Aesthetic fix for android * Aesthetic fix for iOS * Add json test files to project * Fix formatting
removed comments
…icrosoft#1596) * in progress * when user chooses, user choice will be shown * updated default message * value is used instead of "Make Choice"
* explicit image changes * Added 'Explicit' enum value * uwp changes * uwp changes * added explicit image sizing option for ios * removed division
* fixes extra spacing issue in UICollectionView * refined intrinsic content size for collection view * fixed precision error
* fixes url loading sync issue for actions removed hard coded image icon placement * fixed indentation and changed variable name
…test (microsoft#1636) * Input.Text roundtrip, added test and fix * feedback -vertical spaces
* fixes url loading sync issue for actions removed hard coded image icon placement * allows custom BG IMG renderer * Added CustomImageRenderer to sample * removed CoreGraphics framework as it's not used
…#1643) * initial commit for multiline input and input limit implmt plc hld txt; rmved max len chg when not set reverted json files * Refactoring and code clean-up * updated whitespaces * Fixed newline char
* Refocus on show card * Set focus for cards instead of input fields
…oft#1651)" (microsoft#1653) This reverts commit f2a899a.
…pull-request # Conflicts: # source/nodejs/adaptivecards-designer/index.html # source/nodejs/adaptivecards-designer/src/app.ts # source/nodejs/adaptivecards-designer/src/card-designer.ts # source/nodejs/adaptivecards-designer/src/containers/teams-container.ts # source/nodejs/adaptivecards/src/card-elements.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.