Skip to content

Commit

Permalink
Feature/prepare pr (#31)
Browse files Browse the repository at this point in the history
* Add MSC directive to prevent cppcorecheck build failures on non-VS builds (microsoft#1552)

* cleaned up exception handling in loading image (microsoft#1526)

* Enable member init checks and fix errors (microsoft#1566)

* A class with only static methods and no state should just be a namespace. (microsoft#1567)

* Support OnParseAction Handler (microsoft#1570)

* Honour preexpandSingleShowCardAction and weight of fact title from HostConfig

* Addressed comments

* Support OnParseAction

* resolved minor comments

* Jwoo/ios render sync (microsoft#1547)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* changes before CR

* CR update

* CR update

* [.NET] Prevent async exceptions from tearing down the process (microsoft#1561)

* Prevent unobserved exceptions from taking down the process.

If rendering fails, report the error but do not throw on a background thread.

* Add configuration to sign nuget packages

* fixed dll/project names in comments

* Fix actions parent not being set before actions are parsed (microsoft#1573)

* Replace ContainerStyle string enum with class + static fields

* Update default card

* Improve hover behavior for Image with selectAction

* Finalize support for width/height in Image and Column

* Add support for icons on action buttons

* Cleanup

* Fix handling of buttons without title

* Fix broken preExpandSingleShowCardAction handling

* Fix actions parent not being set before actions are parsed

* Enable const cppcore checks and fix fallout (microsoft#1575)

* Add Events for media play and end (microsoft#1546)

* [Android] Add vertical stretch property (microsoft#1525)

* Add vertical stretch to android

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Jwoo/ios makrdown optimized (microsoft#1554)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* CR comments fix

* Added additional headers to public lis in framework. (microsoft#1562)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* made headers public for customizing buttons

* added ACRUILable.h

* reverted wrong merge

* Enable CPPCORECHECK_DECLARATION_WARNINGS and fix errors (microsoft#1579)

* Enable Declaration warnings and first round of fixes

* Clean up remaining unnamed objects warnings and disable C26426 in enums.cpp

* added ability to scroll when there are more buttons than viewing area (microsoft#1581)

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* fixed build compatability issues below iOS 11.3

* fixes before CR

* added UIScrollView to ActionSet

* edits before CR

* Added sample json and updates b4 CR

* Enable "rule of five" checker, fix errors (microsoft#1585)

* Add Teams containers (microsoft#1469)

Add support for more properties in property sheet
Add initial support for snippets

* [iOS] Add vertical stretch support (microsoft#1584)

* Add vertical stretch to android

* make rendering to be syncronoush by default

* updated custom textblock renderer

* optimized use of html rendering

* fixed factset issue

* Remove non related test file

* Fix comments in FactSetRendered

* Add tests as linked tests

* Update tests results from TestApp with new tests

* Add vertical stretch for items

* Remove 'changes' from merge

* Add vertical stretch tests to solution

* Fix issue for image in columnsets rendering

* Fix issue for images being shorter than other columns in columnset

* Keep alignment leading for cards with no stretchable items

* Add new test for auto size image

* Enable all cppcorecheck class warnings and fix errors (microsoft#1601)

* Enable override checker and fix errors

* Enable function hiding warning and fix errors

* Enable all class warnings and fix errors

* [iOS] Add missing test for Vertical Stretch (microsoft#1603)

* Add missing test

* Fix spaces in json

* Update GetResource method to include type and to support media   (microsoft#1583)

* Update get resource method to include type and to support media

* Handle opening media via resource resolver when play is pressed (microsoft#1586)

Handle opening media via resource resolver when play is pressed

* Enable unit test code coverage in Debug Win32 builds (microsoft#1611)

* Test source file updates (microsoft#1551)

* Test file updates

* Jwoo/ios custom styling (microsoft#1474)

* XIB first commit

* fixes merge error

* updated InputView with XIB

updated the style of UIButtons

 added UITableViewCell xib for compact mode

removed comments

* code clean up

* added ACRbutton.xib

* Added Xib for CompactCell

* added ACRButton.xib

* allowed column with numeric width value to stretch (microsoft#1595)

* allowed column with numeric width value to stretch

* fix merge and remove spacing for the first item

* [UWP][Android][iOS] Add aesthetic fix Icons in Actions (microsoft#1612)

* Add aesthetic fix to UWP

* Aesthetic fix for android

* Aesthetic fix for iOS

* Add json test files to project

* Fix formatting

* updated showcard rendering position (microsoft#1600)

removed comments

* compact style choice set "make choice" row will reflect user choice (microsoft#1596)

* in progress

* when user chooses, user choice will be shown

* updated default message

* value is used instead of "Make Choice"

* handles cases where compact style lacking defaults (microsoft#1627)

* fixed separator issue (microsoft#1629)

* Remove Stretch from vertical content alignment (microsoft#1630)

* Jwoo/explicit image size ios (microsoft#1374)

* explicit image changes

* Added 'Explicit' enum value

* uwp changes

* uwp changes

* added explicit image sizing option for ios

* removed division

* fixes extra spacing issue in UICollectionView (microsoft#1628)

* fixes extra spacing issue in UICollectionView

* refined intrinsic content size for collection view

* fixed precision error

* fixes url loading sync issue for actions (microsoft#1641)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* fixed indentation and changed variable name

* Fix media controls (microsoft#1614)

* [TS] Fixed Input.Text style and horizontalAlignment roundtrip; added test (microsoft#1636)

* Input.Text roundtrip, added test and fix

* feedback -vertical spaces

* Change private for protected in all Renderers constructors (microsoft#1649)

* Add vertical scroll support (microsoft#1650)

* Jwoo/ios custom background image loader (microsoft#1642)

* fixes url loading sync issue for actions

removed hard coded image icon placement

* allows custom BG IMG renderer

* Added CustomImageRenderer to sample

* removed CoreGraphics framework as it's not used

* added a test to ensure Unicode/Emoji support (microsoft#1647)

:shipit:

* multiline input and input limit for textview and textfield (microsoft#1643)

* initial commit for multiline input and input limit

implmt plc hld txt; rmved max len chg when not set

reverted json files

* Refactoring and code clean-up

* updated whitespaces

* Fixed newline char

* [Android] Refocus when a show card changes visibility (microsoft#1651)

* Refocus on show card

* Set focus for cards instead of input fields

* Revert "[Android] Refocus when a show card changes visibility (microsoft#1651)" (microsoft#1653)

This reverts commit f2a899a.
  • Loading branch information
ismanapa authored and IgnaciodeNuevo committed Jun 28, 2018
1 parent 7681fe4 commit 0475bc8
Show file tree
Hide file tree
Showing 687 changed files with 6,697 additions and 4,048 deletions.
55 changes: 55 additions & 0 deletions samples/Tests/ColumnSet.FactSet.VerticalStretch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"height": "stretch",
"version": "1.0",
"body": [
{
"type": "ColumnSet",
"height": "stretch",
"columns": [
{
"width": 1,
"items": [
{
"type": "TextBlock",
"text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
"wrap": true
}
]
},
{
"width": 1,
"spacing": "large",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "This is a textblock that doesn't stretch, but the input text does",
"wrap": true
},
{
"type": "FactSet",
"height": "stretch",
"facts": [
{
"title": "Fact 1",
"value": "Value 1"
},
{
"title": "Fact 2",
"value": "Value 2"
}
]
},
{
"type": "TextBlock",
"text": "One last text block at the bottom",
"wrap": true
}
]
}
]
}
]
}
47 changes: 47 additions & 0 deletions samples/Tests/ColumnSet.Image.VerticalStretch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"height": "stretch",
"version": "1.0",
"body": [
{
"type": "ColumnSet",
"height": "stretch",
"columns": [
{
"width": 1,
"items": [
{
"type": "TextBlock",
"text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
"wrap": true
}
]
},
{
"width": 1,
"spacing": "large",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "This is a textblock that doesn't stretch, but the input text does",
"wrap": true
},
{
"type": "Image",
"url": "http://adaptivecards.io/content/cats/1.png",
"height": "stretch",
"size": "small"
},
{
"type": "TextBlock",
"text": "One last text block at the bottom",
"wrap": true
}
]
}
]
}
]
}
56 changes: 56 additions & 0 deletions samples/Tests/ColumnSet.ImageSet.VerticalStretch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"height": "stretch",
"version": "1.0",
"body": [
{
"type": "ColumnSet",
"height": "stretch",
"columns": [
{
"width": 1,
"items": [
{
"type": "TextBlock",
"text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
"wrap": true
}
]
},
{
"width": 1,
"spacing": "large",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "This is a textblock that doesn't stretch, but the input text does",
"wrap": true
},
{
"type": "ImageSet",
"imageSize": "small",
"height": "stretch",
"images": [
{
"type": "Image",
"url": "http://adaptivecards.io/content/cats/1.png"
},
{
"type": "Image",
"url": "http://adaptivecards.io/content/cats/2.png"
}
]
},
{
"type": "TextBlock",
"text": "One last text block at the bottom",
"wrap": true
}
]
}
]
}
]
}
60 changes: 60 additions & 0 deletions samples/Tests/ColumnSet.Input.ChoiceSet.VerticalStretch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"height": "stretch",
"version": "1.0",
"body": [
{
"type": "ColumnSet",
"height": "stretch",
"columns": [
{
"width": 1,
"items": [
{
"type": "TextBlock",
"text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
"wrap": true
}
]
},
{
"width": 1,
"spacing": "large",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "This is a textblock that doesn't stretch, but the input text does",
"wrap": true
},
{
"type": "Input.ChoiceSet",
"id": "input1",
"height": "stretch",
"choices": [
{
"title": "Red",
"value": "1"
},
{
"title": "Green",
"value": "2"
},
{
"title": "Blue",
"value": "3"
}
]
},
{
"type": "TextBlock",
"text": "One last text block at the bottom",
"wrap": true
}
]
}
]
}
]
}
47 changes: 47 additions & 0 deletions samples/Tests/ColumnSet.Input.Date.VerticalStretch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"height": "stretch",
"version": "1.0",
"body": [
{
"type": "ColumnSet",
"height": "stretch",
"columns": [
{
"width": 1,
"items": [
{
"type": "TextBlock",
"text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
"wrap": true
}
]
},
{
"width": 1,
"spacing": "large",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "This is a textblock that doesn't stretch, but the input text does",
"wrap": true
},
{
"type": "Input.Date",
"id": "input1",
"placeholder": "enter date",
"height": "stretch"
},
{
"type": "TextBlock",
"text": "One last text block at the bottom",
"wrap": true
}
]
}
]
}
]
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,10 @@
"wrap": true
},
{
"type": "Input.Text",
"type": "Input.Number",
"id": "input1",
"placeholder": "enter comment",
"maxLength": 500,
"max": 500,
"height": "stretch"
},
{
Expand Down
47 changes: 47 additions & 0 deletions samples/Tests/ColumnSet.Input.Time.VerticalStretch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"height": "stretch",
"version": "1.0",
"body": [
{
"type": "ColumnSet",
"height": "stretch",
"columns": [
{
"width": 1,
"items": [
{
"type": "TextBlock",
"text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
"wrap": true
}
]
},
{
"width": 1,
"spacing": "large",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "This is a textblock that doesn't stretch, but the input text does",
"wrap": true
},
{
"type": "Input.Time",
"id": "input1",
"placeholder": "enter time",
"height": "stretch"
},
{
"type": "TextBlock",
"text": "One last text block at the bottom",
"wrap": true
}
]
}
]
}
]
}
47 changes: 47 additions & 0 deletions samples/Tests/ColumnSet.Input.Toggle.VerticalStretch.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
{
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
"type": "AdaptiveCard",
"height": "stretch",
"version": "1.0",
"body": [
{
"type": "ColumnSet",
"height": "stretch",
"columns": [
{
"width": 1,
"items": [
{
"type": "TextBlock",
"text": "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.",
"wrap": true
}
]
},
{
"width": 1,
"spacing": "large",
"separator": true,
"items": [
{
"type": "TextBlock",
"text": "This is a textblock that doesn't stretch, but the input text does",
"wrap": true
},
{
"type": "Input.Toggle",
"id": "input1",
"title": "Placeholder title",
"height": "stretch"
},
{
"type": "TextBlock",
"text": "One last text block at the bottom",
"wrap": true
}
]
}
]
}
]
}
Loading

0 comments on commit 0475bc8

Please sign in to comment.