Removes repository/vcs entries from composer.json and adds requirements #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannylamb
requested changes
Jan 26, 2017
| @@ -41,6 +29,8 @@ | |||
| "drupal/media_entity": "^1.6", | |||
| "drupal/media_entity_image": "^1.2", | |||
| "drupal/bootstrap": "^3.1", | |||
| "islandora/islandora": "dev-8.x-1.x", | |||
| "islandora/claw-jsonld": "dev-8.x-1.x", | |||
There was a problem hiding this comment.
These will get brought in as transitive dependencies and can be removed.
There was a problem hiding this comment.
Duh, shoulda known that. I just pushed another commit that removes islandora and claw-jsonld. I did a fresh composer install and web/modules/contrib contained islandora, islandora_collection and claw-jsonld so should be good to go.
dannylamb
approved these changes
Jan 26, 2017
dannylamb
pushed a commit
to dannylamb/drupal-project
that referenced
this pull request
Feb 3, 2017
…ts (islandora-deprecated#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements
ruebot
pushed a commit
to yorkulibraries/drupal-project
that referenced
this pull request
Mar 22, 2017
…ts (islandora-deprecated#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements
ruebot
pushed a commit
to yorkulibraries/drupal-project
that referenced
this pull request
Mar 22, 2017
…ts (islandora-deprecated#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements
dannylamb
pushed a commit
that referenced
this pull request
Mar 23, 2017
* Ignore web/sites/*/settings.php and web/sites/*/settings.local.php by default (drupal-composer#178) * Prefix paths with a slash (drupal-composer#245) * Update dev dependencies (SA-CORE-2017-001) https://www.drupal.org/SA-2017-001 * Fix typo in README.md Fixes drupal-composer#251 * Adding Islandora dependencies (#2) * Adding Islandora dependencies Part of Islandora/documentation#474 * Adding the github for claw-jsonld * Removing requirement on islandora/islandora islandora/islandora_collection requires it already. * Removes repository/vcs entries from composer.json and adds requirements (#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements * Revert to drupal/rdf_ui 1.x-dev version (#4) * ISSUE-513 Fixes Drupal 8.1.x compatibility issue with drupal/rdf_ui by setting version fixed to 1.x-dev * Lock package versions to stuff we know work * Adding Islandora dependencies (#2) * Adding Islandora dependencies Part of Islandora/documentation#474 * Adding the github for claw-jsonld * Removing requirement on islandora/islandora islandora/islandora_collection requires it already. * Removes repository/vcs entries from composer.json and adds requirements (#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements * Remove and ignore composer.lock; Resolves Islandora/documentation#530 * Pull Request Template (#8) * address Islandora/documentation#537 (#9)
dannylamb
pushed a commit
to dannylamb/drupal-project
that referenced
this pull request
May 2, 2017
…ts (islandora-deprecated#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements
dannylamb
pushed a commit
to dannylamb/drupal-project
that referenced
this pull request
May 2, 2017
…ts (islandora-deprecated#3) * Removes repository/vcs entries from composer.json and adds requirements * Removes islandora and claw-jsonld from composer.json requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Islandora/documentation#497
Removes lines 18-29 from composer.json (repository/vcs entries) and adds islandora & claw-jsonld to requirements section.