Updating to grok 3.1.0

[dannylamb]

GitHub Issue: Islandora/documentation#1285

What does this Pull Request do?

Updates Grok to v3.1.0, which does not seg fault when converting tiffs on Ubuntu 18.04 like v2.3.0 does.

How should this be tested?

• Change the version in requirements.yml to point to this branch:

src: https://github.com/Islandora-Devops/ansible-role-grok
name: Islandora-Devops.grok
version: master

to

src: https://github.com/Islandora-Devops/ansible-role-grok
name: Islandora-Devops.grok
version: grok-3-1-0

• rm -rf roles/external
• vagrant up

After it's done building, put a Tiff in your playbook's root directory, ssh in, and run convert on it.

• vagrant ssh
• cd /home/ubuntu/islandora
• convert my.tiff my.jp2

No seg fault! You can run identify on the resulting jp2 to confirm it's ok.

Interested parties

@Islandora-Devops/committers

[elizoller]

I'm testing a build with this now.

[elizoller]

I was able to confirm that this indeed updating Grok successfully and I was able to generate a JP2 from a TIF. What about the travis builds though?

[dannylamb]

Oof... that looks like we're not compiling right at all in our travis env. I'll take a look and see if I can address it easily here.

[dannylamb]

🤔 looks like there's role tasks and then role_under_test tasks. The dependencies to compile grok are pulled in under role, but not role_under_test. And compiling happens as role_under_test. @jonathangreen do you have any insight as to the distinction between the two? Seems like we should be compiling with role first, but I really don't know enough about testing Ansible roles to be confident here.

[seth-shaw-unlv]

@dannylamb it looks like the CentOS failure is because we are still setting the version to the 3.x branch for both Ubuntu and CentOS. We need to push this variable into vars like we did for islandora-playbook (Islandora-Devops/islandora-playbook@5a0e2b1).

After that, it is and idempotence issue. We need to figure out how to skip the build process if we've already built/installed grok.

[seth-shaw-unlv]

@dannylamb, I presume we can close this (and related issue Islandora/documentation#1469) as superseded by Islandora-Devops/islandora-playbook#168?