chore: Update node-gyp, ssh2 and fix codemagic build #17598
Conversation
WalkthroughThis pull request introduces modifications to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
codemagic.yaml (1)
194-194: LGTM! Consider cleaning up instance type comments.The environment reference is correctly applied to both production and development Android workflows. However, there are commented-out instance type configurations that could be cleaned up or tracked properly.
Consider moving the commented instance type configurations to a ticket or documentation:
- ## Switch when we have billing - # instance_type: linux_x2Also applies to: 224-224
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
codemagic.yaml(6 hunks)package.json(0 hunks)
💤 Files with no reviewable changes (1)
- package.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: prepare
- GitHub Check: Island.is Prod App Android
🔇 Additional comments (3)
codemagic.yaml (3)
100-100: LGTM! Addresses Android build review issues.The
changes_not_sent_for_review: trueflag correctly configures Codemagic to stop requesting reviews for new Android builds, addressing the reported error.
122-122: LGTM! Consistent environment configuration for iOS workflows.The environment reference is correctly applied to both production and development iOS workflows while maintaining their specific configurations.
Also applies to: 156-156
17-18: LGTM! Verify Node.js version compatibility.The environment definition with Node.js 20.15.0 is clear and follows YAML anchor best practices.
Let's verify this version matches other configuration files:
✅ Verification successful
✓ Node.js version 20.15.0 is consistent across configuration files
The version matches in:
- package.json
- README.md
- codemagic.yaml
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Check Node.js version across configuration files echo "Checking Node.js version in various config files..." rg -g '!codemagic.yaml' -i 'node.*20\.15\.0|node.*version' .Length of output: 68469
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17598 +/- ##
==========================================
- Coverage 35.57% 35.57% -0.01%
==========================================
Files 7030 7030
Lines 150466 150466
Branches 42959 42959
==========================================
- Hits 53534 53530 -4
- Misses 96932 96936 +4 Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 10 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
* chore: Specify node version for codemagic * chore: Upgrade node-gyp and ssh2 to fix yarn install issues * chore: Disable review in google play
We should not specify a node-gyp version in our dependencies. Most dependencies automatically depend on the "latest" version of node-gyp to build their native addons.
Summary by CodeRabbit
Configuration
Dependency Management
node-gypdependency from project dependencies