feat(new-primary-school): Add temporary application type and remove "Moving abroad" #17556
Conversation
WalkthroughThis pull request introduces significant changes to the New Primary School application template, focusing on simplifying and standardizing the application process. The primary modifications include the introduction of a new Changes
Sequence DiagramsequenceDiagram
participant User
participant ApplicationForm
participant ApplicationType
participant Sections
User->>ApplicationForm: Start Application
ApplicationForm->>ApplicationType: Select Application Type
ApplicationType-->>ApplicationForm: Validate Type
ApplicationForm->>Sections: Render Sections Based on Type
Sections-->>ApplicationForm: Display Relevant Sections
User->>ApplicationForm: Complete Application
Possibly related PRs
Suggested Labels
Suggested Reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 10 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
♻️ Duplicate comments (1)
libs/application/templates/new-primary-school/src/fields/Review/review-groups/Child.tsx (1)
105-105: 🛠️ Refactor suggestionMaintain consistency in responsive layouts.
Similar to the previous instance, removing responsive spans here could impact the layout adaptability across different screen sizes.
🧹 Nitpick comments (4)
libs/application/templates/new-primary-school/src/fields/Review/review-groups/ReasonForApplication.tsx (1)
51-51: Consider maintaining consistent GridColumn span patterns.The GridColumn span is defined as a string
"12/12", while other GridColumns in the file use array notation['12/12', '12/12', '12/12', '5/12']. Consider maintaining consistency in how spans are defined across the component.- <GridColumn span="12/12"> + <GridColumn span={['12/12', '12/12', '12/12', '12/12']}>libs/application/templates/new-primary-school/src/forms/Prerequisites/applicationTypeSubSection.ts (1)
9-27: Add aria-label for better accessibility.The radio field implementation looks good, but could benefit from accessibility improvements.
Add aria-label to improve screen reader experience:
buildRadioField({ id: 'applicationType', title: newPrimarySchoolMessages.pre.applicationTypeSubSectionTitle, description: newPrimarySchoolMessages.pre.applicationTypeSubSectionDescription, + ariaLabel: newPrimarySchoolMessages.pre.applicationTypeSubSectionTitle, options: [ { value: ApplicationType.NEW_PRIMARY_SCHOOL, dataTestId: 'new-primary-school', label: newPrimarySchoolMessages.shared.applicationName, }, // ... ], required: true, })libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/currentSchoolSubSection.ts (1)
33-33: Consider adding a description message.The title change makes it more concise, but consider adding a description field to provide more context about what "current school" means.
libs/application/templates/new-primary-school/src/fields/Review/index.tsx (1)
173-176: Consider extracting repeated conditions into constants.The condition for siblings could be extracted into a constant at the top of the component for better maintainability.
+ const shouldShowSiblings = reasonForApplication === + ReasonForApplicationOptions.SIBLINGS_IN_SAME_SCHOOL; // Later in the JSX - {reasonForApplication === - ReasonForApplicationOptions.SIBLINGS_IN_SAME_SCHOOL && ( + {shouldShowSiblings && ( <Siblings {...childProps} /> )}
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (24)
libs/application/template-api-modules/src/lib/modules/templates/new-primary-school/new-primary-school.utils.ts(2 hunks)libs/application/templates/new-primary-school/src/fields/Review/index.tsx(3 hunks)libs/application/templates/new-primary-school/src/fields/Review/review-groups/Child.tsx(2 hunks)libs/application/templates/new-primary-school/src/fields/Review/review-groups/Contacts.tsx(1 hunks)libs/application/templates/new-primary-school/src/fields/Review/review-groups/CurrentSchool.tsx(2 hunks)libs/application/templates/new-primary-school/src/fields/Review/review-groups/Languages.tsx(4 hunks)libs/application/templates/new-primary-school/src/fields/Review/review-groups/Parents.tsx(1 hunks)libs/application/templates/new-primary-school/src/fields/Review/review-groups/ReasonForApplication.tsx(2 hunks)libs/application/templates/new-primary-school/src/fields/Review/review-groups/School.tsx(3 hunks)libs/application/templates/new-primary-school/src/fields/Review/review-groups/Siblings.tsx(1 hunks)libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/differentNeedsSection/allergiesAndIntolerancesSubSection.ts(2 hunks)libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/differentNeedsSection/index.ts(0 hunks)libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/currentSchoolSubSection.ts(2 hunks)libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/index.ts(1 hunks)libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/newSchoolSubSection.ts(0 hunks)libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/reasonForApplicationSubSection.ts(1 hunks)libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/startingSchoolSubSection.ts(1 hunks)libs/application/templates/new-primary-school/src/forms/Prerequisites/applicationTypeSubSection.ts(1 hunks)libs/application/templates/new-primary-school/src/forms/Prerequisites/index.ts(2 hunks)libs/application/templates/new-primary-school/src/lib/NewPrimarySchoolTemplate.ts(1 hunks)libs/application/templates/new-primary-school/src/lib/constants.ts(1 hunks)libs/application/templates/new-primary-school/src/lib/dataSchema.ts(2 hunks)libs/application/templates/new-primary-school/src/lib/messages.ts(3 hunks)libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts(3 hunks)
💤 Files with no reviewable changes (2)
- libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/differentNeedsSection/index.ts
- libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/newSchoolSubSection.ts
✅ Files skipped from review due to trivial changes (5)
- libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/index.ts
- libs/application/templates/new-primary-school/src/fields/Review/review-groups/Languages.tsx
- libs/application/templates/new-primary-school/src/fields/Review/review-groups/Contacts.tsx
- libs/application/templates/new-primary-school/src/fields/Review/review-groups/Siblings.tsx
- libs/application/templates/new-primary-school/src/fields/Review/review-groups/Parents.tsx
🧰 Additional context used
📓 Path-based instructions (17)
libs/application/templates/new-primary-school/src/forms/Prerequisites/applicationTypeSubSection.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/startingSchoolSubSection.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/fields/Review/review-groups/Child.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/forms/Prerequisites/index.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/template-api-modules/src/lib/modules/templates/new-primary-school/new-primary-school.utils.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/lib/constants.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/lib/NewPrimarySchoolTemplate.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/currentSchoolSubSection.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/fields/Review/review-groups/School.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/lib/dataSchema.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/fields/Review/review-groups/CurrentSchool.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/fields/Review/index.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/differentNeedsSection/allergiesAndIntolerancesSubSection.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/lib/messages.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/fields/Review/review-groups/ReasonForApplication.tsx (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/reasonForApplicationSubSection.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
📓 Learnings (5)
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/startingSchoolSubSection.ts (1)
Learnt from: veronikasif
PR: island-is/island.is#16096
File: libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/newSchoolSubSection.ts:81-90
Timestamp: 2024-11-12T15:15:20.157Z
Learning: When checking conditions involving variables like `schoolMunicipality` and `newSchoolHiddenInput`, ensure to verify that `schoolMunicipality` has a value before comparing it to `newSchoolHiddenInput`.
libs/application/templates/new-primary-school/src/lib/constants.ts (1)
Learnt from: veronikasif
PR: island-is/island.is#16304
File: libs/application/templates/new-primary-school/src/lib/constants.ts:29-31
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In `libs/application/templates/new-primary-school/src/lib/constants.ts`, the enum string values in `ReasonForApplicationOptions` may match server-provided values, even if they appear to have typos. Avoid flagging these as typos.
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/currentSchoolSubSection.ts (1)
Learnt from: veronikasif
PR: island-is/island.is#16096
File: libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/newSchoolSubSection.ts:81-90
Timestamp: 2024-11-12T15:15:20.157Z
Learning: When checking conditions involving variables like `schoolMunicipality` and `newSchoolHiddenInput`, ensure to verify that `schoolMunicipality` has a value before comparing it to `newSchoolHiddenInput`.
libs/application/templates/new-primary-school/src/lib/dataSchema.ts (2)
Learnt from: veronikasif
PR: island-is/island.is#16304
File: libs/application/templates/new-primary-school/src/lib/dataSchema.ts:79-79
Timestamp: 2024-11-12T15:15:20.157Z
Learning: In `libs/application/templates/new-primary-school/src/lib/dataSchema.ts`, for the `reasonForApplication` field, since the options come from the server, we cannot use `z.nativeEnum` or `z.enum`, and should use `z.string()` instead.
Learnt from: veronikasif
PR: island-is/island.is#16304
File: libs/application/templates/new-primary-school/src/lib/dataSchema.ts:103-103
Timestamp: 2024-11-12T15:15:20.157Z
Learning: In `libs/application/templates/new-primary-school/src/lib/dataSchema.ts`, when comparing the `reason` field in `reasonForApplication`, which comes from the server as a string, avoid comparing it directly to `ReasonForApplicationOptions` enum values, as the enum may not include all server-provided values.
libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts (1)
Learnt from: veronikasif
PR: island-is/island.is#17477
File: libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts:82-115
Timestamp: 2025-01-13T14:20:07.540Z
Learning: In the new-primary-school application template, the user prefers to keep the type casting approach for extracting allergies data from application answers, rather than introducing additional type safety measures.
🔇 Additional comments (21)
libs/application/templates/new-primary-school/src/fields/Review/review-groups/ReasonForApplication.tsx (2)
Line range hint
1-26: LGTM! Well-structured imports and props.The code follows best practices with:
- Named imports enabling effective tree-shaking
- Proper TypeScript usage for props
- Reusable components from shared libraries
Line range hint
27-93: LGTM! Well-implemented review component.The implementation:
- Properly handles loading and error states
- Uses shared UI components effectively
- Correctly implements conditional rendering based on application type
- Successfully removes the "Moving abroad" related logic as per PR objectives
libs/application/templates/new-primary-school/src/fields/Review/review-groups/Child.tsx (1)
Line range hint
1-138: Verify responsive behavior across all review group components.The changes to fixed spans appear to be part of a broader pattern across review group components. This could affect the overall responsive design strategy.
Let's check for similar changes in other review group components:
✅ Verification successful
Responsive behavior is consistent across review group components
The span properties follow a consistent pattern across all review group components, with appropriate responsive breakpoints and column widths. The changes in the Child component align with the established responsive design strategy.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for similar span property changes in other review group components # Look for both array-based and string-based span properties to assess consistency echo "Checking for array-based spans..." rg "span=\{\[.*\]\}" "libs/application/templates/new-primary-school/src/fields/Review/review-groups/" echo "Checking for string-based spans..." rg "span=\"\d+/\d+\"" "libs/application/templates/new-primary-school/src/fields/Review/review-groups/"Length of output: 6352
libs/application/templates/new-primary-school/src/forms/Prerequisites/index.ts (1)
4-4: LGTM! Logical ordering of subsections.The changes maintain a clear separation of concerns and follow a logical flow: application type selection, followed by external data, and then children information.
Also applies to: 18-22
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/startingSchoolSubSection.ts (1)
Line range hint
24-30: Verify date validation across timezones.The minDate validation using
new Date()might behave differently across timezones.Consider using a more specific date validation:
-minDate: () => new Date(), +minDate: () => { + const today = new Date() + today.setHours(0, 0, 0, 0) + return today +},libs/application/templates/new-primary-school/src/lib/constants.ts (1)
57-61: LGTM! Well-structured enum definition.The new
ApplicationTypeenum follows TypeScript best practices with clear, descriptive string literal values.libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/currentSchoolSubSection.ts (1)
20-24: LGTM! Clear conditional rendering logic.The condition effectively controls section visibility based on application type, with good documentation.
libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/reasonForApplicationSubSection.ts (1)
82-87: LGTM! Simplified condition logic.The alert message condition has been streamlined to focus solely on MOVING_MUNICIPALITY, improving code clarity.
libs/application/templates/new-primary-school/src/fields/Review/review-groups/School.tsx (2)
92-101: LGTM! Well-structured conditional rendering.The date field is now correctly shown only for NEW_PRIMARY_SCHOOL applications, improving component reusability.
53-53: Verify responsive behavior.The GridColumn span has been simplified from an array to a string. Please ensure this doesn't affect the component's responsive behavior across different screen sizes.
✅ Verification successful
Fixed span "12/12" is correct for the heading section
The simplified span is intentional and appropriate as this GridColumn contains a section heading that should span the full width across all breakpoints. The file correctly implements responsive behavior where needed, using array notation for content sections that require different spans across breakpoints.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for other GridColumn components to verify consistent span usage rg -A 1 "GridColumn.*span=" --type tsxLength of output: 68
Script:
#!/bin/bash # Search for GridColumn span patterns in TypeScript/React files rg -g '*.{ts,tsx}' -B 1 -A 2 'GridColumn.*span=' # Alternative search to find all GridColumn usages rg -g '*.{ts,tsx}' -B 1 -A 2 '<GridColumn'Length of output: 69510
Script:
#!/bin/bash # Check the file history for the specific line git log -L :GridColumn:libs/application/templates/new-primary-school/src/fields/Review/review-groups/School.tsxLength of output: 0
Script:
#!/bin/bash # Find and show the specific file content rg -l "review-groups/School" -g "*.tsx" cat libs/application/templates/new-primary-school/src/fields/Review/review-groups/School.tsxLength of output: 3779
libs/application/templates/new-primary-school/src/lib/dataSchema.ts (1)
20-23: LGTM! Type-safe application type validation.The addition of the
applicationTypefield with strict enum validation ensures type safety and prevents invalid values.libs/application/templates/new-primary-school/src/forms/NewPrimarySchoolForm/differentNeedsSection/allergiesAndIntolerancesSubSection.ts (1)
19-23: LGTM! Clear conditional rendering logic.The condition is well-implemented and clearly documented, ensuring the section is only displayed for enrollment applications.
libs/application/templates/new-primary-school/src/fields/Review/index.tsx (2)
168-170: LGTM! Appropriate conditional rendering.The CurrentSchool component is correctly rendered only for new primary school applications.
179-181: LGTM! Clear enrollment-specific component rendering.The AllergiesAndIntolerances component is correctly rendered only for enrollment applications.
libs/application/templates/new-primary-school/src/lib/NewPrimarySchoolTemplate.ts (1)
34-37: LGTM! Good improvement in application name handling.The change from static to dynamic application name determination improves flexibility and context-awareness of the template.
Also applies to: 45-45
libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts (3)
20-21: LGTM! Clean implementation of application type handling.The addition of application type extraction follows the established pattern and user preferences for type casting.
Also applies to: 24-28
163-163: LGTM! Consistent return object update.The applicationType is properly added to the return object, maintaining alphabetical ordering.
343-351: LGTM! Well-structured new function.The determineNameFromApplicationAnswers function is clear, focused, and follows the single responsibility principle.
libs/application/templates/new-primary-school/src/lib/messages.ts (3)
13-17: LGTM! Well-structured message definition.The new enrollment application name message follows the established pattern with clear ID and description.
123-132: LGTM! Clear and user-friendly application type messages.The new application type messages are well-structured and provide clear guidance to users.
391-392: LGTM! Simplified message key.The rename from currentSchoolInfo to currentSchool improves clarity while maintaining the same content.
libs/application/templates/new-primary-school/src/fields/Review/review-groups/Child.tsx
Show resolved
Hide resolved
...imary-school/src/forms/NewPrimarySchoolForm/primarySchoolSection/startingSchoolSubSection.ts
Show resolved
Hide resolved
libs/application/templates/new-primary-school/src/fields/Review/review-groups/CurrentSchool.tsx
Show resolved
Hide resolved
...emplate-api-modules/src/lib/modules/templates/new-primary-school/new-primary-school.utils.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
libs/application/templates/new-primary-school/src/forms/Prerequisites/index.ts (1)
22-28: LGTM! Consider enhancing type safety.The conditional section inclusion is well-implemented. For additional type safety, consider explicitly typing the children array.
- children: [ + children: Array<typeof applicationTypeSubSection | typeof externalDataSubSection | typeof childrenSubSection> = [libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts (2)
24-30: Consider adding type guard for applicationType.The implementation looks good and maintains backward compatibility. However, consider adding a type guard to ensure type safety:
- let applicationType = getValueViaPath( + let applicationType = getValueViaPath<ApplicationType>( answers, 'applicationType', ) as ApplicationTypeAlso applies to: 165-165
345-353: Add JSDoc documentation for better code maintainability.The function implementation is clean and follows best practices. Consider adding JSDoc documentation to improve maintainability:
+/** + * Determines the application name based on the application type. + * @param application - The application object containing answers + * @returns The appropriate application name message based on the application type + */ export const determineNameFromApplicationAnswers = ( application: Application, ) => {
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
libs/application/templates/new-primary-school/src/forms/Prerequisites/index.ts(2 hunks)libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts(3 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
libs/application/templates/new-primary-school/src/forms/Prerequisites/index.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts (1)
Pattern libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
📓 Learnings (1)
libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts (1)
Learnt from: veronikasif
PR: island-is/island.is#17477
File: libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts:82-115
Timestamp: 2025-01-13T14:20:07.540Z
Learning: In the new-primary-school application template, the user prefers to keep the type casting approach for extracting allergies data from application answers, rather than introducing additional type safety measures.
🔇 Additional comments (4)
libs/application/templates/new-primary-school/src/forms/Prerequisites/index.ts (2)
3-3: LGTM! Well-structured imports.The imports follow good practices by:
- Utilizing shared utilities for environment checks
- Maintaining proper module boundaries for form sections
Also applies to: 5-5
9-10: Verify testing coverage across environments.While the environment-based feature flag is clear, ensure that testing strategies account for both production and non-production scenarios to maintain quality across environments.
Consider:
- Adding tests for both environmental conditions
- Documenting the rationale for production exclusion
- Planning for eventual production release
libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts (2)
12-12: LGTM: Import statements are properly organized.The new imports are correctly placed and used within the file.
Also applies to: 20-20
Line range hint
1-353: LGTM: Code complies with coding guidelines.The implementation adheres to all specified guidelines:
- Uses TypeScript effectively for type definitions
- Functions are reusable across different NextJS apps
- Follows proper export patterns for effective tree-shaking
libs/application/templates/new-primary-school/src/forms/Prerequisites/index.ts
Outdated
Show resolved
Hide resolved
libs/application/templates/new-primary-school/src/lib/newPrimarySchoolUtils.ts
Show resolved
Hide resolved
…i-domains-air-discount-scheme,api-domains-application,api-domains-auth,api-domains-auth-admin,api-domains-document-provider,api-domains-endorsement-system update dirty files
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 10 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (1)
|
[TS-967] Add mock application type
[TS-953] Update Reason page
What
Added a new page to select application type, this page is temporary
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
Release Notes
New Features
Improvements
Changes
User Experience