Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Boost.ai - Set language depending on activeLocale #17461

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Jan 9, 2025

Boost.ai - Set language depending on activeLocale

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • New Features

    • Enhanced language settings for chat panel
    • Improved locale-based language selection when initializing or opening chat interface
  • Bug Fixes

    • Ensured consistent language setting across chat panel interactions

The changes provide a more responsive language handling mechanism, automatically setting the appropriate language based on the active locale when the chat panel is accessed.

@RunarVestmann RunarVestmann added the deploy-feature Deploys features to dev label Jan 9, 2025
Copy link
Contributor

coderabbitai bot commented Jan 9, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the BoostChatPanel.tsx component to improve language handling in the chat panel. The changes focus on enhancing the locale-specific functionality by updating the useEffect hook to include activeLocale as a dependency and adding logic to set the start language dynamically. The modifications ensure that the chat panel's language settings are more responsive to locale changes, both during initialization and when the chat bubble is clicked.

Changes

File Change Summary
apps/web/components/ChatPanel/BoostChatPanel/BoostChatPanel.tsx - Added activeLocale to useEffect dependencies
- Implemented window.boost.chatPanel.setStartLanguage to set language based on active locale
- Updated ChatBubble onClick handler to include language setting logic

Sequence Diagram

sequenceDiagram
    participant User
    participant ChatPanel
    participant Locale
    
    User->>ChatPanel: Click Chat Bubble
    ChatPanel->>Locale: Get Active Locale
    Locale-->>ChatPanel: Return Locale (e.g., 'en-US')
    ChatPanel->>ChatPanel: Set Start Language
    ChatPanel->>User: Display Chat Panel
Loading

Possibly related PRs

Suggested reviewers

  • stjanilofts
  • mannipje

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cbe89fc and 0a13cc6.

📒 Files selected for processing (1)
  • apps/web/components/ChatPanel/BoostChatPanel/BoostChatPanel.tsx (3 hunks)

Finishing Touches

  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

Affected services are: web,
Feature deployment of your services will begin shortly. Your feature will be accessible here:
https://web-boost-ai-language-change-beta.dev01.devland.is/

Deployed services: web.
Excluded services: ``

@datadog-island-is
Copy link

datadog-island-is bot commented Jan 9, 2025

Datadog Report

Branch report: feature/web-boost-ai-language-change
Commit report: 95039c3
Test service: web

✅ 0 Failed, 84 Passed, 0 Skipped, 34.83s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.66%. Comparing base (cbe89fc) to head (0a13cc6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...onents/ChatPanel/BoostChatPanel/BoostChatPanel.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17461      +/-   ##
==========================================
- Coverage   35.66%   35.66%   -0.01%     
==========================================
  Files        6941     6941              
  Lines      149145   149150       +5     
  Branches    42650    42652       +2     
==========================================
  Hits        53193    53193              
- Misses      95952    95957       +5     
Flag Coverage Δ
web 2.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...onents/ChatPanel/BoostChatPanel/BoostChatPanel.tsx 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe89fc...0a13cc6. Read the comment docs.

@RunarVestmann RunarVestmann added automerge Merge this PR as soon as all checks pass and removed deploy-feature Deploys features to dev labels Jan 9, 2025
@RunarVestmann RunarVestmann marked this pull request as ready for review January 9, 2025 14:34
@RunarVestmann RunarVestmann requested a review from a team as a code owner January 9, 2025 14:34
@RunarVestmann RunarVestmann changed the title feat(web): Boost.ai - Testing out setStartLanguage method feat(web): Boost.ai - Set language depending on activeLocale Jan 9, 2025
@kodiakhq kodiakhq bot merged commit af80723 into main Jan 9, 2025
26 checks passed
@kodiakhq kodiakhq bot deleted the feature/web-boost-ai-language-change branch January 9, 2025 14:48
RunarVestmann added a commit that referenced this pull request Jan 9, 2025
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this pull request Jan 9, 2025
…17461 (#17463)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants