fix(web): Event card spacing #17439

RunarVestmann · 2025-01-08T11:15:36Z

Event card spacing

Before

After

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

Style
- Refined conditional rendering logic in the EventInformationBox component by explicitly converting startTime to a boolean
- Improved code clarity without changing existing functionality

coderabbitai · 2025-01-08T11:15:43Z

Walkthrough

The pull request introduces a minor modification in the OrganizationEventArticle.tsx file, specifically within the EventInformationBox component. The change involves refining the conditional rendering logic by replacing a direct truthiness check with an explicit Boolean() conversion for event.time?.startTime. This adjustment ensures a more explicit boolean evaluation without altering the fundamental behavior of the component.

Changes

File	Change Summary
`apps/web/screens/Organization/OrganizationEvents/OrganizationEventArticle.tsx`	Modified conditional rendering logic to use `Boolean()` for explicit type conversion of `event.time?.startTime`

Possibly related PRs

fix(web): Temporary event licences - Prevent 0 from being displayed #16481: Similar use of Boolean() constructor in conditional rendering for TemporaryEventLicencesList component
fix(web): News - images inside of content are either fetched too small or too large #17429: Updates to rendering logic for image URL parameters in NewsArticle component

Suggested reviewers

mannipje

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e2ecff6 and e4b20fa.

📒 Files selected for processing (1)

apps/web/screens/Organization/OrganizationEvents/OrganizationEventArticle.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

apps/web/screens/Organization/OrganizationEvents/OrganizationEventArticle.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

NextJS best practices, including file structure, API routes, and static generation methods.
Efficient state management and server-side rendering techniques.
Optimal use of TypeScript for component and utility type safety."

🔇 Additional comments (2)

apps/web/screens/Organization/OrganizationEvents/OrganizationEventArticle.tsx (2)

Line range hint 1-391: Well-structured component with proper spacing implementation!

The component follows NextJS and TypeScript best practices:

Proper use of design system components for spacing

Type-safe props and context

Responsive layout handling

Clean separation of concerns

Line range hint 108-122: Consider using a more idiomatic approach for the boolean check.

While using Boolean() works, a direct boolean check would be more idiomatic in React/TypeScript. Also, this change doesn't seem to address the event card spacing issues mentioned in the PR objectives.

Consider this alternative:
-        {Boolean(event.time?.startTime) && (
+        {!!event.time?.startTime && (
The PR objectives mention fixing event card spacing issues, but this change only modifies boolean conversion logic. Could you clarify how this change addresses the spacing problems?

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-01-08T11:31:52Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.67%. Comparing base (b3202f5) to head (242c479).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...on/OrganizationEvents/OrganizationEventArticle.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #17439   +/-   ##
=======================================
  Coverage   35.66%   35.67%           
=======================================
  Files        6941     6941           
  Lines      149131   149131           
  Branches    42640    42641    +1     
=======================================
+ Hits        53194    53196    +2     
+ Misses      95937    95935    -2

Flag	Coverage Δ
air-discount-scheme-backend	`48.24% <ø> (ø)`
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.35% <ø> (ø)`
api-catalogue-services	`75.81% <ø> (ø)`
api-domains-air-discount-scheme	`37.99% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`48.49% <ø> (ø)`
api-domains-communications	`39.47% <ø> (ø)`
api-domains-criminal-record	`48.03% <ø> (ø)`
api-domains-driving-license	`44.86% <ø> (ø)`
api-domains-education	`31.27% <ø> (ø)`
api-domains-health-insurance	`35.47% <ø> (ø)`
api-domains-mortgage-certificate	`35.24% <ø> (ø)`
api-domains-payment-schedule	`42.12% <ø> (ø)`
application-api-files	`61.97% <ø> (ø)`
application-core	`75.60% <ø> (ø)`
application-system-api	`38.75% <ø> (-0.01%)`	⬇️
application-template-api-modules	`27.73% <ø> (ø)`
application-templates-accident-notification	`27.60% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.82% <ø> (ø)`
application-templates-driving-license	`18.17% <ø> (ø)`
application-templates-estate	`13.67% <ø> (ø)`
application-templates-example-payment	`24.69% <ø> (ø)`
application-templates-financial-aid	`14.47% <ø> (ø)`
application-templates-general-petition	`23.13% <ø> (ø)`
application-templates-inheritance-report	`6.59% <ø> (ø)`
application-templates-marriage-conditions	`15.21% <ø> (ø)`
application-templates-mortgage-certificate	`43.73% <ø> (ø)`
application-templates-parental-leave	`29.92% <ø> (+0.11%)`	⬆️
application-types	`6.48% <ø> (ø)`
application-ui-components	`1.22% <ø> (ø)`
application-ui-shell	`22.25% <ø> (ø)`
auth-admin-web	`2.43% <ø> (ø)`
auth-nest-tools	`31.69% <ø> (ø)`
auth-shared	`75.00% <ø> (ø)`
clients-charge-fjs-v2	`28.88% <ø> (ø)`
clients-driving-license	`40.91% <ø> (ø)`
clients-driving-license-book	`43.92% <ø> (ø)`
clients-financial-statements-inao	`49.70% <ø> (ø)`
clients-license-client	`1.26% <ø> (ø)`
clients-middlewares	`72.95% <ø> (-0.58%)`	⬇️
clients-regulations	`43.00% <ø> (ø)`
clients-rsk-company-registry	`31.18% <ø> (ø)`
clients-rsk-personal-tax-return	`38.32% <ø> (ø)`
clients-smartsolutions	`12.77% <ø> (ø)`
clients-syslumenn	`49.47% <ø> (ø)`
clients-zendesk	`50.58% <ø> (ø)`
cms	`0.39% <ø> (ø)`
cms-translations	`38.80% <ø> (ø)`
content-search-index-manager	`95.65% <ø> (ø)`
content-search-toolkit	`8.16% <ø> (ø)`
contentful-apps	`4.69% <ø> (ø)`
dokobit-signing	`62.18% <ø> (ø)`
email-service	`60.15% <ø> (ø)`
feature-flags	`90.83% <ø> (ø)`
file-storage	`45.97% <ø> (ø)`
financial-aid-backend	`51.42% <ø> (ø)`
financial-aid-shared	`17.88% <ø> (ø)`
icelandic-names-registry-backend	`54.33% <ø> (ø)`
infra-nest-server	`48.06% <ø> (ø)`
infra-tracing	`69.94% <ø> (ø)`
island-ui-core	`30.34% <ø> (ø)`
judicial-system-api	`20.23% <ø> (ø)`
judicial-system-audit-trail	`69.02% <ø> (ø)`
judicial-system-backend	`55.88% <ø> (+<0.01%)`	⬆️
judicial-system-formatters	`78.52% <ø> (ø)`
judicial-system-message	`66.66% <ø> (ø)`
judicial-system-message-handler	`48.41% <ø> (ø)`
judicial-system-scheduler	`71.20% <ø> (ø)`
judicial-system-types	`41.54% <ø> (ø)`
judicial-system-web	`27.76% <ø> (ø)`
license-api	`42.94% <ø> (ø)`
localization	`10.15% <ø> (ø)`
logging	`58.02% <ø> (ø)`
message-queue	`67.76% <ø> (ø)`
nest-audit	`65.78% <ø> (ø)`
nest-aws	`51.93% <ø> (ø)`
nest-config	`76.45% <ø> (ø)`
nest-core	`53.16% <ø> (ø)`
nest-feature-flags	`51.06% <ø> (ø)`
nest-problem	`45.64% <ø> (ø)`
nest-sequelize	`94.44% <ø> (ø)`
nest-swagger	`51.13% <ø> (ø)`
nova-sms	`61.52% <ø> (ø)`
portals-admin-regulations-admin	`1.80% <ø> (ø)`
portals-core	`19.58% <ø> (ø)`
residence-history	`85.00% <ø> (ø)`
services-auth-admin-api	`52.54% <ø> (ø)`
services-auth-delegation-api	`58.48% <ø> (+0.01%)`	⬆️
services-auth-ids-api	`52.58% <ø> (+0.01%)`	⬆️
services-auth-public-api	`49.43% <ø> (ø)`
services-sessions	`65.33% <ø> (-0.05%)`	⬇️
services-university-gateway	`49.55% <ø> (+0.11%)`	⬆️
services-user-notification	`46.50% <ø> (-0.04%)`	⬇️
services-user-profile	`56.97% <ø> (ø)`
shared-components	`29.49% <ø> (ø)`
shared-form-fields	`33.37% <ø> (ø)`
shared-mocking	`58.64% <ø> (ø)`
shared-pii	`92.85% <ø> (ø)`
shared-problem	`87.50% <ø> (ø)`
shared-utils	`27.69% <ø> (ø)`
skilavottord-ws	`24.26% <ø> (ø)`
web	`2.39% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...on/OrganizationEvents/OrganizationEventArticle.tsx	`0.00% <0.00%> (ø)`

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3202f5...242c479. Read the comment docs.

datadog-island-is · 2025-01-08T11:43:21Z

Datadog Report

All test runs 94931ac 🔗

✅ 10 Total Test Services: 0 Failed, 10 Passed
🔻 Test Sessions change in coverage: 4 decreased, 2 increased, 194 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-backend`	63	22.74s	N/A	Link
`air-discount-scheme-web`	2	6.48s	N/A	Link
`api`	4	2.43s	N/A	Link
`api-catalogue-services`	23	8.97s	N/A	Link
`api-domains-air-discount-scheme`	6	17.14s	N/A	Link
`api-domains-assets`	3	9.56s	N/A	Link
`api-domains-auth-admin`	18	10.06s	N/A	Link
`api-domains-communications`	5	31.05s	N/A	Link
`api-domains-criminal-record`	5	8.52s	N/A	Link
`api-domains-driving-license`	23	27.05s	N/A	Link

🔻 Code Coverage Decreases vs Default Branch (4)

message-queue - jest 67.46% (-0.8%) - Details
services-auth-delegation-api - jest 50.45% (-0.04%) - Details
services-user-profile - jest 49.26% (-0.04%) - Details
services-university-gateway - jest 45.26% (-0.03%) - Details

Add Boolean conversion to the check

e4b20fa

RunarVestmann added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Jan 8, 2025

RunarVestmann requested a review from a team as a code owner January 8, 2025 11:15

mannipje approved these changes Jan 8, 2025

View reviewed changes

coderabbitai bot approved these changes Jan 8, 2025

View reviewed changes

Merge branch 'main' into fix/web-event-card-spacing

242c479

kodiakhq bot merged commit da87871 into main Jan 8, 2025
265 checks passed

kodiakhq bot deleted the fix/web-event-card-spacing branch January 8, 2025 13:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): Event card spacing #17439

fix(web): Event card spacing #17439

RunarVestmann commented Jan 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 8, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Jan 8, 2025 •

edited

Loading

datadog-island-is bot commented Jan 8, 2025

fix(web): Event card spacing #17439

fix(web): Event card spacing #17439

Conversation

RunarVestmann commented Jan 8, 2025 • edited by coderabbitai bot Loading

Event card spacing

Before

After

Checklist:

Summary by CodeRabbit

coderabbitai bot commented Jan 8, 2025 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Jan 8, 2025 • edited Loading

Codecov Report

datadog-island-is bot commented Jan 8, 2025

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (4)

RunarVestmann commented Jan 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 8, 2025 •

edited

Loading

codecov bot commented Jan 8, 2025 •

edited

Loading