fix(j-s): add missing civil demand title

[thorhildurt]

What

• Asana task
• Adding a missing section title for civil demand question for prosecutor

Why

• Adds context to the "Bótakröfu" section

Screenshots / Gifs

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Added a comprehensive section for managing civil claims in the indictments processing screen
  • Introduced radio buttons to indicate the presence of civil claims
  • Implemented functionality to add, update, and remove civil claimants
  • Enhanced state management for civil claim details

• Documentation

  • Added localization support for civil claims section title

The changes improve the judicial system's web interface by providing more detailed handling of civil claims during case processing.

[coderabbitai]

Walkthrough

The pull request introduces enhanced functionality for managing civil claims within the judicial system's indictments processing screen. A new section for civil demands has been added to the Processing component, allowing users to specify the existence of civil claims and manage associated civil claimants. The implementation includes state management for adding, updating, and removing civil claimants, with options to specify their national ID, name, and representation status.

Changes

File	Change Summary
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx	Added new section for civil demands with radio buttons to indicate civil claims existence, implemented handleHasCivilClaimsChange function to manage civil claimants state
apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/processing.strings.ts	Added new localization entry civilDemandsTitle for civil demands section

Sequence Diagram

sequenceDiagram
    participant User
    participant ProcessingComponent
    participant CivilClaimantsManager

    User->>ProcessingComponent: Select civil claims option
    ProcessingComponent->>CivilClaimantsManager: handleHasCivilClaimsChange
    CivilClaimantsManager-->>ProcessingComponent: Update case state
    ProcessingComponent->>User: Display civil claimants section
    User->>ProcessingComponent: Add/Remove/Update civil claimants
    ProcessingComponent->>CivilClaimantsManager: Manage civil claimants

Loading

Possibly related PRs

• fix(j-s): Civil claimants national id #16780: Modifies Processing component to enhance civil claimant data handling
• fix(j-s): Fix Empty National Id #17149: Addresses national ID handling for defendants

Suggested labels

automerge

Suggested reviewers

• unakb
• oddsson

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 56493cc and fe63379.

📒 Files selected for processing (2)

• apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (1 hunks)
• apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/processing.strings.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/processing.strings.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

📓 Learnings (1)

apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (1)

Learnt from: gudjong
PR: island-is/island.is#15421
File: apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx:55-61
Timestamp: 2024-11-12T15:15:11.835Z
Learning: The `updateCase` method in the `apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx` file has its own error handling, and additional error handling in the `initialize` function is not necessary.

🔇 Additional comments (2)

apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/processing.strings.ts (1)

52-56: Looks good: New string definition is consistent with existing patterns.

The civilDemandsTitle entry aligns with the established structure for message definitions and follows consistent naming in the strings object.

apps/judicial-system/web/src/routes/Prosecutor/Indictments/Processing/Processing.tsx (1)

387-387: Good use of the newly introduced string.

Using strings.civilDemandsTitle for the SectionHeading is consistent and fits well into the existing localization approach.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[datadog-island-is]

Datadog Report

Branch report: j-s/add-missing-civil-demand-title
Commit report: cd5d3b5
Test service: judicial-system-web

✅ 0 Failed, 344 Passed, 0 Skipped, 55.25s Total Time
➡️ Test Sessions change in coverage: 1 no change

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.68%. Comparing base (62fdb45) to head (833511a).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17366      +/-   ##
==========================================
- Coverage   35.68%   35.68%   -0.01%     
==========================================
  Files        6931     6931              
  Lines      148794   148786       -8     
  Branches    42515    42514       -1     
==========================================
- Hits        53097    53092       -5     
+ Misses      95697    95694       -3     

Flag	Coverage Δ
judicial-system-web	27.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...s/Prosecutor/Indictments/Processing/Processing.tsx	0.00% <ø> (ø)
...cutor/Indictments/Processing/processing.strings.ts	0.00% <ø> (ø)

... and 6 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fdb45...833511a. Read the comment docs.