fix(j-s): Remove body from GET request

[unakb]

Remove Body from GET request, because it shouldn't be there

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Enhanced error handling for case fetching, providing clearer feedback for errors.
  • Improved logic for selecting defenders, ensuring necessary checks are enforced.

• Bug Fixes

  • Addressed issues with error differentiation for not found cases and other errors.

[coderabbitai]

Walkthrough

The pull request introduces modifications to the CaseService class in the case.service.ts file, focusing on improving error handling and defender selection logic. The changes enhance the error handling mechanisms for fetching cases and case details, with more precise exception throwing. The updateSubpoenaInfo method now includes stricter validation for defender assignments, ensuring proper checks are performed when selecting a defender.

Changes

File	Change Summary
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/case.service.ts	- Enhanced error handling in fetchCases method - Improved error handling in fetchCase method with 404 status differentiation - Updated updateSubpoenaInfo method to enforce defender selection checks

Sequence Diagram

sequenceDiagram
    participant Client
    participant CaseService
    participant ExternalAPI
    
    Client->>CaseService: fetchCase(caseId)
    CaseService->>ExternalAPI: Request case details
    alt Case found
        ExternalAPI-->>CaseService: Return case details
        CaseService-->>Client: Return case
    else Case not found
        ExternalAPI-->>CaseService: 404 Status
        CaseService->>CaseService: Throw NotFoundException
    else Other error
        ExternalAPI-->>CaseService: Error response
        CaseService->>CaseService: Throw BadGatewayException
    end

Loading

Possibly related PRs

• feat(j-s): digital-mailbox-api. Get case by id #14949: Directly modifies the CaseService class in case.service.ts
• feat(j-s): Update subpoena compensation claim decision  #15104: Involves changes to CaseController and CaseService methods handling subpoenas
• fix(j-s): Digital mailbox API #16301: Modifies CaseResponse class structure
• chore(j-s): Update subpoena status from digital-mailbox #16645: Introduces new method for fetching subpoena status
• feat(j-s): Upload Additional Files to Court #17152: Updates CaseService for file upload handling
• chore(j-s): Add more info to new indictment robot emails #17184: Enhances InternalCaseService for indictment information delivery

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65767dc and 0623a65.

📒 Files selected for processing (1)

• apps/judicial-system/digital-mailbox-api/src/app/modules/cases/case.service.ts (0 hunks)

💤 Files with no reviewable changes (1)

• apps/judicial-system/digital-mailbox-api/src/app/modules/cases/case.service.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.