Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add next folder to dockerignore #17216

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

svanaeinars
Copy link
Member

@svanaeinars svanaeinars commented Dec 12, 2024

Summary by CodeRabbit

  • Chores
    • Updated the .dockerignore file to include the .next/ directory for improved build artifact management.

@svanaeinars svanaeinars requested a review from a team as a code owner December 12, 2024 10:23
@svanaeinars svanaeinars added the test everything 💀 test & build everything 💀 label Dec 12, 2024
Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

Walkthrough

The .dockerignore file has been modified to include an entry that ignores the .next/ directory. This addition specifically targets the build artifacts generated by Next.js applications, enhancing the management of logs and temporary files within the Docker context. No other changes were made to the existing structure or entries of the file.

Changes

File Change Summary
.dockerignore Added entry **/.next/ to ignore the .next/ directory.

Sequence Diagram(s)

sequenceDiagram
    participant Developer
    participant Docker
    Developer->>Docker: Build Docker image
    Docker->>Docker: Read .dockerignore
    Docker->>Docker: Ignore .next/ directory
    Docker->>Docker: Include other files
    Docker->>Developer: Complete image build
Loading

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 65b79cc and fbf5a2b.

📒 Files selected for processing (1)
  • .dockerignore (1 hunks)
🔇 Additional comments (2)
.dockerignore (2)

26-26: LGTM! Well-placed addition to optimize Docker builds

The **/.next/ pattern is correctly added to ignore Next.js build artifacts, which helps reduce Docker image size and ensures fresh builds inside containers.


26-26: Verify impact on existing Docker builds

Let's ensure this change doesn't affect any existing Docker builds that might depend on the .next folder.

✅ Verification successful

Adding .next to .dockerignore is safe and recommended

Based on the verification results:

  • The project uses Next.js (version 14.2.3) as a dependency
  • The Dockerfile uses a multi-stage build process with a specific output-next stage
  • The build process copies the built artifacts from the dist directory, not the .next directory
  • No direct references to .next directory were found in Docker configurations

Adding .next to .dockerignore is actually a good practice as:

  1. The Next.js development cache directory (.next) should not be included in Docker builds
  2. The production build artifacts are properly handled through the dist directory in the multi-stage Dockerfile
  3. This change aligns with Next.js best practices for containerization
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for Dockerfile references to .next directory
# and Next.js related Docker configurations

# Search for Dockerfiles that might reference .next
rg -l --type-add 'docker:*Dockerfile*' -t docker '\.next'

# Look for docker-compose files that might be affected
rg -l --type-add 'compose:*compose.y*ml' -t compose '\.next'

# Check for Next.js related build or start scripts in package.json files
fd -e json -x jq -r 'select(.scripts != null) | .scripts | to_entries | .[] | select(.value | contains("next"))' {} \;

Length of output: 1137


Script:

#!/bin/bash
# Let's try a different approach to check Docker configurations and Next.js usage

# Check Dockerfile content for any Next.js related configurations
fd Dockerfile --type f --exec cat {} \;

# Check package.json for Next.js dependencies and configurations
fd package.json --type f --exec cat {} \; | grep -A 5 -B 5 "\"next\""

# Check if .next directory is used in any configuration files
rg "\.next" --type yaml --type json --type dockerfile

Length of output: 9491


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.56%. Comparing base (b744840) to head (c1ecc20).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #17216      +/-   ##
==========================================
- Coverage   35.66%   35.56%   -0.11%     
==========================================
  Files        6941     6941              
  Lines      149148   149748     +600     
  Branches    42651    43107     +456     
==========================================
+ Hits        53196    53256      +60     
- Misses      95952    96492     +540     
Flag Coverage Δ
air-discount-scheme-backend 48.24% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.35% <ø> (ø)
api-catalogue-services 75.81% <ø> (ø)
api-domains-air-discount-scheme 37.99% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.49% <ø> (ø)
api-domains-communications 39.47% <ø> (ø)
api-domains-criminal-record 48.03% <ø> (ø)
api-domains-driving-license 44.86% <ø> (ø)
api-domains-education 31.27% <ø> (ø)
api-domains-health-insurance 35.47% <ø> (ø)
api-domains-mortgage-certificate 35.24% <ø> (ø)
api-domains-payment-schedule 42.12% <ø> (ø)
application-api-files 61.97% <ø> (ø)
application-core 75.60% <ø> (ø)
application-system-api 38.76% <ø> (ø)
application-template-api-modules 27.72% <ø> (+0.02%) ⬆️
application-templates-accident-notification 27.60% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.82% <ø> (ø)
application-templates-driving-license 18.17% <ø> (ø)
application-templates-estate 13.67% <ø> (ø)
application-templates-example-payment 24.69% <ø> (ø)
application-templates-financial-aid 14.47% <ø> (ø)
application-templates-general-petition 23.13% <ø> (ø)
application-templates-inheritance-report 6.59% <ø> (ø)
application-templates-marriage-conditions 15.21% <ø> (ø)
application-templates-mortgage-certificate 43.73% <ø> (ø)
application-templates-parental-leave 29.92% <ø> (ø)
application-types 6.48% <ø> (ø)
application-ui-components 1.22% <ø> (ø)
application-ui-shell 22.25% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 31.69% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 28.88% <ø> (ø)
clients-driving-license 40.91% <ø> (ø)
clients-driving-license-book 43.92% <ø> (ø)
clients-financial-statements-inao 49.70% <ø> (ø)
clients-license-client 1.26% <ø> (ø)
clients-middlewares 73.20% <ø> (+0.57%) ⬆️
clients-regulations 43.00% <ø> (ø)
clients-rsk-company-registry 31.18% <ø> (ø)
clients-rsk-personal-tax-return 38.32% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.47% <ø> (ø)
clients-zendesk 50.58% <ø> (ø)
cms 0.39% <ø> (ø)
cms-translations 38.80% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.16% <ø> (ø)
contentful-apps 4.69% <ø> (ø)
dokobit-signing 62.18% <ø> (ø)
email-service 60.15% <ø> (ø)
feature-flags 90.83% <ø> (ø)
file-storage 45.97% <ø> (ø)
financial-aid-backend 51.42% <ø> (ø)
financial-aid-shared 17.88% <ø> (ø)
icelandic-names-registry-backend 54.33% <ø> (ø)
infra-nest-server 48.06% <ø> (ø)
infra-tracing 69.94% <ø> (ø)
island-ui-core 30.34% <ø> (ø)
judicial-system-api 20.23% <ø> (ø)
judicial-system-audit-trail 69.02% <ø> (ø)
judicial-system-backend 55.88% <ø> (ø)
judicial-system-formatters 78.52% <ø> (ø)
judicial-system-message 66.66% <ø> (ø)
judicial-system-message-handler 48.41% <ø> (ø)
judicial-system-scheduler 71.20% <ø> (ø)
judicial-system-types 41.54% <ø> (ø)
judicial-system-web 27.76% <ø> (ø)
license-api 43.00% <ø> (+0.07%) ⬆️
localization 10.15% <ø> (ø)
logging 58.02% <ø> (ø)
message-queue 67.05% <ø> (-0.71%) ⬇️
nest-audit 65.78% <ø> (ø)
nest-aws 51.93% <ø> (ø)
nest-config 76.45% <ø> (ø)
nest-core 53.16% <ø> (ø)
nest-feature-flags 50.43% <ø> (-0.63%) ⬇️
nest-problem 45.64% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 51.13% <ø> (ø)
nova-sms 61.52% <ø> (ø)
portals-admin-regulations-admin 1.80% <ø> (ø)
portals-core 19.58% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 52.54% <ø> (ø)
services-auth-delegation-api 58.47% <ø> (ø)
services-auth-ids-api 52.59% <ø> (ø)
services-auth-public-api 49.43% <ø> (+<0.01%) ⬆️
services-sessions 65.38% <ø> (+0.04%) ⬆️
services-university-gateway 49.43% <ø> (-0.09%) ⬇️
services-user-notification 46.54% <ø> (ø)
services-user-profile 56.97% <ø> (ø)
shared-components 29.49% <ø> (ø)
shared-form-fields 33.37% <ø> (ø)
shared-mocking 58.64% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 27.69% <ø> (ø)
skilavottord-ws 24.26% <ø> (ø)
web 2.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b744840...c1ecc20. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Dec 12, 2024

Datadog Report

All test runs 683179f 🔗

10 Total Test Services: 0 Failed, 10 Passed
🔻 Test Sessions change in coverage: 6 decreased, 1 increased (+0.02%), 193 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 63 0 30.66s N/A Link
air-discount-scheme-web 0 0 0 2 0 6.66s N/A Link
api 0 0 0 4 0 2.52s N/A Link
api-catalogue-services 0 0 0 23 0 9.33s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 18.24s N/A Link
api-domains-assets 0 0 0 3 0 9.96s N/A Link
api-domains-auth-admin 0 0 0 18 0 10.82s N/A Link
api-domains-communications 0 0 0 5 0 33.61s N/A Link
api-domains-criminal-record 0 0 0 5 0 8.92s N/A Link
api-domains-driving-license 0 0 0 23 0 29.88s N/A Link

🔻 Code Coverage Decreases vs Default Branch (6)

This report shows up to 5 code coverage decreases.

  • message-queue - jest 67.46% (-0.8%) - Details
  • clients-middlewares - jest 75.6% (-0.1%) - Details
  • services-auth-delegation-api - jest 50.44% (-0.03%) - Details
  • services-auth-ids-api - jest 45.66% (-0.01%) - Details
  • services-university-gateway - jest 45.26% (-0.01%) - Details

@svanaeinars svanaeinars added the deploy-feature Deploys features to dev label Dec 20, 2024
Copy link
Contributor

Affected services are: air-discount-scheme-api,air-discount-scheme-backend,api,application-system-api,download-service,financial-aid-api,financial-aid-backend,financial-aid-open-api,github-actions-cache,icelandic-names-registry-backend,judicial-system-api,judicial-system-digital-mailbox-api,judicial-system-backend,judicial-system-message-handler,judicial-system-scheduler,judicial-system-xrd-api,license-api,reference-backend,regulations-admin-backend,services-auth-admin-api,services-auth-ids-api,services-auth-delegation-api,services-auth-personal-representative,services-auth-personal-representative-public,services-auth-public-api,services-bff,services-contentful-entry-tagger,services-documents,services-endorsements-api,services-form-system,services-search-indexer,services-sessions,services-university-gateway,services-user-notification,services-user-profile,services-xroad-collector,skilavottord-ws,air-discount-scheme-web,auth-admin-web,consultation-portal,contentful-apps,financial-aid-web-osk,financial-aid-web-veita,judicial-system-web,skilavottord-web,web,application-system-form,island-ui-storybook,portals-admin,service-portal,system-e2e,external-contracts-tests,
Feature deployment of your services will begin shortly. Your feature will be accessible here:
https://choredockerignore-next-folder-api-catalogue.dev01.devland.is/api
https://choredockerignore-next-folder-api.dev01.devland.is/download
https://choredockerignore-next-folder-application-callback-xrd.internal.dev01.devland.is/application-payment
https://choredockerignore-next-folder-application-callback-xrd.internal.dev01.devland.is/applications
https://choredockerignore-next-folder-application-payment-callback-xrd.internal.dev01.devland.is/application-payment
https://choredockerignore-next-folder-application-payment-callback-xrd.internal.dev01.devland.is/applications
https://choredockerignore-next-folder-beta.dev01.devland.is/
https://choredockerignore-next-folder-beta.dev01.devland.is/api
https://choredockerignore-next-folder-beta.dev01.devland.is/app/skilavottord/
https://choredockerignore-next-folder-beta.dev01.devland.is/app/skilavottord/api/graphql
https://choredockerignore-next-folder-beta.dev01.devland.is/bff
https://choredockerignore-next-folder-beta.dev01.devland.is/minarsidur
https://choredockerignore-next-folder-beta.dev01.devland.is/samradsgatt
https://choredockerignore-next-folder-beta.dev01.devland.is/stjornbord
https://choredockerignore-next-folder-beta.dev01.devland.is/stjornbord/bff
https://choredockerignore-next-folder-beta.dev01.devland.is/umsoknir
https://choredockerignore-next-folder-license-api-xrd.internal.dev01.devland.is/
https://choredockerignore-next-folder-loftbru-cf.dev01.devland.is/
https://choredockerignore-next-folder-loftbru-cf.dev01.devland.is/api/graphql
https://choredockerignore-next-folder-loftbru-cf.dev01.devland.is/api/public
https://choredockerignore-next-folder-loftbru-cf.dev01.devland.is/api/swagger
https://choredockerignore-next-folder-loftbru.dev01.devland.is/
https://choredockerignore-next-folder-loftbru.dev01.devland.is/api/graphql
https://choredockerignore-next-folder-loftbru.dev01.devland.is/api/public
https://choredockerignore-next-folder-loftbru.dev01.devland.is/api/swagger
https://choredockerignore-next-folder-service-portal-api.internal.dev01.devland.is/
https://choredockerignore-next-folder-services-university-gateway.internal.dev01.devland.is/api
https://choredockerignore-next-folder-sessions-api.internal.dev01.devland.is/
https://choredockerignore-next-folder-ui.dev01.devland.is/

Deployed services: application-system-api,application-system-form,service-portal,service-portal-api,portals-admin,consultation-portal,api,web,xroad-collector,skilavottord-web,skilavottord-ws,services-documents,island-ui-storybook,download-service,icelandic-names-registry-backend,endorsement-system-api,air-discount-scheme-web,air-discount-scheme-backend,air-discount-scheme-api,regulations-admin-backend,external-contracts-tests,application-system-api-worker,license-api,services-sessions,services-sessions-worker,services-sessions-cleanup,services-university-gateway,services-university-gateway-worker,services-bff-portals-admin,services-bff-portals-my-pages.
Excluded services: search-indexer-service,github-actions-cache,user-notification,user-notification-worker,user-notification-cleanup-worker,contentful-entry-tagger-service,contentful-apps

Copy link
Member

@brynjarorng brynjarorng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svanaeinars svanaeinars added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Jan 9, 2025
@kodiakhq kodiakhq bot merged commit 1aa26d4 into main Jan 9, 2025
390 checks passed
@kodiakhq kodiakhq bot deleted the chore/dockerignore-next-folder branch January 9, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-feature Deploys features to dev deprecated:automerge (Disabled) Merge this PR as soon as all checks pass test everything 💀 test & build everything 💀
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants