-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add next folder to dockerignore #17216
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant Docker
Developer->>Docker: Build Docker image
Docker->>Docker: Read .dockerignore
Docker->>Docker: Ignore .next/ directory
Docker->>Docker: Include other files
Docker->>Developer: Complete image build
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🔇 Additional comments (2).dockerignore (2)
The
Let's ensure this change doesn't affect any existing Docker builds that might depend on the ✅ Verification successfulAdding Based on the verification results:
Adding
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for Dockerfile references to .next directory
# and Next.js related Docker configurations
# Search for Dockerfiles that might reference .next
rg -l --type-add 'docker:*Dockerfile*' -t docker '\.next'
# Look for docker-compose files that might be affected
rg -l --type-add 'compose:*compose.y*ml' -t compose '\.next'
# Check for Next.js related build or start scripts in package.json files
fd -e json -x jq -r 'select(.scripts != null) | .scripts | to_entries | .[] | select(.value | contains("next"))' {} \;
Length of output: 1137 Script: #!/bin/bash
# Let's try a different approach to check Docker configurations and Next.js usage
# Check Dockerfile content for any Next.js related configurations
fd Dockerfile --type f --exec cat {} \;
# Check package.json for Next.js dependencies and configurations
fd package.json --type f --exec cat {} \; | grep -A 5 -B 5 "\"next\""
# Check if .next directory is used in any configuration files
rg "\.next" --type yaml --type json --type dockerfile
Length of output: 9491 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17216 +/- ##
==========================================
- Coverage 35.66% 35.56% -0.11%
==========================================
Files 6941 6941
Lines 149148 149748 +600
Branches 42651 43107 +456
==========================================
+ Hits 53196 53256 +60
- Misses 95952 96492 +540 Flags with carried forward coverage won't be shown. Click here to find out more. see 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 10 Total Test Services: 0 Failed, 10 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (6)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary by CodeRabbit
.dockerignore
file to include the.next/
directory for improved build artifact management.