feat(rental-agreement): NationalIdWithName in repeatableTableField #17147

hebaulf · 2024-12-05T14:42:04Z

...

https://app.asana.com/0/1208271027457465/1208407573781564/f

What

Add NationalIdWithName in repeatableTableField for landlords and tenants info
Add address field to repeatableTableField
Validate fields in repeatableTableField

Why

Applicant should be able to look up landlords and tenants by national Id and get name from Þjóðskrá.
Applicant should not be able to continue without adding all information for the landlord/tenant

Screenshots / Gifs

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

coderabbitai · 2024-12-05T14:42:11Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-12-05T14:58:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.74%. Comparing base (fa8f6ba) to head (f71256f).
Report is 1 commits behind head on rental-agreement-application.

Additional details and impacted files

@@                       Coverage Diff                        @@
##           rental-agreement-application   #17147      +/-   ##
================================================================
+ Coverage                         35.71%   35.74%   +0.03%     
================================================================
  Files                              6925     6925              
  Lines                            147813   147577     -236     
  Branches                          42085    42022      -63     
================================================================
- Hits                              52785    52750      -35     
+ Misses                            95028    94827     -201

Flag	Coverage Δ
air-discount-scheme-backend	`48.22% <ø> (ø)`
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.33% <ø> (ø)`
api-catalogue-services	`76.56% <ø> (ø)`
api-domains-air-discount-scheme	`37.96% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`48.49% <ø> (ø)`
api-domains-communications	`39.47% <ø> (ø)`
api-domains-criminal-record	`48.02% <ø> (ø)`
api-domains-driving-license	`44.85% <ø> (ø)`
api-domains-education	`31.26% <ø> (ø)`
api-domains-health-insurance	`35.41% <ø> (ø)`
api-domains-mortgage-certificate	`35.21% <ø> (ø)`
api-domains-payment-schedule	`42.10% <ø> (ø)`
application-api-files	`62.03% <ø> (ø)`
application-core	`76.08% <ø> (ø)`
application-system-api	`38.77% <ø> (-0.02%)`	⬇️
application-template-api-modules	`27.83% <ø> (-0.01%)`	⬇️
application-templates-accident-notification	`29.01% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.93% <ø> (ø)`
application-templates-driving-license	`18.18% <ø> (ø)`
application-templates-estate	`13.83% <ø> (ø)`
application-templates-example-payment	`24.85% <ø> (ø)`
application-templates-financial-aid	`14.42% <ø> (ø)`
application-templates-general-petition	`23.13% <ø> (ø)`
application-templates-inheritance-report	`6.54% <ø> (ø)`
application-templates-marriage-conditions	`15.11% <ø> (ø)`
application-templates-mortgage-certificate	`43.79% <ø> (ø)`
application-templates-parental-leave	`29.95% <ø> (-0.10%)`	⬇️
application-types	`6.51% <ø> (ø)`
application-ui-components	`1.24% <ø> (ø)`
application-ui-shell	`22.48% <ø> (ø)`
auth-admin-web	`2.43% <ø> (ø)`
auth-nest-tools	`31.76% <ø> (ø)`
auth-react	`24.50% <ø> (ø)`
auth-shared	`75.00% <ø> (ø)`
clients-charge-fjs-v2	`28.35% <ø> (ø)`
clients-driving-license	`40.87% <ø> (ø)`
clients-driving-license-book	`43.90% <ø> (ø)`
clients-financial-statements-inao	`49.70% <ø> (ø)`
clients-license-client	`1.26% <ø> (ø)`
clients-middlewares	`73.39% <ø> (-0.25%)`	⬇️
clients-regulations	`42.97% <ø> (ø)`
clients-rsk-company-registry	`31.14% <ø> (ø)`
clients-rsk-personal-tax-return	`39.02% <ø> (ø)`
clients-smartsolutions	`12.77% <ø> (ø)`
clients-syslumenn	`49.47% <ø> (ø)`
clients-zendesk	`50.82% <ø> (ø)`
cms	`0.40% <ø> (ø)`
cms-translations	`38.81% <ø> (ø)`
content-search-index-manager	`95.65% <ø> (ø)`
content-search-toolkit	`8.20% <ø> (ø)`
contentful-apps	`4.73% <ø> (ø)`
dokobit-signing	`62.52% <ø> (ø)`
email-service	`60.43% <ø> (ø)`
feature-flags	`90.76% <ø> (ø)`
file-storage	`46.13% <ø> (ø)`
financial-aid-backend	`51.45% <ø> (ø)`
financial-aid-shared	`17.88% <ø> (ø)`
icelandic-names-registry-backend	`54.50% <ø> (ø)`
infra-nest-server	`48.30% <ø> (ø)`
infra-tracing	`70.58% <ø> (ø)`
island-ui-core	`30.94% <ø> (ø)`
judicial-system-api	`19.99% <ø> (ø)`
judicial-system-audit-trail	`68.94% <ø> (ø)`
judicial-system-backend	`55.77% <ø> (ø)`
judicial-system-formatters	`79.58% <ø> (ø)`
judicial-system-message	`66.72% <ø> (ø)`
judicial-system-message-handler	`48.30% <ø> (ø)`
judicial-system-scheduler	`70.88% <ø> (ø)`
judicial-system-types	`42.79% <ø> (ø)`
judicial-system-web	`27.96% <ø> (ø)`
license-api	`42.94% <ø> (-0.13%)`	⬇️
localization	`10.15% <ø> (ø)`
logging	`56.41% <ø> (ø)`
message-queue	`67.53% <ø> (-0.72%)`	⬇️
nest-audit	`66.84% <ø> (ø)`
nest-aws	`52.80% <ø> (ø)`
nest-config	`77.03% <ø> (ø)`
nest-core	`53.16% <ø> (ø)`
nest-feature-flags	`51.19% <ø> (ø)`
nest-problem	`45.82% <ø> (ø)`
nest-sequelize	`94.44% <ø> (ø)`
nest-swagger	`51.63% <ø> (ø)`
nova-sms	`61.87% <ø> (ø)`
portals-admin-regulations-admin	`1.80% <ø> (ø)`
portals-core	`19.80% <ø> (ø)`
regulations	`16.78% <ø> (ø)`
residence-history	`85.00% <ø> (ø)`
services-auth-admin-api	`52.63% <ø> (+0.05%)`	⬆️
services-auth-delegation-api	`58.62% <ø> (+0.15%)`	⬆️
services-auth-ids-api	`52.39% <ø> (-0.17%)`	⬇️
services-auth-public-api	`49.37% <ø> (-0.06%)`	⬇️
services-sessions	`65.46% <ø> (ø)`
services-university-gateway	`49.59% <ø> (-0.09%)`	⬇️
services-user-notification	`46.63% <ø> (ø)`
services-user-profile	`57.03% <ø> (ø)`
shared-components	`30.22% <ø> (ø)`
shared-form-fields	`33.88% <ø> (ø)`
shared-mocking	`58.64% <ø> (ø)`
shared-pii	`92.85% <ø> (ø)`
shared-problem	`87.50% <ø> (ø)`
shared-utils	`27.69% <ø> (ø)`
skilavottord-ws	`24.35% <ø> (ø)`
web	`2.43% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa8f6ba...f71256f. Read the comment docs.

datadog-island-is · 2024-12-05T15:22:52Z

Datadog Report

All test runs 55cf6ee 🔗

✅ 99 Total Test Services: 0 Failed, 91 Passed
🔻 Test Sessions change in coverage: 5 decreased, 18 increased, 176 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-backend`	63	28.49s	N/A	Link
`air-discount-scheme-web`	2	7.92s	N/A	Link
`api`	4	3.44s	N/A	Link
`api-catalogue-services`	23	14.29s	N/A	Link
`api-domains-air-discount-scheme`	6	20.21s	N/A	Link
`api-domains-assets`	3	12.78s	N/A	Link
`api-domains-auth-admin`	18	14.42s	N/A	Link
`api-domains-communications`	5	42.29s	N/A	Link
`api-domains-criminal-record`	5	11.59s	1 increased (+0.04%)	Link
`services-auth-delegation-api`	270	3m 8.06s	1 increased (+0.07%)	Link

🔻 Code Coverage Decreases vs Default Branch (5)

message-queue - jest 68.01% (-0.8%) - Details
clients-middlewares - jest 76.01% (-0.1%) - Details
services-auth-ids-api - jest 45.58% (-0.09%) - Details
services-auth-public-api - jest 45.12% (-0.04%) - Details
license-api - jest 34.12% (-0.01%) - Details

hebaulf added 9 commits November 28, 2024 10:32

Update and validate landlord info inputs.

c5c4ca9

NationalId validation update

015cbc5

Landlord info schema update

2f62c8c

Merge from main and fix conflicts

b4b7d08

Remove code snippet giving an error

f528af0

Merge from rental-agreement-application and fix conflict

4ccff6f

Update landlord details rendering of name and nationalId

b4518f8

Update validation for landlord and tenant information.

bb81274

Merge from rental-agreement-application and fix conflicts

f71256f

hebaulf requested a review from a team as a code owner December 5, 2024 14:42

hebaulf requested a review from addi December 5, 2024 14:42

addi approved these changes Dec 6, 2024

View reviewed changes

hebaulf merged commit 893357e into rental-agreement-application Dec 6, 2024
277 checks passed

hebaulf deleted the feat/nationalid-withname-lookup branch December 6, 2024 10:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rental-agreement): NationalIdWithName in repeatableTableField #17147

feat(rental-agreement): NationalIdWithName in repeatableTableField #17147

hebaulf commented Dec 5, 2024

coderabbitai bot commented Dec 5, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 5, 2024 •

edited

Loading

datadog-island-is bot commented Dec 5, 2024

feat(rental-agreement): NationalIdWithName in repeatableTableField #17147

feat(rental-agreement): NationalIdWithName in repeatableTableField #17147

Conversation

hebaulf commented Dec 5, 2024

...

What

Why

Screenshots / Gifs

Checklist:

coderabbitai bot commented Dec 5, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Dec 5, 2024 • edited Loading

Codecov Report

datadog-island-is bot commented Dec 5, 2024

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (5)

codecov bot commented Dec 5, 2024 •

edited

Loading