feat(web): Add namespace for 'samgongustofa' web chat config #17123
Conversation
WalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
warning [email protected]: This version is no longer supported. Please see https://eslint.org/version-support for other options. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportBranch report: ✅ 0 Failed, 84 Passed, 0 Skipped, 34.28s Total Time |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
apps/web/screens/Article/components/ArticleChatPanel/config.ts (1)
Based on the search results, I can now generate the final response as we have found clear evidence of inconsistent namespace usage across Samgöngustofa-related services.
Namespace inconsistency found in Samgöngustofa services
Several services are using the same integration IDs ('b0b445a4-4c49-4c79-9731-8d03f49c8cac' and 'ee1c15db-7151-4487-bc9a-9f32f1f8ae3b') but with different namespace configurations:
Services using 'default' namespace:
- 'Uppfletting í ökutækjaskrá' (Vehicle registry lookup)
- 'Skrá eigendaskipti' (Register ownership transfer)
- 'Skutan skipaskrá og logskráning' (Ship registry and logging)
Services already using 'samgongustofa' namespace:
- Samgöngustofa Organization configurations in both ArticleChatPanel and Organization Wrapper
- ServiceWeb configurations
For consistency and proper service isolation, all related services should use the 'samgongustofa' namespace.
🔗 Analysis chain
Line range hint
304-324: Consider updating related services to use the new namespace.Services related to Samgöngustofa (e.g., 'Uppfletting í ökutækjaskrá') are still using the 'default' namespace. Consider whether these services should also use the 'samgongustofa' namespace for consistency.
Let's verify other services that might be related to Samgöngustofa:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Find all configurations that might be related to Samgöngustofa # by searching for their integration IDs # Search for configurations using the same integration IDs as Samgöngustofa echo "Configurations using Samgöngustofa's integration IDs:" rg "integrationID: ['\"](?:ee1c15db-7151-4487-bc9a-9f32f1f8ae3b|b0b445a4-4c49-4c79-9731-8d03f49c8cac)['\"]" -A 10Length of output: 10134
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (4)
apps/web/components/ChatPanel/types.ts(1 hunks)apps/web/components/Organization/Wrapper/config.ts(2 hunks)apps/web/components/ServiceWeb/config.ts(2 hunks)apps/web/screens/Article/components/ArticleChatPanel/config.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
apps/web/components/ServiceWeb/config.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/components/Organization/Wrapper/config.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/screens/Article/components/ArticleChatPanel/config.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/web/components/ChatPanel/types.ts (1)
Pattern apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
🔇 Additional comments (4)
apps/web/components/ChatPanel/types.ts (1)
27-31: LGTM! Type definition updated correctly for the new namespace.
The addition of 'samgongustofa' to the namespaceKey union type is consistent with the PR objectives and maintains type safety.
apps/web/components/ServiceWeb/config.ts (1)
116-116: LGTM! Configuration updated consistently for both languages.
The namespaceKey has been correctly updated to 'samgongustofa' for both Icelandic and English configurations of the Transport Authority.
Also applies to: 150-150
apps/web/components/Organization/Wrapper/config.ts (1)
119-119: LGTM! Configuration updated consistently for Samgöngustofa organization.
The namespaceKey has been correctly updated to 'samgongustofa' for both language configurations.
Let's verify the consistency of the namespace across all configuration files:
Also applies to: 130-130
✅ Verification successful
Configuration verified: 'samgongustofa' namespace is consistently used across components
The namespace 'samgongustofa' is correctly and consistently implemented across all relevant configuration files and components:
- Configuration files (ServiceWeb/config.ts and Organization/Wrapper/config.ts) use it as namespaceKey
- Component files use it for conditional rendering (Background.tsx and OrganizationWrapper.tsx)
- It's properly typed in the system (ChatPanel/types.ts)
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Verify that all Samgöngustofa/Transport Authority configurations use the new namespace
rg -l "'samgongustofa'" apps/web/components/
Length of output: 305
Script:
#!/bin/bash
# Let's check the actual usage context of 'samgongustofa' in these files
rg "'samgongustofa'" apps/web/components/ -C 2
Length of output: 3552
apps/web/screens/Article/components/ArticleChatPanel/config.ts (1)
290-290: LGTM! Namespace changes for Samgöngustofa organization.
The namespace changes from 'default' to 'samgongustofa' are consistent across both English and Icelandic configurations.
Also applies to: 301-301
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17123 +/- ##
=======================================
Coverage 35.72% 35.72%
=======================================
Files 6920 6920
Lines 147498 147473 -25
Branches 42001 41983 -18
=======================================
- Hits 52688 52685 -3
+ Misses 94810 94788 -22
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kodiakhq
bot
deleted the
feature/web-transport-authority-chat-settings
branch
Add namespace for 'samgongustofa' web chat config
What
So we can in the CMS edit properties for the transport authority (Samgöngustofa) web chat
Why
Checklist:
Summary by CodeRabbit
namespaceKeyin the Watson Chat Panel to include'samgongustofa'.namespaceKeyfor theSamgöngustofaorganization in multiple configurations to reflect the new value.namespaceKeyfor theTRANSPORT_AUTHORITYorganization to align with the new naming convention.