feat(form-system) Updated form builder to work with the new backend #17074

Hyosam · 2024-11-28T13:40:39Z

What

The project under libs/portals/admin/form-system has been updated to work with the new backend.
Additionally, there is an initial "Hello world"-level project for the application side of form-system under libs/portals/form-system
Finally there are two libraries which are designed to be used by both aforementioned projects

Checklist:

[x ] I have performed a self-review of my own code
I have made corresponding changes to the documentation
[x ] My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
[x ] Formatting passes locally with my changes
[x ] I have rebased against main before asking for a review

…rm-builder

…into form-builder

…cript, removed all console.logs and removed all code that was commented out

…into form-builder

…n + script to generate graphql schemas

…ation

…is/island.is into form-system

…gen to work

…rm-system

… components

…rm-system-new-client-domain

coderabbitai · 2024-11-28T13:40:52Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

211 files out of 299 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…rm-system-new-client-domain

…land-is/island.is into form-system-new-client-domain

gitguardian · 2024-12-10T11:01:24Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
-	-	X-API-Key Secret	`fc7f69d`	apps/form-builder/services/translationStation.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

codecov · 2024-12-10T11:25:28Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.73%. Comparing base (b7c9767) to head (d1d30ed).
Report is 19 commits behind head on main.

Files with missing lines	Patch %	Lines
...system/api/src/app/modules/file/file.controller.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17074      +/-   ##
==========================================
- Coverage   35.73%   35.73%   -0.01%     
==========================================
  Files        6941     6941              
  Lines      148401   148399       -2     
  Branches    42334    42332       -2     
==========================================
- Hits        53037    53036       -1     
+ Misses      95364    95363       -1

Flag	Coverage Δ
air-discount-scheme-backend	`48.20% <ø> (ø)`
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.33% <ø> (ø)`
api-catalogue-services	`75.81% <ø> (ø)`
api-domains-air-discount-scheme	`37.90% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`48.49% <ø> (ø)`
api-domains-communications	`39.41% <ø> (ø)`
api-domains-criminal-record	`47.92% <ø> (ø)`
api-domains-driving-license	`44.81% <ø> (ø)`
api-domains-education	`31.17% <ø> (ø)`
api-domains-health-insurance	`35.33% <ø> (ø)`
api-domains-mortgage-certificate	`35.16% <ø> (ø)`
api-domains-payment-schedule	`42.04% <ø> (ø)`
application-api-files	`61.87% <ø> (ø)`
application-core	`75.78% <ø> (ø)`
application-system-api	`38.73% <ø> (-0.01%)`	⬇️
application-template-api-modules	`27.82% <ø> (ø)`
application-templates-accident-notification	`28.82% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.77% <ø> (ø)`
application-templates-driving-license	`18.16% <ø> (ø)`
application-templates-estate	`13.76% <ø> (ø)`
application-templates-example-payment	`24.72% <ø> (ø)`
application-templates-financial-aid	`14.46% <ø> (ø)`
application-templates-general-petition	`23.15% <ø> (ø)`
application-templates-inheritance-report	`6.59% <ø> (ø)`
application-templates-marriage-conditions	`15.19% <ø> (ø)`
application-templates-mortgage-certificate	`43.64% <ø> (ø)`
application-templates-parental-leave	`29.94% <ø> (ø)`
application-types	`6.51% <ø> (ø)`
application-ui-components	`1.22% <ø> (ø)`
application-ui-shell	`22.48% <ø> (ø)`
auth-admin-web	`2.43% <ø> (ø)`
auth-nest-tools	`31.52% <ø> (ø)`
auth-shared	`75.00% <ø> (ø)`
clients-charge-fjs-v2	`28.35% <ø> (ø)`
clients-driving-license	`40.79% <ø> (ø)`
clients-driving-license-book	`43.83% <ø> (ø)`
clients-financial-statements-inao	`49.59% <ø> (ø)`
clients-license-client	`1.26% <ø> (ø)`
clients-middlewares	`72.89% <ø> (-0.25%)`	⬇️
clients-regulations	`42.87% <ø> (ø)`
clients-rsk-company-registry	`31.04% <ø> (ø)`
clients-rsk-personal-tax-return	`38.32% <ø> (ø)`
clients-smartsolutions	`12.77% <ø> (ø)`
clients-syslumenn	`49.41% <ø> (ø)`
clients-zendesk	`50.46% <ø> (ø)`
cms	`0.39% <ø> (ø)`
cms-translations	`38.74% <ø> (ø)`
content-search-index-manager	`95.65% <ø> (ø)`
content-search-toolkit	`8.16% <ø> (ø)`
contentful-apps	`4.72% <ø> (ø)`
dokobit-signing	`62.10% <ø> (ø)`
email-service	`60.07% <ø> (ø)`
feature-flags	`90.76% <ø> (ø)`
file-storage	`45.86% <ø> (ø)`
icelandic-names-registry-backend	`54.33% <ø> (ø)`
infra-nest-server	`48.06% <ø> (ø)`
infra-tracing	`69.63% <ø> (ø)`
island-ui-core	`30.92% <ø> (ø)`
judicial-system-api	`20.21% <0.00%> (ø)`
judicial-system-audit-trail	`68.94% <ø> (ø)`
judicial-system-formatters	`78.47% <ø> (ø)`
judicial-system-message	`66.48% <ø> (ø)`
judicial-system-message-handler	`48.16% <ø> (ø)`
judicial-system-scheduler	`71.08% <ø> (ø)`
judicial-system-types	`41.66% <ø> (ø)`
judicial-system-web	`27.88% <ø> (ø)`
license-api	`42.91% <ø> (-0.06%)`	⬇️
localization	`10.15% <ø> (ø)`
logging	`58.02% <ø> (ø)`
message-queue	`67.76% <ø> (ø)`
nest-audit	`65.78% <ø> (ø)`
nest-aws	`51.93% <ø> (ø)`
nest-config	`76.38% <ø> (ø)`
nest-core	`53.16% <ø> (ø)`
nest-feature-flags	`51.00% <ø> (ø)`
nest-problem	`45.64% <ø> (ø)`
nest-sequelize	`94.44% <ø> (ø)`
nest-swagger	`51.13% <ø> (ø)`
nova-sms	`61.42% <ø> (ø)`
portals-admin-regulations-admin	`1.80% <ø> (ø)`
portals-core	`19.83% <ø> (ø)`
regulations	`16.78% <ø> (ø)`
residence-history	`85.00% <ø> (ø)`
services-auth-admin-api	`52.55% <ø> (ø)`
services-auth-delegation-api	`58.44% <ø> (-0.09%)`	⬇️
services-auth-ids-api	`52.55% <ø> (ø)`
services-auth-public-api	`49.40% <ø> (ø)`
services-sessions	`65.35% <ø> (ø)`
services-university-gateway	`49.42% <ø> (-0.06%)`	⬇️
services-user-notification	`46.54% <ø> (ø)`
services-user-profile	`56.94% <ø> (ø)`
shared-components	`30.06% <ø> (ø)`
shared-form-fields	`33.88% <ø> (ø)`
shared-mocking	`58.64% <ø> (ø)`
shared-pii	`92.85% <ø> (ø)`
shared-problem	`87.50% <ø> (ø)`
shared-utils	`27.69% <ø> (ø)`
skilavottord-ws	`24.26% <ø> (ø)`
web	`2.41% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...c/app/modules/file/limitedAccessFile.controller.ts	`0.00% <ø> (ø)`
...system/backend/src/app/modules/case/pdf.service.ts	`67.40% <ø> (+0.49%)`	⬆️
...dules/subpoena/limitedAccessSubpoena.controller.ts	`100.00% <ø> (ø)`
...nd/src/app/modules/subpoena/subpoena.controller.ts	`86.66% <ø> (-0.29%)`	⬇️
...system/api/src/app/modules/file/file.controller.ts	`0.00% <0.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c9767...d1d30ed. Read the comment docs.

datadog-island-is · 2024-12-10T11:44:21Z

Datadog Report

All test runs c85383e 🔗

✅ 98 Total Test Services: 0 Failed, 90 Passed
🔻 Test Sessions change in coverage: 3 decreased, 194 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-backend`	63	26.19s	N/A	Link
`air-discount-scheme-web`	2	8.18s	N/A	Link
`api`	4	3.29s	N/A	Link
`api-catalogue-services`	23	12.18s	N/A	Link
`api-domains-air-discount-scheme`	6	16.46s	N/A	Link
`api-domains-assets`	3	9.78s	N/A	Link
`api-domains-auth-admin`	18	10.52s	N/A	Link
`api-domains-communications`	5	34.1s	N/A	Link
`api-domains-criminal-record`	5	9.84s	N/A	Link
`api-domains-driving-license`	23	31.18s	N/A	Link

🔻 Code Coverage Decreases vs Default Branch (3)

clients-middlewares - jest 75.6% (-0.1%) - Details
services-auth-delegation-api - jest 50.43% (-0.04%) - Details
services-university-gateway - jest 45.23% (-0.02%) - Details

…rm-system-new-client-domain

Hyosam and others added 30 commits February 1, 2024 15:46

form builder 'init'

167a4ca

Added functionality for relevant parties

4615d90

Merge branch 'main' of https://github.com/island-is/island.is into fo…

958e21b

…rm-builder

redirect to the correct url when creating a new form

f795053

removed secret from comment

fc7f69d

chore: nx format:write update dirty files

f8818bd

Property number component

e1f667b

Fixed the header

74464ff

Merge branch 'form-builder' of https://github.com/island-is/island.is …

6f8159e

…into form-builder

Reverted to next 13.3.0

d7b708d

Deleted the e2e project, updated to project to adhere to strict types…

9666db4

…cript, removed all console.logs and removed all code that was commented out

chore: nx format:write update dirty files

ba301da

Started implementing zod validation

ffe2b07

Merge branch 'form-builder' of https://github.com/island-is/island.is …

1a988c7

…into form-builder

chore: nx format:write update dirty files

5f7f8f9

Generated a nestjs client from our openapi schema

287bea8

Generated a client and created a domain client for graphql

e9b22be

Update Form, Group, Input, and Step DTOs

3ae8a54

Refactor input settings in FormsService and Input model

32b2884

Update API and authentication configurations

0bf07a0

Added form-system client and module to the app/api and added a codege…

c317d03

…n + script to generate graphql schemas

Remove form-system module and add formSystemNavigation to masterNavig…

0703fd8

…ation

Merge branches 'form-system' and 'main' of https://github.com/island-…

1593e6a

…is/island.is into form-system

Refactor form-system API code and formBuilder into portals/admin

2387fc7

Fixng typing erros in form system graphql domain

323ad38

Added another Object type and a bunch of inputTypes in order for code…

61a8469

…gen to work

Update import statements for LanguageTypeInput

8a5e637

Merge branch 'main' of https://github.com/island-is/island.is into fo…

fd12938

…rm-system

Update form system module and related files

59ca682

Merge branch 'main' of https://github.com/island-is/island.is into fo…

4a54d78

…rm-system

Hyosam added 4 commits November 26, 2024 12:06

refactor: remove unnecessary comments and console logs across various…

7b27d73

… components

Merge branch 'main' of https://github.com/island-is/island.is into fo…

e27b1ad

…rm-system-new-client-domain

Merge branch 'main' of https://github.com/island-is/island.is into fo…

648b8cc

…rm-system-new-client-domain

Merge branch 'main' of https://github.com/island-is/island.is into fo…

f92cb63

…rm-system-new-client-domain

Hyosam requested review from a team as code owners November 28, 2024 13:40

Merge branch 'main' of https://github.com/island-is/island.is into fo…

d4ee05f

…rm-system-new-client-domain

Hyosam assigned Hyosam and unassigned Hyosam Dec 6, 2024

Hyosam and others added 6 commits December 9, 2024 11:32

about to pull main

8ee99a6

Merge branch 'main' of https://github.com/island-is/island.is into fo…

b9b9fa8

…rm-system-new-client-domain

Fixed forms resolver

c87dc50

Merge branch 'main' of https://github.com/island-is/island.is into HEAD

4ea7123

Merge branch 'main' of https://github.com/island-is/island.is into fo…

4cb26c4

…rm-system-new-client-domain

Merge branch 'form-system-new-client-domain' of https://github.com/is…

2d1c195

…land-is/island.is into form-system-new-client-domain

chore: charts update dirty files

f8dad9e

Hyosam added 2 commits December 10, 2024 13:14

Merge branch 'main' of https://github.com/island-is/island.is into fo…

c3084ed

…rm-system-new-client-domain

Linting and debugging

180e689

Hyosam requested a review from a team as a code owner December 17, 2024 11:06

Hyosam added 2 commits December 17, 2024 11:09

Merge branch 'main' into form-system-new-client-domain

1b6b859

merge confict fix

d1d30ed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(form-system) Updated form builder to work with the new backend #17074

feat(form-system) Updated form builder to work with the new backend #17074

Hyosam commented Nov 28, 2024

coderabbitai bot commented Nov 28, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

gitguardian bot commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading

datadog-island-is bot commented Dec 10, 2024 •

edited

Loading

feat(form-system) Updated form builder to work with the new backend #17074

Are you sure you want to change the base?

feat(form-system) Updated form builder to work with the new backend #17074

Conversation

Hyosam commented Nov 28, 2024

What

Checklist:

coderabbitai bot commented Nov 28, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

gitguardian bot commented Dec 10, 2024 • edited Loading

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

codecov bot commented Dec 10, 2024 • edited Loading

Codecov Report

datadog-island-is bot commented Dec 10, 2024 • edited Loading

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (3)

coderabbitai bot commented Nov 28, 2024 •

edited

Loading

gitguardian bot commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 10, 2024 •

edited

Loading

datadog-island-is bot commented Dec 10, 2024 •

edited

Loading