revert: ⚠️ fix: allow empty envs in helm values

[busla]

Reverts PR #17056

Summary by CodeRabbit

• New Features

  • Introduced new environment variables for various services to enhance configuration and connectivity.
  • Added SI_PUBLIC_GRAPHQL_PATH to the application-system-form service.

• Bug Fixes

  • Removed unused environment variables like HIDDEN_FEATURES and BLOCKED_API_INTEGRATION from multiple services to streamline configurations.

• Resource Management

  • Updated resource limits and requests for several services to improve performance and scalability.

• Health Checks

  • Standardized health check paths and parameters across multiple services for better monitoring.

• HPA Settings

  • Adjusted Horizontal Pod Autoscaler configurations for improved scaling metrics and replica counts.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request involve extensive modifications to the configuration files across various services, focusing on environment variables, health checks, resource limits, and Horizontal Pod Autoscaler (HPA) settings. Key updates include the removal of specific environment variables, adjustments to health check paths, and refinements to resource management across multiple services. Additionally, new environment variables have been introduced, and existing ones have been modified to enhance service connectivity and operational capabilities.

Changes

File Path	Change Summary
charts/islandis/values.dev.yaml	Added environment variables, modified health check paths, updated resource limits and requests for several services, removed SI_PUBLIC_GRAPHQL_PATH from application-system-form.
charts/islandis/values.prod.yaml	Added/modified environment variables, standardized health checks, refined resource limits, updated HPA settings, and modified service account annotations.
charts/islandis/values.staging.yaml	Added/modified environment variables, standardized health checks, updated HPA settings, and adjusted resource limits.
charts/judicial-system/values.dev.yaml	Removed HIDDEN_FEATURES and BLOCKED_API_INTEGRATION, adjusted nginxRequestsIrate, modified replicaCount, updated health check paths, and increased resource limits.
charts/judicial-system/values.prod.yaml	Removed HIDDEN_FEATURES and BLOCKED_API_INTEGRATION, adjusted replicaCount, added SQS environment variables, updated health check paths, and increased resource limits.
charts/judicial-system/values.staging.yaml	Removed HIDDEN_FEATURES, added SQS environment variables, updated HPA metrics, standardized replicaCount, modified health check paths, and increased resource limits.
charts/services/api/values.prod.yaml	Removed FORM_SYSTEM_API_BASE_PATH.
charts/services/api/values.staging.yaml	Removed FORM_SYSTEM_API_BASE_PATH.
charts/services/application-system-form/values.dev.yaml	Added SI_PUBLIC_GRAPHQL_PATH with an empty string.
charts/services/application-system-form/values.prod.yaml	Removed SI_PUBLIC_GRAPHQL_PATH.
charts/services/application-system-form/values.staging.yaml	Removed SI_PUBLIC_GRAPHQL_PATH.
charts/services/judicial-system-api/values.dev.yaml	Removed HIDDEN_FEATURES.
charts/services/judicial-system-api/values.prod.yaml	Removed HIDDEN_FEATURES.
charts/services/judicial-system-api/values.staging.yaml	Removed HIDDEN_FEATURES.
charts/services/judicial-system-backend/values.dev.yaml	Removed BLOCKED_API_INTEGRATION.
charts/services/judicial-system-backend/values.prod.yaml	Removed BLOCKED_API_INTEGRATION.
infra/src/cli/generate-chart-values.ts	Introduced NON_EMPTYABLE_PROPERTIES, added removeEmptyStringProperties function, modified writeYamlFile to filter content.
infra/src/dsl/output-generators/map-to-helm-values.ts	Updated serializeService to always include port in healthCheck and image in ContainerRunHelm, simplifying logic.

Possibly related PRs

• Revert "chore: Change scaling nginx rate of increase metric for IDS" #15267: Updates to values.dev.yaml including health check paths and resource limits, related to modifications in values.prod.yaml.
• fix(application-system-api): add secret from aws parameter store for national registry client v3 #16782: Addition of NATIONAL_REGISTRY_B2C_CLIENT_SECRET in application-system-api, enhancing security configurations.
• fix: allow empty envs in helm values #17056: Introduction of SI_PUBLIC_GRAPHQL_PATH in application-system-form, related to environment variable handling.
• chore(ci): revert: Use DOCKER_REGISTRY, and compat" #17057: Changes regarding environment variables and resource limits relevant to Dockerfile adjustments.

Suggested labels

automerge, high priority

Suggested reviewers

• peturgq
• lodmfjord

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.