fix(j-s): Enable send to prison admin if service not required

[unakb]

Ríksak - ekki er hægt að senda til fullnustu ef ekki þurfti að birta dóminn

What

Allow indictment to be sent to prison admin if it doesn't require servicing

Why

Because it should be allowed

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features
  • Enhanced logic for enabling the "Send to Prison Admin" button, now requiring the defendant's service status along with existing conditions.
• Bug Fixes
  • Ensured the button functions correctly with the updated enabling conditions without introducing errors.

[coderabbitai]

Walkthrough

The changes in this pull request modify the logic for enabling the "Send to Prison Admin" button within the BlueBoxWithDate component. The enabling condition now requires the presence of an indictmentReviewDecision, a verdictViewDate, and a check for the serviceRequired status of the defendant. The overall structure and functionality of the component remain unchanged, ensuring that existing behaviors and state management are preserved.

Changes

File Path	Change Summary
apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx	Updated the logic for enabling the "Send to Prison Admin" button to include a check for serviceRequired status.

Possibly related PRs

• fix(j-s): Disable ServiceRequirement rather then hiding it when sent to public prosecutor #15850: This PR modifies the logic for enabling the "Send to Prison Admin" button by introducing a check for the serviceRequired status, which is directly related to the changes made in the main PR regarding the enabling conditions of the button.
• chore(j-s): Fixes to ServiceRequirement NOT_REQUIRED #16305: This PR addresses the handling of cases marked as "NOT_REQUIRED," which involves the serviceRequirement status, aligning with the changes in the main PR that also incorporate checks for the serviceRequired status.
• chore(j-s): Display service status on info card for prosecutors #16709: This PR enhances the information available regarding the service status of rulings, which is relevant to the changes in the main PR that involve the logic for enabling the button based on the service requirement status.

Suggested labels

automerge

Suggested reviewers

• oddsson

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (1)

351-351: LGTM! Consider adding a comment to explain the condition.

The logic correctly implements the PR objective by allowing indictments to be sent to prison admin when service is not required, while maintaining the requirement for verdictViewDate when service is required.

Consider adding a comment to explain the condition:

 disabled={
   !workingCase.indictmentReviewDecision ||
+  // Require verdictViewDate only when service is required
   (!isFine && !defendant.verdictViewDate && serviceRequired)
 }

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cac3c4e and d58e220.

📒 Files selected for processing (1)

• apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

📓 Learnings (1)

apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx (3)

Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:102-103
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In the TypeScript file `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx`, within the `handleSetDate` function, the else block is intentionally kept to handle an unlikely scenario and should not be removed, even if it appears unnecessary due to prior validation checks.

Learnt from: oddsson
PR: island-is/island.is#16495
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:84-105
Timestamp: 2024-11-12T15:15:11.835Z
Learning: In `apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx`, the `setAndSendDefendantToServer` function handles errors internally, so additional error handling when calling it is not necessary.

Learnt from: oddsson
PR: island-is/island.is#16831
File: apps/judicial-system/web/src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx:204-337
Timestamp: 2024-11-19T09:28:36.448Z
Learning: Buttons in this project are considered accessible as is, and adding additional ARIA attributes like `aria-label` and `aria-disabled` is not required unless specifically needed.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.68%. Comparing base (34a9064) to head (18f6118).
Report is 4 commits behind head on main.

Files with missing lines	Patch %	Lines
...src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17045      +/-   ##
==========================================
- Coverage   35.69%   35.68%   -0.01%     
==========================================
  Files        6939     6937       -2     
  Lines      147081   147063      -18     
  Branches    41832    41839       +7     
==========================================
- Hits        52495    52481      -14     
+ Misses      94586    94582       -4     

Flag	Coverage Δ
judicial-system-web	28.09% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...src/components/BlueBoxWithIcon/BlueBoxWithDate.tsx	60.25% <0.00%> (ø)

... and 15 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efa9f05...18f6118. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/service-not-required-send-p-admin
Commit report: 09e26c5
Test service: judicial-system-web

✅ 0 Failed, 335 Passed, 0 Skipped, 1m 15.2s Total Time
➡️ Test Sessions change in coverage: 1 no change