Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make form-system env var optional #17030

Closed
wants to merge 9 commits into from

Conversation

peturgq
Copy link
Member

@peturgq peturgq commented Nov 26, 2024

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

mannipje and others added 9 commits November 26, 2024 10:05
* fix(efs): taxfree value spouse percentage

* privateTransfer document section

* description - select estate

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…ld (#16871)

* feat: start of fieldsRepeaterField

* feat: Make a copy of table repeater and update naming

* feat: make sure to throw away answers when repeater item is moved.

* .

* feat: additional options for fieldsRepeater

* chore: remove console.log

* feat: handle edge case going back and forth

* chore: revert back changes to the example form

* feat: update storybook

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
causes loop when going back now that we have query in url

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* First draft

* Stop fetching organization page twice

* Handle if there is only a single child link

* Update apps/web/screens/Organization/OrganizationNews/OrganizationNewsArticle.tsx

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* Add errorHandler to backend endpoint

* Remove question mark

* Filter out invalid child links

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
* feat: start of display field

* feat: display field

* fix: revert changes to another template

* feat: simplify useEffect logic and undo example form changes

* chore: undo example form changes

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…able component (#17025)

* EntryListSearch component added

* Update query

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@peturgq peturgq requested review from a team as code owners November 26, 2024 15:50
Copy link
Contributor

coderabbitai bot commented Nov 26, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@peturgq peturgq closed this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 9.58904% with 330 lines in your changes missing coverage. Please review.

Project coverage is 35.55%. Comparing base (0e418d4) to head (e407ce5).
Report is 2 commits behind head on release/33.1.0.

Files with missing lines Patch % Lines
...lib/FieldsRepeaterFormField/FieldsRepeaterItem.tsx 2.10% 93 Missing ⚠️
...ieldsRepeaterFormField/FieldsRepeaterFormField.tsx 1.69% 58 Missing ⚠️
...pps/contentful-apps/components/EntryListSearch.tsx 0.00% 48 Missing ⚠️
.../screens/Organization/Standalone/ParentSubpage.tsx 0.00% 47 Missing ⚠️
...elds/src/lib/DisplayFormField/DisplayFormField.tsx 5.00% 19 Missing ⚠️
apps/web/pages/s/[...slugs]/index.tsx 0.00% 12 Missing ⚠️
.../src/lib/models/organizationParentSubpage.model.ts 52.38% 10 Missing ⚠️
apps/web/screens/Organization/SubPage.tsx 0.00% 8 Missing ⚠️
...ation/OrganizationNews/OrganizationNewsArticle.tsx 0.00% 6 Missing ⚠️
libs/application/core/src/lib/fieldBuilders.ts 25.00% 6 Missing ⚠️
... and 9 more
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/33.1.0   #17030      +/-   ##
==================================================
- Coverage           35.59%   35.55%   -0.05%     
==================================================
  Files                6924     6931       +7     
  Lines              146393   146661     +268     
  Branches            41569    41695     +126     
==================================================
+ Hits                52105    52139      +34     
- Misses              94288    94522     +234     
Flag Coverage Δ
air-discount-scheme-web 0.00% <ø> (ø)
api 3.34% <ø> (ø)
api-domains-auth-admin 48.49% <ø> (ø)
api-domains-communications 39.57% <51.21%> (+0.04%) ⬆️
application-api-files 62.11% <100.00%> (+0.13%) ⬆️
application-core 70.91% <50.00%> (-0.12%) ⬇️
application-system-api 38.74% <54.54%> (+0.02%) ⬆️
application-template-api-modules 27.79% <50.94%> (+0.06%) ⬆️
application-templates-accident-notification 28.97% <25.00%> (-0.02%) ⬇️
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.86% <25.00%> (-0.01%) ⬇️
application-templates-driving-license 18.18% <25.00%> (+0.03%) ⬆️
application-templates-estate 12.16% <25.00%> (+0.01%) ⬆️
application-templates-example-payment 24.80% <25.00%> (+<0.01%) ⬆️
application-templates-financial-aid 15.80% <25.00%> (+0.03%) ⬆️
application-templates-general-petition 23.09% <25.00%> (+0.01%) ⬆️
application-templates-inheritance-report 6.58% <16.66%> (+0.04%) ⬆️
application-templates-marriage-conditions 15.12% <25.00%> (+0.07%) ⬆️
application-templates-mortgage-certificate 43.27% <50.00%> (+0.04%) ⬆️
application-templates-parental-leave 29.93% <25.00%> (+0.10%) ⬆️
application-types 6.51% <0.00%> (-0.06%) ⬇️
application-ui-components 1.27% <ø> (ø)
application-ui-shell 20.17% <3.82%> (-0.38%) ⬇️
clients-charge-fjs-v2 24.11% <ø> (ø)
cms 0.40% <0.00%> (-0.01%) ⬇️
cms-translations 38.91% <51.21%> (+0.05%) ⬆️
contentful-apps 4.74% <0.00%> (+0.04%) ⬆️
judicial-system-api 20.01% <ø> (ø)
judicial-system-backend 55.58% <55.81%> (+<0.01%) ⬆️
services-user-notification 46.75% <55.81%> (+0.03%) ⬆️
web 1.73% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...GenericList/OrganizationSubPageGenericListItem.tsx 0.00% <ø> (ø)
libs/application/core/src/lib/messages.ts 100.00% <ø> (ø)
...ort/src/forms/sections/applicationTypeSelection.ts 0.00% <ø> (ø)
.../inheritance-report/src/forms/sections/deceased.ts 0.00% <ø> (ø)
...tes/inheritance-report/src/forms/sections/heirs.ts 0.00% <ø> (ø)
...n/templates/inheritance-report/src/lib/messages.ts 100.00% <ø> (ø)
libs/application/types/src/lib/Fields.ts 100.00% <100.00%> (ø)
...c/lib/TableRepeaterFormField/TableRepeaterItem.tsx 2.15% <ø> (ø)
.../ui-fields/src/lib/TableRepeaterFormField/utils.ts 15.38% <100.00%> (ø)
...tors/lists/GenericListEditor/GenericListEditor.tsx 0.00% <0.00%> (ø)
... and 18 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e418d4...e407ce5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants