fix(user-notifications): adds fulltNafn as fallback #17012

magnearun · 2024-11-25T14:03:16Z

What

Add fallback for birtNafn, use fulltNafn

Why

if birtNafn is empty use fulltNafn

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

Bug Fixes
- Improved handling of user name retrieval to ensure empty strings are returned when no valid name is available.
- Enhanced logic for returning company names to avoid potential null or undefined values.

coderabbitai · 2024-11-25T14:03:23Z

Walkthrough

The changes in this pull request primarily focus on the getName method of the NotificationsWorkerService class. The modifications involve replacing the nullish coalescing operator (??) with the logical OR operator (||) in return statements to improve how the service handles undefined values when retrieving names. This ensures that if the primary name fields are falsy, an empty string is returned instead.

Changes

File	Change Summary
`apps/services/user-notification/src/app/modules/notifications/notificationsWorker/notificationsWorker.service.ts`	Updated `getName` method to use `

Possibly related PRs

feat(auth-admin): Use birtNafn instead of fulltNafn #16684: This PR modifies the NotificationsWorkerService class by changing the method from getFullName to getName, which aligns with the changes made in the main PR that also updates the name retrieval logic.
fix(auth-admin): gracefully handle getting name error #16818: This PR enhances error handling in the getName method of the NotificationsWorkerService, which is directly related to the changes in the main PR that also involve modifications to the getName method.

Suggested labels

automerge

Suggested reviewers

rafnarnason

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-11-25T14:44:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.59%. Comparing base (a61c6fb) to head (5725b9e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17012      +/-   ##
==========================================
- Coverage   35.59%   35.59%   -0.01%     
==========================================
  Files        6924     6924              
  Lines      146386   146386              
  Branches    41564    41564              
==========================================
- Hits        52100    52099       -1     
- Misses      94286    94287       +1

Flag	Coverage Δ
api	`3.34% <ø> (ø)`
application-system-api	`38.71% <ø> (-0.02%)`	⬇️
application-template-api-modules	`27.72% <ø> (ø)`
web	`1.74% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...notificationsWorker/notificationsWorker.service.ts	`93.00% <100.00%> (ø)`

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a61c6fb...5725b9e. Read the comment docs.

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

datadog-island-is · 2024-11-25T14:52:01Z

Datadog Report

All test runs b404eb5 🔗

✅ 22 Total Test Services: 0 Failed, 21 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.39%), 92 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-web`	2	8.59s	1 no change	Link
`api`	4	2.34s	1 no change	Link
`application-api-files`	2	4.22s	1 no change	Link
`application-core`	97	14.76s	1 decreased (-0.39%)	Link
`application-system-api`	40	2m 0.93s	1 no change	Link
`application-template-api-modules`	116	2m 2.68s	1 no change	Link
`application-templates-accident-notification`	148	16.13s	1 no change	Link
`application-templates-criminal-record`	2	10.05s	1 no change	Link
`application-templates-driving-license`	13	15.29s	1 no change	Link
`application-templates-example-payment`	2	10.73s	1 no change	Link

🔻 Code Coverage Decreases vs Default Branch (1)

application-core - jest 78.14% (-0.39%) - Details

GunnlaugurG

LGTM

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

adds fulltNafn as fallback

7fe5d58

magnearun marked this pull request as ready for review November 25, 2024 14:03

magnearun requested review from a team as code owners November 25, 2024 14:03

coderabbitai bot approved these changes Nov 25, 2024

View reviewed changes

rafnarnason approved these changes Nov 25, 2024

View reviewed changes

magnearun added the automerge Merge this PR as soon as all checks pass label Nov 25, 2024

GunnlaugurG approved these changes Nov 25, 2024

View reviewed changes

magnearun and others added 2 commits November 25, 2024 15:36

Merge branch 'main' into fix/birtNafn-fallback

fec698d

Merge branch 'main' into fix/birtNafn-fallback

5725b9e

kodiakhq bot merged commit 49cd9ac into main Nov 25, 2024
37 checks passed

kodiakhq bot deleted the fix/birtNafn-fallback branch November 25, 2024 16:24

jonnigs pushed a commit that referenced this pull request Nov 26, 2024

fix(user-notifications): adds fulltNafn as fallback (#17012)

1d7a80e

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

This was referenced Nov 28, 2024

feat(application-system): Add notifications support to pruning #17029

Merged

fix(user-notifications): Run worker after bootstrap #17072

Merged

fix: add missing ns grant to api for bff #17105

Merged

This was referenced Dec 6, 2024

fix(ids-api): Use name field instead of fullname. #17164

Merged

feat(user-notification): Add getNotificationStatus endpoint #17187

Closed

feat(user-notification): Firebase Credentials Setup for Local Development #17199

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(user-notifications): adds fulltNafn as fallback #17012

fix(user-notifications): adds fulltNafn as fallback #17012

magnearun commented Nov 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 25, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Nov 25, 2024 •

edited

Loading

datadog-island-is bot commented Nov 25, 2024 •

edited

Loading

GunnlaugurG left a comment

fix(user-notifications): adds fulltNafn as fallback #17012

fix(user-notifications): adds fulltNafn as fallback #17012

Conversation

magnearun commented Nov 25, 2024 • edited by coderabbitai bot Loading

What

Why

Screenshots / Gifs

Checklist:

Summary by CodeRabbit

coderabbitai bot commented Nov 25, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Nov 25, 2024 • edited Loading

Codecov Report

datadog-island-is bot commented Nov 25, 2024 • edited Loading

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (1)

GunnlaugurG left a comment

Choose a reason for hiding this comment

magnearun commented Nov 25, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 25, 2024 •

edited

Loading

codecov bot commented Nov 25, 2024 •

edited

Loading

datadog-island-is bot commented Nov 25, 2024 •

edited

Loading