feat(rental-agreement): Summary #16911
Conversation
…sland.is into feat/rental-agreement-summary
…sland.is into feat/rental-agreement-summary
…sland.is into feat/rental-agreement-summary
…sland.is into feat/rental-agreement-summary
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rental-agreement-application #16911 +/- ##
================================================================
+ Coverage 36.45% 36.46% +0.01%
================================================================
Files 6904 6904
Lines 144753 144773 +20
Branches 41498 41512 +14
================================================================
+ Hits 52763 52786 +23
+ Misses 91990 91987 -3 Flags with carried forward coverage won't be shown. Click here to find out more. see 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 80 Total Test Services: 0 Failed, 78 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (3) |
…sland.is into feat/rental-agreement-summary
…sland.is into feat/rental-agreement-summary
| > | ||
| {tenantRepresentatives.map((tenantRep) => { | ||
| return ( | ||
| <Fragment key={crypto.randomUUID()}> |
There was a problem hiding this comment.
Don't do this. Use an index or something.
| > | ||
| {tenantListWithoutRepresentatives.map((tenant) => { | ||
| return ( | ||
| <Fragment key={crypto.randomUUID()}> |
| import { useLocale } from '@island.is/localization' | ||
| import { MessageDescriptor } from 'react-intl' | ||
|
|
||
| type TextVariants = |
There was a problem hiding this comment.
Can you not get this from somewhere?
| > | ||
| {landlordsWithoutRepresentatives.map((landlord) => { | ||
| return ( | ||
| <Fragment key={crypto.randomUUID()}> |
| )} | ||
| </GridRow> | ||
|
|
||
| {/* <Divider /> |
| > | ||
| {tenantsWithoutRepresentatives.map((tenant) => { | ||
| return ( | ||
| <Fragment key={crypto.randomUUID()}> |
Rental agreement summary
Asana project
What
Set up a summary of the rental agreement
Why
All contracting parties can view a summary of all information of the rental agreement.
Checklist: