Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Outbound link tracking in Plausible #16899

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

RunarVestmann
Copy link
Member

@RunarVestmann RunarVestmann commented Nov 15, 2024

Outbound link tracking in Plausible

What

  • Enable outbound link tracking

Why

  • To see how often a link is pressed

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

Summary by CodeRabbit

  • Bug Fixes
    • Updated the outbound link tracking script for improved analytics.

@RunarVestmann RunarVestmann added the automerge Merge this PR as soon as all checks pass label Nov 15, 2024
@RunarVestmann RunarVestmann requested review from a team as code owners November 15, 2024 13:01
Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

Walkthrough

The pull request involves a modification to the PLAUSIBLE_SCRIPT_SRC constant in the apps/web/constants/index.ts file. The value of this constant has been updated from 'https://plausible.io/js/plausible.js' to 'https://plausible.io/js/script.outbound-links.js'. No other changes were made to constants or logic in this file.

Changes

File Path Change Summary
apps/web/constants/index.ts Updated PLAUSIBLE_SCRIPT_SRC from 'https://plausible.io/js/plausible.js' to 'https://plausible.io/js/script.outbound-links.js'

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant WebApp
    participant Plausible

    User->>WebApp: Load page
    WebApp->>Plausible: Request script from 'https://plausible.io/js/script.outbound-links.js'
    Plausible-->>WebApp: Return script
    WebApp-->>User: Execute script
Loading

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@RunarVestmann RunarVestmann added the deploy-feature Deploys features to dev label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.34%. Comparing base (487c598) to head (789d451).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
apps/web/constants/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16899      +/-   ##
==========================================
- Coverage   36.46%   36.34%   -0.12%     
==========================================
  Files        6903     6897       -6     
  Lines      144580   144337     -243     
  Branches    41284    41207      -77     
==========================================
- Hits        52718    52466     -252     
- Misses      91862    91871       +9     
Flag Coverage Δ
api 3.34% <ø> (ø)
application-api-files 62.35% <ø> (ø)
application-core 71.06% <ø> (ø)
application-system-api 41.02% <ø> (ø)
application-template-api-modules 27.72% <ø> (ø)
application-templates-accident-notification 28.98% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 25.87% <ø> (ø)
application-templates-driving-license 18.14% <ø> (ø)
application-templates-estate 12.14% <ø> (ø)
application-templates-example-payment 24.80% <ø> (ø)
application-templates-financial-aid 15.48% <ø> (ø)
application-templates-general-petition 23.07% <ø> (ø)
application-templates-inheritance-report 6.52% <ø> (ø)
application-templates-marriage-conditions 15.04% <ø> (ø)
application-templates-mortgage-certificate 43.36% <ø> (ø)
application-templates-parental-leave 29.86% <ø> (ø)
application-ui-components 1.27% <ø> (ø)
application-ui-shell 20.83% <ø> (ø)
web 1.77% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/web/constants/index.ts 0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487c598...789d451. Read the comment docs.

Copy link
Contributor

Affected services are: web,
Feature deployment of your services will begin shortly. Your feature will be accessible here:
https://web-plausible-outbound-link-tracking-beta.dev01.devland.is/

Deployed services: web.
Excluded services: ``

@datadog-island-is
Copy link

datadog-island-is bot commented Nov 15, 2024

Datadog Report

All test runs fd864c5 🔗

18 Total Test Services: 0 Failed, 17 Passed
➡️ Test Sessions change in coverage: 86 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.16s 1 no change Link
application-api-files 0 0 0 2 0 5.8s 1 no change Link
application-core 0 0 0 97 0 20.4s 1 no change Link
application-system-api 0 0 0 112 2 3m 32.14s 1 no change Link
application-template-api-modules 0 0 0 116 0 2m 31.55s 1 no change Link
application-templates-accident-notification 0 0 0 148 0 22.08s 1 no change Link
application-templates-criminal-record 0 0 0 2 0 11.53s 1 no change Link
application-templates-driving-license 0 0 0 13 0 17.83s 1 no change Link
application-templates-example-payment 0 0 0 2 0 12.67s 1 no change Link
application-templates-financial-aid 0 0 0 11 0 16.63s 1 no change Link

@RunarVestmann RunarVestmann removed the deploy-feature Deploys features to dev label Nov 18, 2024
@kodiakhq kodiakhq bot merged commit 760b5fe into main Nov 18, 2024
75 checks passed
@kodiakhq kodiakhq bot deleted the feature/web-plausible-outbound-link-tracking branch November 18, 2024 14:33
jonnigs pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants