fix(datadog): disable rum #16876

busla · 2024-11-14T16:04:52Z

...

Attach a link to issue if relevant

What

Specify what you're trying to achieve

Why

Specify why you need to achieve this

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

Summary by CodeRabbit

Bug Fixes
- Disabled interaction tracking to enhance user privacy.
- Stopped data sampling for user monitoring, ensuring no user data is collected.
- Introduced new privacy settings to mask user data during monitoring.

coderabbitai · 2024-11-14T16:05:01Z

Walkthrough

The changes in this pull request modify the initDdRum function within the user-monitoring.ts file. The configuration parameters for the datadogRum.init method have been updated, specifically changing the trackInteractions parameter from true to false, disabling interaction tracking. New parameters trackResources and trackLongTasks have been added, both set to false, and a defaultPrivacyLevel with a value of 'mask' has been introduced. These modifications alter the data collection behavior of the user monitoring functionality.

Changes

File	Change Summary
libs/user-monitoring/src/lib/user-monitoring.ts	Modified `initDdRum` function to change `trackInteractions` to `false`, added `trackResources` and `trackLongTasks` set to `false`, and introduced `defaultPrivacyLevel` set to `'mask'`.

Possibly related PRs

ci: add datadog static analysis #15495: This PR involves changes related to Datadog, which is relevant to the modifications made in the initDdRum function in the main PR, as both deal with Datadog's functionality.
fix: disable global-auth on download-service (#16738) #16754: Although this PR focuses on disabling global authentication in a different service, it indicates a broader context of configuration changes that may relate to user monitoring and data handling practices, similar to the changes in the main PR.

Suggested labels

automerge

Suggested reviewers

AndesKrrrrrrrrrrr

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

robertaandersen

LGTM

codecov · 2024-11-14T16:15:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.45%. Comparing base (910627c) to head (0c84993).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16876   +/-   ##
=======================================
  Coverage   36.45%   36.45%           
=======================================
  Files        6903     6903           
  Lines      144598   144598           
  Branches    41288    41288           
=======================================
  Hits        52720    52720           
  Misses      91878    91878

Flag	Coverage Δ
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.34% <ø> (ø)`
application-api-files	`62.35% <ø> (ø)`
application-core	`71.06% <ø> (+0.31%)`	⬆️
application-system-api	`41.02% <ø> (ø)`
application-template-api-modules	`27.70% <ø> (-0.02%)`	⬇️
application-templates-accident-notification	`28.98% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.87% <ø> (ø)`
application-templates-driving-license	`18.14% <ø> (ø)`
application-templates-estate	`12.14% <ø> (ø)`
application-templates-example-payment	`24.80% <ø> (ø)`
application-templates-financial-aid	`15.48% <ø> (ø)`
application-templates-general-petition	`23.07% <ø> (ø)`
application-templates-inheritance-report	`6.52% <ø> (ø)`
application-templates-marriage-conditions	`15.04% <ø> (ø)`
application-templates-mortgage-certificate	`43.36% <ø> (ø)`
application-templates-parental-leave	`29.86% <ø> (ø)`
application-types	`6.60% <ø> (ø)`
application-ui-components	`1.27% <ø> (ø)`
application-ui-shell	`20.82% <ø> (ø)`
clients-charge-fjs-v2	`24.11% <ø> (ø)`
judicial-system-web	`27.16% <ø> (ø)`
services-endorsements-api	`53.21% <ø> (ø)`
web	`1.77% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910627c...0c84993. Read the comment docs.

---- 🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

datadog-island-is · 2024-11-14T16:16:42Z

Datadog Report

All test runs 867be2a 🔗

✅ 23 Total Test Services: 0 Failed, 22 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.2%), 95 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-web`	2	0	8.72s	1 no change	Link
`api`	4	0	3.18s	1 no change	Link
`application-api-files`	2	0	5.34s	1 no change	Link
`application-core`	97	0	20.9s	1 increased (+0.2%)	Link
`application-system-api`	112	2	3m 2.85s	1 no change	Link
`application-template-api-modules`	116	0	2m 32.42s	1 no change	Link
`application-templates-accident-notification`	148	0	19.22s	1 no change	Link
`application-templates-criminal-record`	2	0	11.42s	1 no change	Link
`application-templates-driving-license`	13	0	16.35s	1 no change	Link
`application-templates-example-payment`	2	0	11.6s	1 no change	Link

eirikurn

Approving with comment.

libs/user-monitoring/src/lib/user-monitoring.ts

… fix/disable-rum

* fix(datadog): disable rum * fix: mask all data * fix: only disable trackInteractions * fix: cleanup --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

fix(datadog): disable rum

4ebc8a7

busla requested a review from a team as a code owner November 14, 2024 16:04

robertaandersen approved these changes Nov 14, 2024

View reviewed changes

coderabbitai bot approved these changes Nov 14, 2024

View reviewed changes

fix: mask all data

f0c81dc

busla added the automerge Merge this PR as soon as all checks pass label Nov 14, 2024

busla requested a review from eirikurn November 14, 2024 17:04

eirikurn approved these changes Nov 15, 2024

View reviewed changes

libs/user-monitoring/src/lib/user-monitoring.ts Outdated Show resolved Hide resolved

Merge branch 'main' into fix/disable-rum

15bae03

busla removed the automerge Merge this PR as soon as all checks pass label Nov 19, 2024

busla added 3 commits November 19, 2024 10:26

fix: only disable trackInteractions

028e855

fix: cleanup

c532933

Merge branch 'fix/disable-rum' of github.com:island-is/island.is into…

4eb8460

… fix/disable-rum

busla added the automerge Merge this PR as soon as all checks pass label Nov 19, 2024

busla and others added 2 commits November 19, 2024 10:28

Merge branch 'main' into fix/disable-rum

57ad54b

Merge branch 'main' into fix/disable-rum

0c84993

kodiakhq bot merged commit 01c8d4d into main Nov 19, 2024
93 checks passed

kodiakhq bot deleted the fix/disable-rum branch November 19, 2024 10:46

This was referenced Jan 8, 2025

chore: Reduce sample rate for RUM sessions #17443

Merged

fix(dd): allowed tracing urls #17446

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(datadog): disable rum #16876

fix(datadog): disable rum #16876

busla commented Nov 14, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 14, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

robertaandersen left a comment

codecov bot commented Nov 14, 2024 •

edited

Loading

datadog-island-is bot commented Nov 14, 2024 •

edited

Loading

eirikurn left a comment

fix(datadog): disable rum #16876

fix(datadog): disable rum #16876

Conversation

busla commented Nov 14, 2024 • edited by coderabbitai bot Loading

...

What

Why

Screenshots / Gifs

Checklist:

Summary by CodeRabbit

coderabbitai bot commented Nov 14, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

robertaandersen left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 14, 2024 • edited Loading

Codecov Report

datadog-island-is bot commented Nov 14, 2024 • edited Loading

Datadog Report

eirikurn left a comment

Choose a reason for hiding this comment

busla commented Nov 14, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Nov 14, 2024 •

edited

Loading

codecov bot commented Nov 14, 2024 •

edited

Loading

datadog-island-is bot commented Nov 14, 2024 •

edited

Loading