feat(rental-agreement): security deposit fixes #16819

addi · 2024-11-12T12:51:21Z

https://app.asana.com/0/1208271027457465/1208501204323908

Checklist:

I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
Formatting passes locally with my changes
I have rebased against main before asking for a review

coderabbitai · 2024-11-12T12:51:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…and-is/island.is into rental-agreement-application-security-deposit-fix

codecov · 2024-11-12T13:06:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.53%. Comparing base (de9c16e) to head (fb1cf40).
Report is 15 commits behind head on rental-agreement-application.

Additional details and impacted files

@@                       Coverage Diff                        @@
##           rental-agreement-application   #16819      +/-   ##
================================================================
+ Coverage                         36.52%   36.53%   +0.01%     
================================================================
  Files                              6892     6892              
  Lines                            143891   143900       +9     
  Branches                          41098    41160      +62     
================================================================
+ Hits                              52553    52581      +28     
+ Misses                            91338    91319      -19

Flag	Coverage Δ
air-discount-scheme-backend	`54.06% <ø> (ø)`
air-discount-scheme-web	`0.00% <ø> (ø)`
api	`3.35% <ø> (ø)`
api-catalogue-services	`77.85% <ø> (ø)`
api-domains-air-discount-scheme	`37.02% <ø> (ø)`
api-domains-assets	`26.71% <ø> (ø)`
api-domains-auth-admin	`48.48% <ø> (ø)`
api-domains-communications	`39.60% <ø> (ø)`
api-domains-criminal-record	`47.48% <ø> (ø)`
api-domains-driving-license	`44.47% <ø> (ø)`
api-domains-education	`30.55% <ø> (ø)`
api-domains-health-insurance	`34.33% <ø> (ø)`
api-domains-mortgage-certificate	`34.68% <ø> (ø)`
api-domains-payment-schedule	`41.25% <ø> (ø)`
application-api-files	`56.38% <ø> (ø)`
application-core	`70.84% <ø> (-0.24%)`	⬇️
application-system-api	`41.08% <ø> (-0.01%)`	⬇️
application-template-api-modules	`27.59% <ø> (-0.03%)`	⬇️
application-templates-accident-notification	`28.98% <ø> (ø)`
application-templates-car-recycling	`3.12% <ø> (ø)`
application-templates-criminal-record	`25.87% <ø> (ø)`
application-templates-driving-license	`18.26% <ø> (ø)`
application-templates-estate	`12.17% <ø> (+<0.01%)`	⬆️
application-templates-example-payment	`24.80% <ø> (ø)`
application-templates-financial-aid	`15.48% <ø> (ø)`
application-templates-general-petition	`23.07% <ø> (ø)`
application-templates-inheritance-report	`6.52% <ø> (ø)`
application-templates-marriage-conditions	`15.04% <ø> (ø)`
application-templates-mortgage-certificate	`43.34% <ø> (ø)`
application-templates-parental-leave	`29.83% <ø> (-0.08%)`	⬇️
application-types	`6.54% <ø> (ø)`
application-ui-components	`1.27% <ø> (ø)`
application-ui-shell	`20.80% <ø> (-0.05%)`	⬇️
auth-admin-web	`2.43% <ø> (ø)`
auth-nest-tools	`30.20% <ø> (ø)`
auth-react	`21.92% <ø> (+0.02%)`	⬆️
auth-shared	`75.00% <ø> (ø)`
clients-charge-fjs-v2	`24.11% <ø> (ø)`
clients-driving-license	`40.20% <ø> (ø)`
clients-driving-license-book	`43.44% <ø> (ø)`
clients-financial-statements-inao	`48.98% <ø> (ø)`
clients-license-client	`1.26% <ø> (ø)`
clients-middlewares	`73.22% <ø> (+0.08%)`	⬆️
clients-regulations	`42.27% <ø> (ø)`
clients-rsk-company-registry	`29.76% <ø> (ø)`
clients-rsk-personal-tax-return	`38.00% <ø> (ø)`
clients-smartsolutions	`12.77% <ø> (ø)`
clients-syslumenn	`49.19% <ø> (ø)`
clients-zendesk	`50.37% <ø> (ø)`
cms	`0.42% <ø> (ø)`
cms-translations	`38.89% <ø> (ø)`
content-search-index-manager	`95.65% <ø> (ø)`
content-search-toolkit	`8.14% <ø> (ø)`
contentful-apps	`4.69% <ø> (ø)`
dokobit-signing	`62.58% <ø> (ø)`
download-service	`44.24% <ø> (ø)`
email-service	`60.41% <ø> (ø)`
feature-flags	`90.47% <ø> (ø)`
file-storage	`45.86% <ø> (ø)`
financial-aid-backend	`51.26% <ø> (ø)`
financial-aid-shared	`17.81% <ø> (ø)`
icelandic-names-registry-backend	`54.34% <ø> (ø)`
infra-nest-server	`48.37% <ø> (ø)`
infra-tracing	`43.24% <ø> (ø)`
island-ui-core	`28.94% <ø> (+0.15%)`	⬆️
judicial-system-api	`19.62% <ø> (ø)`
judicial-system-audit-trail	`68.70% <ø> (ø)`
judicial-system-backend	`55.18% <ø> (ø)`
judicial-system-formatters	`79.13% <ø> (-0.74%)`	⬇️
judicial-system-message	`66.86% <ø> (ø)`
judicial-system-message-handler	`47.81% <ø> (ø)`
judicial-system-scheduler	`70.47% <ø> (ø)`
judicial-system-types	`43.99% <ø> (-0.35%)`	⬇️
judicial-system-web	`27.54% <ø> (+0.08%)`	⬆️
license-api	`42.57% <ø> (+0.07%)`	⬆️
localization	`10.15% <ø> (ø)`
logging	`48.43% <ø> (ø)`
message-queue	`67.80% <ø> (-0.79%)`	⬇️
nest-audit	`68.20% <ø> (ø)`
nest-aws	`54.03% <ø> (-7.08%)`	⬇️
nest-config	`77.87% <ø> (ø)`
nest-core	`43.54% <ø> (ø)`
nest-feature-flags	`50.96% <ø> (ø)`
nest-problem	`45.82% <ø> (ø)`
nest-sequelize	`94.44% <ø> (ø)`
nest-swagger	`51.71% <ø> (ø)`
nova-sms	`61.90% <ø> (ø)`
portals-admin-regulations-admin	`1.85% <ø> (ø)`
portals-core	`15.95% <ø> (+0.02%)`	⬆️
reference-backend	`49.74% <ø> (ø)`
regulations	`16.78% <ø> (ø)`
residence-history	`85.00% <ø> (ø)`
services-auth-admin-api	`52.47% <ø> (ø)`
services-auth-delegation-api	`58.19% <ø> (ø)`
services-auth-ids-api	`52.08% <ø> (+0.01%)`	⬆️
services-auth-personal-representative	`45.59% <ø> (ø)`
services-auth-personal-representative-public	`41.75% <ø> (-0.06%)`	⬇️
services-auth-public-api	`49.56% <ø> (ø)`
services-documents	`60.81% <ø> (ø)`
services-endorsements-api	`53.34% <ø> (ø)`
services-sessions	`65.39% <ø> (ø)`
services-university-gateway	`49.34% <ø> (+0.02%)`	⬆️
services-user-notification	`46.84% <ø> (ø)`
services-user-profile	`61.84% <ø> (+0.09%)`	⬆️
shared-problem	`87.50% <ø> (ø)`
shared-utils	`27.69% <ø> (ø)`
skilavottord-ws	`24.14% <ø> (ø)`
testing-e2e	`66.66% <ø> (ø)`
web	`1.80% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9c16e...fb1cf40. Read the comment docs.

datadog-island-is · 2024-11-12T13:20:20Z

Datadog Report

All test runs 51d34db 🔗

✅ 101 Total Test Services: 0 Failed, 98 Passed
🔻 Test Sessions change in coverage: 3 decreased, 8 increased, 189 no change

Test Services

This report shows up to 10 services

Service Name	Passed	Total Time	Code Coverage Change	Test Service View
`air-discount-scheme-backend`	82	30.64s	N/A	Link
`air-discount-scheme-web`	2	6.98s	N/A	Link
`api`	4	3.12s	N/A	Link
`api-catalogue-services`	23	12.62s	N/A	Link
`api-domains-air-discount-scheme`	6	16.06s	N/A	Link
`api-domains-assets`	3	9.46s	N/A	Link
`api-domains-auth-admin`	18	10.14s	N/A	Link
`api-domains-communications`	5	37.27s	N/A	Link
`api-domains-criminal-record`	5	10.46s	N/A	Link
`api-domains-driving-license`	23	27.41s	N/A	Link

🔻 Code Coverage Decreases vs Default Branch (3)

services-auth-delegation-api - jest 51.72% (-0.19%) - Details
clients-middlewares - jest 75.82% (-0.1%) - Details
application-template-api-modules - jest 29.97% (-0.04%) - Details

hebaulf

LGTM 🕵️

Fixed ui and bugs.

b3e832b

addi requested a review from a team as a code owner November 12, 2024 12:51

Merge branch 'rental-agreement-application' of https://github.com/isl…

fb1cf40

…and-is/island.is into rental-agreement-application-security-deposit-fix

hebaulf approved these changes Nov 12, 2024

View reviewed changes

addi merged commit ff08c9e into rental-agreement-application Nov 12, 2024
256 of 261 checks passed

addi deleted the rental-agreement-application-security-deposit-fix branch November 12, 2024 15:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rental-agreement): security deposit fixes #16819

feat(rental-agreement): security deposit fixes #16819

addi commented Nov 12, 2024

coderabbitai bot commented Nov 12, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Nov 12, 2024 •

edited

Loading

datadog-island-is bot commented Nov 12, 2024

hebaulf left a comment

feat(rental-agreement): security deposit fixes #16819

feat(rental-agreement): security deposit fixes #16819

Conversation

addi commented Nov 12, 2024

Checklist:

coderabbitai bot commented Nov 12, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

codecov bot commented Nov 12, 2024 • edited Loading

Codecov Report

datadog-island-is bot commented Nov 12, 2024

Datadog Report

🔻 Code Coverage Decreases vs Default Branch (3)

hebaulf left a comment

Choose a reason for hiding this comment

codecov bot commented Nov 12, 2024 •

edited

Loading