fix(api): Revert endpoint change regarding Service web

[RunarVestmann]

Revert endpoint change regarding service web

Summary by CodeRabbit

• New Features

  • Enhanced data retrieval for service web pages and frontpage content using Elasticsearch.
  • Improved consistency in accessing various content types, including articles, news, and events.

• Bug Fixes

  • Introduced error handling for potential parsing errors in the Featured Events resolver.

[coderabbitai]

Walkthrough

The pull request implements significant changes to the CmsResolver class within the cms.resolver.ts file. It primarily shifts data retrieval methods to utilize the cmsElasticsearchService instead of the previous cmsContentfulService. This includes updates to methods such as getServiceWebPage, getFrontpage, and others, aligning them with Elasticsearch for fetching various content types. Additionally, error handling has been introduced in the namespace method of the FeaturedEventsResolver. Overall, these changes reflect a strategic transition in data handling within the resolver.

Changes

File Path	Change Summary
libs/cms/src/lib/cms.resolver.ts	- Updated getServiceWebPage, getFrontpage, getArticleCategories, getArticles, getNews, getEvents methods to use cmsElasticsearchService instead of cmsContentfulService. - Added error handling in namespace method of FeaturedEventsResolver.

Possibly related PRs

• feat(cms): Most common page types are now directly fetched from cms #16320: This PR modifies the CmsResolver class in libs/cms/src/lib/cms.resolver.ts, specifically updating methods to fetch data directly from cmsContentfulService, which is related to the changes in the main PR that also involves significant modifications to the CmsResolver class and its data retrieval methods.

Suggested reviewers

• mannipje

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 3a971c5 and 76f0e22.

📒 Files selected for processing (1)

• libs/cms/src/lib/cms.resolver.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

libs/cms/src/lib/cms.resolver.ts (1)

Pattern libs/**/*: "Confirm that the code adheres to the following:

• Reusability of components and hooks across different NextJS apps.
• TypeScript usage for defining props and exporting types.
• Effective tree-shaking and bundling practices."

🔇 Additional comments (1)

libs/cms/src/lib/cms.resolver.ts (1)

269-272: Switch to Elasticsearch service is correctly implemented

The getServiceWebPage method now correctly uses cmsElasticsearchService.getSingleDocumentTypeBySlug to fetch the service web page data from Elasticsearch.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.53%. Comparing base (3a971c5) to head (76f0e22).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
libs/cms/src/lib/cms.resolver.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16749   +/-   ##
=======================================
  Coverage   36.53%   36.53%           
=======================================
  Files        6890     6890           
  Lines      143638   143638           
  Branches    40924    40924           
=======================================
  Hits        52481    52481           
  Misses      91157    91157           

Flag	Coverage Δ
api	3.37% <ø> (ø)
api-domains-auth-admin	48.48% <ø> (ø)
api-domains-communications	39.76% <0.00%> (ø)
application-system-api	41.11% <0.00%> (ø)
application-template-api-modules	27.68% <0.00%> (-0.01%)	⬇️
cms	0.42% <0.00%> (ø)
cms-translations	38.89% <0.00%> (ø)
judicial-system-api	19.57% <ø> (ø)
judicial-system-backend	55.17% <0.00%> (ø)
services-user-notification	46.81% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
libs/cms/src/lib/cms.resolver.ts	66.79% <0.00%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a971c5...76f0e22. Read the comment docs.