Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rental-agreement-application): Coordinate build components id's #16737

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

hebaulf
Copy link

@hebaulf hebaulf commented Nov 6, 2024

Coordinate build component id's

Asana task

What

  • Change all build component id's to coordinate between sections
  • Other minor updates

Why

For cleaner schema setup

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

@hebaulf hebaulf requested a review from a team as a code owner November 6, 2024 10:42
Copy link
Contributor

coderabbitai bot commented Nov 6, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.54%. Comparing base (e818471) to head (08f638e).
Report is 1 commits behind head on rental-agreement-application.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                        @@
##           rental-agreement-application   #16737      +/-   ##
================================================================
- Coverage                         36.54%   36.54%   -0.01%     
================================================================
  Files                              6890     6890              
  Lines                            143646   143646              
  Branches                          40926    40926              
================================================================
- Hits                              52491    52490       -1     
- Misses                            91155    91156       +1     
Flag Coverage Δ
air-discount-scheme-backend 54.06% <ø> (ø)
air-discount-scheme-web 0.00% <ø> (ø)
api 3.37% <ø> (ø)
api-catalogue-services 77.85% <ø> (ø)
api-domains-air-discount-scheme 37.02% <ø> (ø)
api-domains-assets 26.71% <ø> (ø)
api-domains-auth-admin 48.48% <ø> (ø)
api-domains-communications 39.77% <ø> (ø)
api-domains-criminal-record 47.48% <ø> (ø)
api-domains-driving-license 44.47% <ø> (ø)
api-domains-education 31.27% <ø> (ø)
api-domains-health-insurance 34.33% <ø> (ø)
api-domains-mortgage-certificate 34.68% <ø> (ø)
api-domains-payment-schedule 41.25% <ø> (ø)
application-api-files 56.68% <ø> (ø)
application-core 71.72% <ø> (-0.32%) ⬇️
application-system-api 41.12% <ø> (ø)
application-template-api-modules 27.68% <ø> (-0.01%) ⬇️
application-templates-accident-notification 29.21% <ø> (ø)
application-templates-car-recycling 3.12% <ø> (ø)
application-templates-criminal-record 26.26% <ø> (ø)
application-templates-driving-license 18.40% <ø> (ø)
application-templates-estate 12.18% <ø> (ø)
application-templates-example-payment 25.17% <ø> (ø)
application-templates-financial-aid 15.56% <ø> (ø)
application-templates-general-petition 23.40% <ø> (ø)
application-templates-inheritance-report 6.52% <ø> (ø)
application-templates-marriage-conditions 15.20% <ø> (ø)
application-templates-mortgage-certificate 43.67% <ø> (ø)
application-templates-parental-leave 29.93% <ø> (ø)
application-types 6.54% <ø> (ø)
application-ui-components 1.27% <ø> (ø)
application-ui-shell 20.86% <ø> (ø)
auth-admin-web 2.43% <ø> (ø)
auth-nest-tools 30.20% <ø> (ø)
auth-react 21.94% <ø> (ø)
auth-shared 75.00% <ø> (ø)
clients-charge-fjs-v2 24.11% <ø> (ø)
clients-driving-license 40.20% <ø> (ø)
clients-driving-license-book 43.44% <ø> (ø)
clients-financial-statements-inao 48.98% <ø> (ø)
clients-license-client 1.83% <ø> (ø)
clients-middlewares 73.14% <ø> (ø)
clients-regulations 42.27% <ø> (ø)
clients-rsk-company-registry 29.76% <ø> (ø)
clients-rsk-personal-tax-return 38.00% <ø> (ø)
clients-smartsolutions 12.77% <ø> (ø)
clients-syslumenn 49.19% <ø> (ø)
clients-zendesk 54.61% <ø> (ø)
cms 0.42% <ø> (ø)
cms-translations 38.89% <ø> (ø)
content-search-index-manager 95.65% <ø> (ø)
content-search-toolkit 8.14% <ø> (ø)
contentful-apps 4.69% <ø> (ø)
dokobit-signing 62.58% <ø> (ø)
download-service 44.26% <ø> (ø)
email-service 60.41% <ø> (ø)
feature-flags 90.47% <ø> (ø)
file-storage 52.65% <ø> (ø)
financial-aid-backend 51.26% <ø> (ø)
financial-aid-shared 17.81% <ø> (ø)
icelandic-names-registry-backend 54.34% <ø> (ø)
infra-nest-server 48.37% <ø> (ø)
infra-tracing 43.24% <ø> (ø)
island-ui-core 28.86% <ø> (ø)
judicial-system-api 19.57% <ø> (ø)
judicial-system-audit-trail 68.70% <ø> (ø)
judicial-system-backend 55.17% <ø> (ø)
judicial-system-formatters 79.93% <ø> (ø)
judicial-system-message 66.79% <ø> (ø)
judicial-system-message-handler 47.71% <ø> (ø)
judicial-system-scheduler 70.40% <ø> (ø)
judicial-system-types 44.13% <ø> (ø)
judicial-system-web 27.58% <ø> (ø)
license-api 42.48% <ø> (-0.15%) ⬇️
localization 10.15% <ø> (ø)
logging 48.43% <ø> (ø)
message-queue 67.80% <ø> (-0.79%) ⬇️
nest-audit 68.20% <ø> (ø)
nest-aws 61.15% <ø> (ø)
nest-config 77.87% <ø> (ø)
nest-core 43.54% <ø> (ø)
nest-feature-flags 50.96% <ø> (ø)
nest-problem 45.82% <ø> (ø)
nest-sequelize 94.44% <ø> (ø)
nest-swagger 51.71% <ø> (ø)
nova-sms 61.90% <ø> (ø)
portals-admin-regulations-admin 1.85% <ø> (ø)
portals-core 15.96% <ø> (ø)
reference-backend 49.74% <ø> (ø)
regulations 16.78% <ø> (ø)
residence-history 85.00% <ø> (ø)
services-auth-admin-api 52.48% <ø> (ø)
services-auth-delegation-api 58.27% <ø> (ø)
services-auth-ids-api 52.09% <ø> (+0.01%) ⬆️
services-auth-personal-representative 45.61% <ø> (ø)
services-auth-personal-representative-public 41.74% <ø> (-0.08%) ⬇️
services-auth-public-api 49.58% <ø> (ø)
services-documents 60.81% <ø> (ø)
services-endorsements-api 53.61% <ø> (ø)
services-sessions 65.39% <ø> (ø)
services-university-gateway 49.40% <ø> (+0.08%) ⬆️
services-user-notification 46.81% <ø> (-0.04%) ⬇️
services-user-profile 61.77% <ø> (-0.08%) ⬇️
shared-components 26.97% <ø> (ø)
shared-form-fields 31.22% <ø> (ø)
shared-mocking 60.89% <ø> (ø)
shared-pii 92.85% <ø> (ø)
shared-problem 87.50% <ø> (ø)
shared-utils 27.69% <ø> (ø)
skilavottord-ws 24.14% <ø> (ø)
testing-e2e 66.66% <ø> (ø)
web 1.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e818471...08f638e. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Nov 6, 2024

Datadog Report

All test runs 559cb3b 🔗

101 Total Test Services: 0 Failed, 98 Passed
🔻 Test Sessions change in coverage: 1 decreased (-0.9%), 17 increased, 182 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 82 0 31.77s N/A Link
air-discount-scheme-web 0 0 0 2 0 7.05s N/A Link
api 0 0 0 4 0 2.41s N/A Link
api-catalogue-services 0 0 0 23 0 8.92s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 16.76s N/A Link
api-domains-assets 0 0 0 3 0 9.86s N/A Link
api-domains-auth-admin 0 0 0 18 0 10.52s N/A Link
api-domains-communications 0 0 0 5 0 31.19s N/A Link
api-domains-criminal-record 0 0 0 5 0 8.71s N/A Link
api-domains-driving-license 0 0 0 23 0 26.71s N/A Link

🔻 Code Coverage Decreases vs Default Branch (1)

  • message-queue - jest 68.26% (-0.9%) - Details

@hebaulf hebaulf merged commit f8727fd into rental-agreement-application Nov 6, 2024
261 checks passed
@hebaulf hebaulf deleted the chore/change-field-ids branch November 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant