fix(driving-license): allow continuing without quality photo

[stjanilofts]

Summary by CodeRabbit

• New Features

  • Enhanced eligibility criteria for the B_FULL_RENEWAL_65 driving license application, now excluding quality photo requirements.
  • Introduced conditional requirements based on the applicant's extended license status.

• Bug Fixes

  • Improved error handling for eligibility queries, ensuring consistent logging and error management.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the useEligibility function within the useEligibility.ts file, specifically refining the eligibility criteria for driving license applications. The logic for determining eligibility for the B_FULL_RENEWAL_65 category has been updated to remove the requirement for a quality photo and to conditionally include a requirement regarding extended driving licenses. The error handling and data fetching logic remain unchanged, ensuring consistent management of eligibility checks.

Changes

File Path	Change Summary
libs/application/templates/driving-license/src/fields/EligibilitySummary/useEligibility.ts	Modifications to eligibility logic for B_FULL_RENEWAL_65, removing photo quality requirement, and adding conditional requirement for NoExtendedDrivingLicense. Error handling and data fetching logic remain unchanged.

Possibly related PRs

• fix(driving-license): fix eligibility check for driving-license #15183: This PR modifies the eligibility check logic within the same useEligibility function, which is directly related to the changes made in the main PR regarding eligibility criteria.
• feat(driving-license): check if 65+ renewal is possible #16292: This PR introduces a new license type for renewal specifically for individuals aged 65 and older, which aligns with the changes in the main PR that refine eligibility criteria for the B_FULL_RENEWAL_65 category.

Suggested labels

automerge

Suggested reviewers

• kksteini

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 23c3069 and d9fd437.

📒 Files selected for processing (1)

• libs/application/templates/driving-license/src/fields/EligibilitySummary/useEligibility.ts (0 hunks)

💤 Files with no reviewable changes (1)

• libs/application/templates/driving-license/src/fields/EligibilitySummary/useEligibility.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.77%. Comparing base (6ea4498) to head (d9fd437).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #16509   +/-   ##
=======================================
  Coverage   36.77%   36.77%           
=======================================
  Files        6847     6847           
  Lines      141873   141872    -1     
  Branches    40424    40423    -1     
=======================================
  Hits        52167    52167           
+ Misses      89706    89705    -1     

Flag	Coverage Δ
api	3.37% <ø> (ø)
application-system-api	41.34% <ø> (ø)
application-template-api-modules	27.79% <ø> (-0.02%)	⬇️
application-templates-driving-license	18.34% <ø> (+0.01%)	⬆️
application-ui-shell	21.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...se/src/fields/EligibilitySummary/useEligibility.ts	0.00% <ø> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c3069...d9fd437. Read the comment docs.