fix(j-s): FMST Access

[gudjong]

FMST Access

FMST getur ekki opnað R mál

What

• Fixes FMST access to R cases.

Why

Verified bug.

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Chores
  • Improved code comments for clarity regarding access checks.
  • Reformatted variable declarations and control flow without changing functionality.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the canPrisonAdminUserAccessCase function within the case.filter.ts file. Modifications include restructuring comments and reformatting code for clarity, without altering the underlying logic or functionality. The access checks for various user roles remain unchanged, ensuring consistent permissions management for different user types.

Changes

File Path	Change Summary
apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts	Restructured comments and reformatted variable declarations and function calls for clarity.

Possibly related PRs

• fix(j-s): Defender Case File Access #15070: The changes in this PR involve access permissions related to case files, which may connect to the access checks in the canPrisonAdminUserAccessCase function modified in the main PR.
• chore(j-s): Prison users access to appeal case files #15844: This PR modifies access control logic for users based on their roles, which may relate to the restructuring of access checks in the main PR.
• fix(j-s): Allow prison system users to see rulings #15935: This PR enhances access for prison system users to ruling case files, which could be relevant to the access checks discussed in the main PR.
• fix(j-s): Defender Case Info #16024: The changes in this PR focus on the display of case information for defenders, which may relate to the access checks and logic in the main PR.
• chore(j-s): Fixes to ServiceRequirement NOT_REQUIRED #16305: This PR modifies access control logic for prison admin users, which aligns with the access checks in the main PR.
• feat(j-s): Civil Claimant Spokesperson Access #16389: This PR enhances access for civil claimants' spokespersons, which may relate to the broader access control logic discussed in the main PR.

Suggested labels

automerge

Suggested reviewers

• oddsson

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between cc13e8e and aeed3eb.

📒 Files selected for processing (1)

• apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (1)

Pattern apps/**/*: "Confirm that the code adheres to the following:

• NextJS best practices, including file structure, API routes, and static generation methods.
• Efficient state management and server-side rendering techniques.
• Optimal use of TypeScript for component and utility type safety."

🔇 Additional comments (2)

apps/judicial-system/backend/src/app/modules/case/filters/case.filter.ts (2)

293-304: Verify the intent of canAppealVerdict and consider improving variable naming

The changes improve code readability, but there are two points to consider:

1. The canAppealVerdict variable is always set to true. Is this intentional? If it's meant to be dynamic, consider replacing it with the actual condition or removing it if it's not needed.

2. The use of an underscore in the destructuring assignment [_, indictmentVerdictAppealDeadlineExpired] might reduce code clarity. Consider using a more descriptive name for the unused variable, such as unusedStatus.

To ensure the canAppealVerdict variable is used correctly throughout the codebase, run the following script:

This will help verify if the variable is used elsewhere or if it's always set to true in other parts of the codebase.

---

Line range hint 1-304: Summary: Changes align with PR objectives, but verify FMST access impact

The changes in this file primarily focus on improving code readability in the canPrisonAdminUserAccessCase function. While these modifications don't directly address the FMST access issue mentioned in the PR objectives, they don't introduce any regression in the existing logic.

To ensure these changes fully address the FMST access issue:

1. Verify that the canPrisonAdminUserAccessCase function is indeed the correct place for implementing the fix.
2. Confirm that the existing logic, including the check for indictmentVerdictAppealDeadlineExpired, correctly handles FMST access to R cases.
3. If additional changes are needed to fix the FMST access issue, consider adding them to this function or elsewhere in the file as appropriate.

To ensure the changes don't negatively impact FMST access, run the following script to check for any FMST-related code:

This will help identify any other areas of the codebase that might need attention for the FMST access fix.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.79%. Comparing base (4e91db4) to head (0e633cf).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ackend/src/app/modules/case/filters/case.filter.ts	66.66%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16486      +/-   ##
==========================================
- Coverage   36.79%   36.79%   -0.01%     
==========================================
  Files        6845     6845              
  Lines      141716   141716              
  Branches    40363    40363              
==========================================
- Hits        52139    52138       -1     
- Misses      89577    89578       +1     

Flag	Coverage Δ
api	3.37% <ø> (ø)
application-system-api	41.37% <ø> (ø)
application-template-api-modules	27.81% <ø> (+0.01%)	⬆️
judicial-system-backend	55.19% <66.66%> (ø)
license-api	42.53% <ø> (+0.01%)	⬆️
nest-core	43.54% <ø> (ø)
services-auth-ids-api	51.41% <ø> (-0.01%)	⬇️
services-user-notification	46.93% <ø> (+0.02%)	⬆️
services-user-profile	61.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ackend/src/app/modules/case/filters/case.filter.ts	88.88% <66.66%> (ø)

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e91db4...0e633cf. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs 8d35091 🔗

✅ 8 Total Test Services: 0 Failed, 8 Passed
⬆️ Test Sessions change in coverage: 1 increased (+0.01%), 14 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.74s	1 no change	Link
application-system-api	0	0	0	120	2	3m 15.87s	1 no change	Link
application-template-api-modules	0	0	0	123	0	2m 16.36s	1 increased (+0.01%)	Link
judicial-system-backend	0	0	0	21189	0	21m 27.81s	1 no change	Link
license-api	0	0	0	80	0	27.36s	1 no change	Link
services-auth-ids-api	0	0	0	152	0	1m 21.81s	1 no change	Link
services-user-notification	0	0	0	51	0	1m 26.44s	1 no change	Link
services-user-profile	0	0	0	131	0	27.53s	1 no change	Link