-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rental-agreement-application): Property condition subsection #16361
feat(rental-agreement-application): Property condition subsection #16361
Conversation
…sland.is into feat/register-landlord-and-tenant
…sland.is into feat/property-condition
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rental-agreement-application #16361 +/- ##
================================================================
+ Coverage 36.76% 36.86% +0.10%
================================================================
Files 6805 6804 -1
Lines 140946 140691 -255
Branches 40191 40067 -124
================================================================
+ Hits 51819 51871 +52
+ Misses 89127 88820 -307 Flags with carried forward coverage won't be shown. Click here to find out more. see 149 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 99 Total Test Services: 0 Failed, 97 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (8)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small tweaks for the subSection otherwise good :)
...application/templates/rental-agreement/src/forms/rentalHousingInfo/rentalHousingCondition.ts
Outdated
Show resolved
Hide resolved
...application/templates/rental-agreement/src/forms/rentalHousingInfo/rentalHousingCondition.ts
Outdated
Show resolved
Hide resolved
97d5fc3
into
rental-agreement-application
Property condition subsection
Attach a link to issue if relevant
What
Why
Applicant should be able to add information about the property condition and who does the inspection.
Screenshots / Gifs
Checklist: