Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth-admin): Webhook for general mandate delegation (#16257) #16313

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

saevarma
Copy link
Member

@saevarma saevarma commented Oct 8, 2024

What

Apply #16257 to release

Why

To jump on the release train

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Formatting passes locally with my changes
  • I have rebased against main before asking for a review

* gm-delegation-webhook

* chore: charts update dirty files

* pr comments fixes

* pr comments fixes

* fix broken test

* Pr comments

* Pr comments

* chore: nx format:write update dirty files

* fix translation string

* Add comment to signing secret dev value.
Reuse validatePersonsNationalIds in createDeleagtionByZendeskId

* Update test labels

---------

Co-authored-by: andes-it <[email protected]>
Co-authored-by: Sævar Már Atlason <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@saevarma saevarma requested review from a team as code owners October 8, 2024 12:10
Copy link
Contributor

coderabbitai bot commented Oct 8, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@saevarma saevarma added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 75.55556% with 22 lines in your changes missing coverage. Please review.

Please upload report for BASE (pre-release/32.1.0@5d822fd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...legations/admin/delegation-admin-custom.service.ts 60.46% 17 Missing ⚠️
apps/services/auth/admin-api/src/main.ts 0.00% 3 Missing ⚠️
libs/auth-nest-tools/src/lib/zendeskAuth.guard.ts 94.11% 1 Missing ⚠️
libs/infra-nest-server/src/lib/bootstrap.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##             pre-release/32.1.0   #16313   +/-   ##
=====================================================
  Coverage                      ?   36.87%           
=====================================================
  Files                         ?     6801           
  Lines                         ?   140605           
  Branches                      ?    39972           
=====================================================
  Hits                          ?    51854           
  Misses                        ?    88751           
  Partials                      ?        0           
Flag Coverage Δ
air-discount-scheme-backend 54.04% <32.25%> (?)
air-discount-scheme-web 0.00% <ø> (?)
api 3.37% <ø> (?)
api-domains-air-discount-scheme 36.90% <27.77%> (?)
api-domains-assets 26.71% <ø> (?)
api-domains-auth-admin 48.77% <ø> (?)
api-domains-communications 39.90% <31.57%> (?)
api-domains-criminal-record 47.96% <ø> (?)
api-domains-driving-license 44.39% <31.57%> (?)
api-domains-education 31.48% <100.00%> (?)
api-domains-health-insurance 34.83% <ø> (?)
api-domains-mortgage-certificate 35.67% <27.77%> (?)
api-domains-payment-schedule 41.13% <27.77%> (?)
application-api-files 57.97% <100.00%> (?)
application-core 71.54% <ø> (?)
application-system-api 41.66% <32.25%> (?)
application-template-api-modules 24.30% <31.57%> (?)
application-templates-accident-notification 29.44% <ø> (?)
application-templates-car-recycling 3.12% <ø> (?)
application-templates-criminal-record 26.63% <ø> (?)
application-templates-driving-license 18.40% <ø> (?)
application-templates-estate 12.32% <ø> (?)
application-templates-example-payment 25.41% <ø> (?)
application-templates-financial-aid 14.34% <ø> (?)
application-templates-general-petition 23.68% <ø> (?)
application-templates-health-insurance 26.62% <ø> (?)
application-templates-inheritance-report 6.45% <ø> (?)
application-templates-marriage-conditions 15.23% <ø> (?)
application-templates-mortgage-certificate 43.96% <ø> (?)
application-templates-parental-leave 30.03% <ø> (?)
application-types 6.71% <ø> (?)
application-ui-components 1.28% <ø> (?)
application-ui-shell 21.27% <ø> (?)
auth-nest-tools 29.84% <0.00%> (?)
auth-react 22.77% <ø> (?)
clients-charge-fjs-v2 24.11% <ø> (?)
clients-driving-license 40.63% <ø> (?)
clients-license-client 1.83% <ø> (?)
clients-middlewares 72.79% <100.00%> (?)
clients-regulations 42.76% <ø> (?)
clients-rsk-company-registry 29.76% <ø> (?)
clients-syslumenn 49.49% <27.77%> (?)
cms 0.43% <ø> (?)
cms-translations 39.03% <31.57%> (?)
download-service 44.01% <32.25%> (?)
financial-aid-backend 56.39% <27.77%> (?)
financial-aid-shared 19.03% <ø> (?)
icelandic-names-registry-backend 53.97% <30.00%> (?)
infra-nest-server 48.17% <33.33%> (?)
judicial-system-api 18.29% <ø> (?)
judicial-system-backend 55.17% <31.57%> (?)
judicial-system-web 27.96% <ø> (?)
license-api 42.51% <32.25%> (?)
nest-audit 68.20% <ø> (?)
nest-feature-flags 51.46% <27.77%> (?)
nest-problem 45.85% <30.00%> (?)
nest-swagger 51.71% <ø> (?)
portals-admin-regulations-admin 1.88% <ø> (?)
portals-core 16.15% <ø> (?)
reference-backend 49.79% <30.00%> (?)
services-auth-admin-api 52.12% <74.44%> (?)
services-auth-delegation-api 57.66% <20.25%> (?)
services-auth-ids-api 51.72% <20.25%> (?)
services-auth-personal-representative 45.41% <18.98%> (?)
services-auth-personal-representative-public 41.48% <18.98%> (?)
services-auth-public-api 49.21% <18.98%> (?)
services-documents 60.58% <30.00%> (?)
services-endorsements-api 55.03% <32.25%> (?)
services-sessions 65.36% <33.33%> (?)
services-university-gateway 48.27% <30.00%> (?)
services-user-notification 47.03% <35.48%> (?)
services-user-profile 62.17% <35.48%> (?)
shared-components 27.65% <ø> (?)
shared-form-fields 31.59% <ø> (?)
shared-utils 27.90% <0.00%> (?)
skilavottord-ws 24.24% <ø> (?)
web 1.83% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
apps/services/auth/admin-api/src/app/app.module.ts 100.00% <ø> (ø)
.../app/v2/delegations/delegation-admin.controller.ts 97.29% <100.00%> (ø)
...ces/auth/admin-api/src/environments/environment.ts 100.00% <100.00%> (ø)
libs/auth-api-lib/src/index.ts 100.00% <100.00%> (ø)
...h-api-lib/src/lib/delegations/constants/zendesk.ts 100.00% <ø> (ø)
...c/lib/delegations/dto/zendesk-webhook-input.dto.ts 100.00% <100.00%> (ø)
libs/auth-nest-tools/src/index.ts 100.00% <100.00%> (ø)
libs/infra-nest-server/src/index.ts 100.00% <100.00%> (ø)
...ra-nest-server/src/lib/includeRawBodyMiddleware.ts 100.00% <100.00%> (ø)
libs/shared/utils/src/lib/errorCodes.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d822fd...4e09f21. Read the comment docs.

@datadog-island-is
Copy link

Datadog Report

All test runs b69039d 🔗

76 Total Test Services: 0 Failed, 74 Passed
🔻 Test Sessions change in coverage: 2 decreased, 1 increased (+0.02%), 197 no change

Test Services
This report shows up to 10 services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
air-discount-scheme-backend 0 0 0 81 0 31.43s N/A Link
air-discount-scheme-web 0 0 0 2 0 8.26s N/A Link
api 0 0 0 4 0 2.92s N/A Link
api-domains-air-discount-scheme 0 0 0 6 0 19.62s N/A Link
api-domains-assets 0 0 0 3 0 12.25s 1 no change Link
api-domains-auth-admin 0 0 0 18 0 13.25s N/A Link
api-domains-communications 0 0 0 5 0 29.74s N/A Link
api-domains-criminal-record 0 0 0 5 0 9.16s 1 no change Link
api-domains-driving-license 0 0 0 23 0 32.68s 1 no change Link
api-domains-education 0 0 0 8 0 21.76s 1 no change Link

🔻 Code Coverage Decreases vs Default Branch (2)

  • clients-middlewares - jest 75.52% (-0.21%) - Details
  • services-auth-personal-representative-public - jest 40.69% (-0.02%) - Details

@kodiakhq kodiakhq bot merged commit ec0c249 into pre-release/32.1.0 Oct 8, 2024
211 of 232 checks passed
@kodiakhq kodiakhq bot deleted the hotfix-zendesk-webhook branch October 8, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants