chore(j-s): Add national id input component

[oddsson]

Add national id input component

Asana

What

Add national id input component

Why

To reuse the functionality of setting and removing error messages and validation. This component is currently used when registering defendants and will also be used in registering civil claimants.

Screenshots / Gifs

Screen.Recording.2024-09-19.at.14.04.25.mov

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• New Features

  • Introduced the InputNationalId component for handling national identification numbers with validation.
  • Replaced the previous input method in the DefendantInfo component with the new InputNationalId, streamlining error handling and input management.

• Bug Fixes

  • Improved clarity in data representation by setting national ID to null when "no national ID" is selected.

[coderabbitai]

Walkthrough

The changes introduce a new InputNationalId component for handling national identification numbers, specifically Social Security Numbers (SSNs) and dates of birth, utilizing the react-input-mask library for input formatting and validation. The component replaces the previous InputMask in the DefendantInfo component, simplifying input management and error handling. The modifications enhance the clarity and maintainability of the code by streamlining state management related to national ID inputs.

Changes

Files	Change Summary
apps/judicial-system/web/src/components/Inputs/InputNationalId.tsx	Introduced InputNationalId component for handling national ID inputs with validation and formatting.
apps/judicial-system/web/src/routes/Prosecutor/components/DefendantInfo/DefendantInfo.tsx	Integrated InputNationalId component, simplifying state management and error handling for national IDs.

Possibly related PRs

• chore(j-s): Add component for name inputs #16077: The InputName component introduced in this PR is related to the InputNationalId component as both are reusable input components designed to handle specific types of user input with built-in validation, enhancing the overall input handling in the application.

Suggested labels

automerge

Suggested reviewers

• unakb

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 2.85714% with 34 lines in your changes missing coverage. Please review.

Project coverage is 36.65%. Comparing base (cab33e1) to head (914a401).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...stem/web/src/components/Inputs/InputNationalId.tsx	3.03%	32 Missing ⚠️
...secutor/components/DefendantInfo/DefendantInfo.tsx	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16087      +/-   ##
==========================================
- Coverage   36.66%   36.65%   -0.01%     
==========================================
  Files        6748     6749       +1     
  Lines      138729   138746      +17     
  Branches    39403    39410       +7     
==========================================
+ Hits        50862    50863       +1     
- Misses      87867    87883      +16     

Flag	Coverage Δ
api	3.39% <ø> (ø)
application-system-api	41.51% <ø> (ø)
application-template-api-modules	23.47% <ø> (+0.01%)	⬆️
application-ui-shell	21.29% <ø> (ø)
judicial-system-web	28.63% <2.85%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...secutor/components/DefendantInfo/DefendantInfo.tsx	1.47% <0.00%> (+0.28%)	⬆️
...stem/web/src/components/Inputs/InputNationalId.tsx	3.03% <3.03%> (ø)

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab33e1...914a401. Read the comment docs.

[datadog-island-is]

Datadog Report

Branch report: j-s/inputs-national-id
Commit report: 93918b9
Test service: judicial-system-web

✅ 0 Failed, 338 Passed, 0 Skipped, 1m 9.96s Total Time
🔻 Test Sessions change in coverage: 1 decreased (-0.06%)

🔻 Code Coverage Decreases vs Default Branch (1)

• jest 32.84% (-0.06%) - Details

[unakb]

lgtm!