fix(occupational-licenses): Remove date of birth for health directorate licenses

[thorkellmani]

What

• Remove date of birth for health directorate occupational licenses

Why

• Unnecessary

Screenshots / Gifs

Attach Screenshots / Gifs to help reviewers understand the scope of the pull request

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• Formatting passes locally with my changes
• I have rebased against main before asking for a review

Summary by CodeRabbit

• Bug Fixes

  • Adjusted the rendering logic for the UserInfoLine component to only display when the date of birth is available, removing the loading state dependency.

• Impact

  • The removal of the date of birth extraction may affect features relying on this information, potentially altering the user experience regarding license holder details.

[coderabbitai]

Walkthrough

The changes involve the removal of the dateOfBirth property from the object constructed in the OccupationalLicensesV2Service class, affecting how license holder information is processed. Additionally, the rendering logic in the OccupationalLicensesDetail component has been modified to only display the UserInfoLine component when license?.dateOfBirth is truthy, eliminating the previous dependency on the loading state.

Changes

File	Change Summary
libs/api/domains/occupational-licenses-v2/src/lib/occupationalLicensesV2.service.ts	Removed the extraction of dateOfBirth from licenseHolderNationalId, altering object construction.
libs/service-portal/occupational-licenses/src/screens/v2/OccupationalLicensesDetail/OccupationalLicensesDetail.tsx	Modified rendering logic to display UserInfoLine only when license?.dateOfBirth is truthy.

Possibly related PRs

• fix(income-plan): Hide IKR when foreign income #15987: The changes in the OccupationalLicensesDetail component's rendering logic are related to the removal of the dateOfBirth property in the main PR, as both involve handling user information that may affect how data is displayed in the UI.

Suggested labels

automerge

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.81%. Comparing base (ddcffb9) to head (ba439df).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #16025      +/-   ##
==========================================
- Coverage   36.81%   36.81%   -0.01%     
==========================================
  Files        6721     6721              
  Lines      137881   137873       -8     
  Branches    39206    39201       -5     
==========================================
- Hits        50763    50757       -6     
+ Misses      87118    87116       -2     

Flag	Coverage Δ
api	3.39% <ø> (ø)
web	1.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcffb9...ba439df. Read the comment docs.

[datadog-island-is]

Datadog Report

All test runs b45e990 🔗

✅ 2 Total Test Services: 0 Failed, 2 Passed
➡️ Test Sessions change in coverage: 5 no change

Test Services

Service Name	Failed	Known Flaky	New Flaky	Passed	Skipped	Total Time	Code Coverage Change	Test Service View
api	0	0	0	4	0	2.56s	1 no change	Link
web	0	0	0	84	0	28.14s	1 no change	Link