feat(api): GraphQL api with BFF on startup support for DX #15980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
snaerseljan
commented
Sep 12, 2024
apps/api/prompt-bff.ts
Outdated
| process.env.BFF_TOKEN_SECRET_BASE64 = | ||
| // This is a valid 32-byte base64 encoded secret. | ||
| // You can generate a new one by running `openssl rand -base64 32` | ||
| 'Y0ROrC3mxDBnveN+EpAnLtSubttyjZZWcV43dyk7OQI=' |
There was a problem hiding this comment.
note that this secret is not used anywhere but locally
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/bff #15980 +/- ##
============================================
+ Coverage 36.44% 36.74% +0.30%
============================================
Files 6755 6729 -26
Lines 139862 138694 -1168
Branches 39910 39578 -332
============================================
+ Hits 50968 50970 +2
+ Misses 88894 87724 -1170
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 198 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ✅ 100 Total Test Services: 0 Failed, 98 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (15)
|
snaerseljan
force-pushed
the
feat/bff-prompts
branch
from
efcf8f2 to
85382bf
Compare
snaerseljan
force-pushed
the
feat/bff-prompts
branch
from
85382bf to
28c5404
Compare
busla
force-pushed
the
feat/bff
branch
2 times, most recently
from
be338ac to
32e5ae2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DX for GraphQL api and bff.
What
Since the arrival of the BFF that both our portals will communicate with, we need to make sure that the DX is great for developers. This pull request aims to solve that problem in neat manner.
When developers run the
nx run portals-admin:devcommand, the BFF server is started automatically alongside it. All necessary environment variables are preconfigured to streamline the development setup.Checklist: