Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configure universal links for the test app #15963

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Conversation

eirikurn
Copy link
Member

@eirikurn eirikurn commented Sep 11, 2024

What

Configure universal links for the apps.

Why

So the app can directly handle some of the service portal's URLs, which provides a better UX with biometric authentication.

Summary by CodeRabbit

  • New Features
    • Enhanced deep linking functionality through updates to the apple-app-site-association file, allowing for improved navigation and user experience.
  • Chores
    • Updated code ownership for the .well-known directory, assigning responsibility to the @island-is/aranja-app team.

@eirikurn eirikurn requested review from a team as code owners September 11, 2024 15:30
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024

Walkthrough

The pull request introduces changes to two files: the .github/CODEOWNERS file and the apple-app-site-association file. In the .github/CODEOWNERS file, a new entry is added to assign ownership of the /apps/web/public/.well-known/ directory to the @island-is/aranja-app team. The apple-app-site-association file undergoes modifications to enhance the JSON structure, specifically by adding an "applinks" section with a "details" array that includes application identifiers and URL patterns for deep linking.

Changes

File Path Change Summary
.github/CODEOWNERS Added entry for /apps/web/public/.well-known/ assigned to @island-is/aranja-app.
apps/web/public/.well-known/apple-app-site-association Enhanced JSON structure by adding "applinks": { "details": [...] } for improved deep linking.

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f885cca and dc08122.

Files selected for processing (2)
  • .github/CODEOWNERS (1 hunks)
  • apps/web/public/.well-known/apple-app-site-association (1 hunks)
Files skipped from review due to trivial changes (1)
  • .github/CODEOWNERS
Additional comments not posted (1)
apps/web/public/.well-known/apple-app-site-association (1)

2-21: LGTM!

The "applinks" section is correctly configured:

  • The "appIDs" property correctly lists the app identifiers.
  • The "components" property correctly lists the URL patterns for deep linking.

The changes are approved.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.79%. Comparing base (f885cca) to head (dc08122).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15963      +/-   ##
==========================================
- Coverage   36.84%   36.79%   -0.06%     
==========================================
  Files        6714     6701      -13     
  Lines      137619   137079     -540     
  Branches    39113    38965     -148     
==========================================
- Hits        50705    50434     -271     
+ Misses      86914    86645     -269     
Flag Coverage Δ
api 3.39% <ø> (ø)
application-system-api 41.69% <ø> (ø)
application-template-api-modules 23.48% <ø> (ø)
application-templates-driving-license 15.58% <ø> (ø)
application-ui-shell 21.08% <ø> (ø)
web 1.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f885cca...dc08122. Read the comment docs.

@datadog-island-is
Copy link

datadog-island-is bot commented Sep 11, 2024

Datadog Report

All test runs 4c1544d 🔗

6 Total Test Services: 0 Failed, 6 Passed
➡️ Test Sessions change in coverage: 9 no change

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Code Coverage Change Test Service View
api 0 0 0 4 0 3.01s 1 no change Link
application-system-api 0 0 0 111 2 3m 15.13s 1 no change Link
application-template-api-modules 0 0 0 109 0 1m 43.9s 1 no change Link
application-templates-driving-license 0 0 0 13 0 15.99s 1 no change Link
application-ui-shell 0 0 0 74 0 32.35s 1 no change Link
web 0 0 0 84 0 31.05s 1 no change Link

Copy link
Member

@robertaandersen robertaandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eirikurn eirikurn added the deprecated:automerge (Disabled) Merge this PR as soon as all checks pass label Sep 11, 2024
@kodiakhq kodiakhq bot merged commit 0df72d2 into main Sep 11, 2024
40 checks passed
@kodiakhq kodiakhq bot deleted the universal-links branch September 11, 2024 16:21
jonnigs pushed a commit that referenced this pull request Sep 12, 2024
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated:automerge (Disabled) Merge this PR as soon as all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants