-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(regulations-admin): Increase body limit on regulations backend #15884
Conversation
WalkthroughThe change introduces a new configuration option, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 2 Total Test Services: 0 Failed, 2 Passed Test Services
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- apps/services/regulations-admin-backend/src/main.ts (1 hunks)
Additional context used
Path-based instructions (1)
apps/services/regulations-admin-backend/src/main.ts (2)
Pattern
apps/services/**/*
: "Confirm that the code adheres to the following:
- NestJS architecture, including modules, services, and controllers.
- Dependency injection patterns and service encapsulation.
- Integration and unit testing coverage and practices."
Pattern
apps/**/*
: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (1)
apps/services/regulations-admin-backend/src/main.ts (1)
10-10
: LGTM!The code change is approved for the following reasons:
- The
jsonBodyLimit
configuration option is a valid option for thebootstrap
function provided by the@island.is/infra-nest-server
package.- The value of '300kb' is consistent with the limit set in the apps-api, as mentioned in the PR summary.
- The change adheres to the NestJS architecture and dependency injection patterns, as it only modifies the application configuration without affecting the core architecture.
- No new tests are required for this configuration change, as it does not affect the application's behavior or functionality.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15884 +/- ##
=======================================
Coverage 36.93% 36.93%
=======================================
Files 6681 6681
Lines 136472 136463 -9
Branches 38756 38749 -7
=======================================
- Hits 50401 50400 -1
+ Misses 86071 86063 -8
Flags with carried forward coverage won't be shown. Click here to find out more. see 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…15884) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
What
Increase JSON body limit on regulations-admin-backend.
Fixing this error:
...PayloadTooLargeError: request entity too large...
Why
Some of the body transferred can be quite big, it's rare but happens occasionally. Around 150-200kb are some of the biggest I've noticed.
apps-api already has a 300kb body limit. We need the same for regulations-admin-backend.
Checklist:
Summary by CodeRabbit