feat(j-s): Add "acknowledged" to case and subpoena #15860
Conversation
WalkthroughThe changes introduce a new optional property, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15860 +/- ##
=======================================
Coverage 36.93% 36.93%
=======================================
Files 6681 6681
Lines 136464 136456 -8
Branches 38749 38743 -6
=======================================
Hits 50401 50401
+ Misses 86063 86055 -8
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (2)
- apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts (2 hunks)
- apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (2 hunks)
Additional context used
Path-based instructions (2)
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (2)
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts (1)
14-15: LGTM!The new optional
acknowledgedproperty is added correctly to theIndictmentCaseDataclass with appropriate type annotation and API schema decoration.apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts (1)
28-29: LGTM!The new optional
acknowledgedproperty is correctly defined in theSubpoenaDataclass.
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/case.response.ts
Show resolved
Hide resolved
apps/judicial-system/digital-mailbox-api/src/app/modules/cases/models/subpoena.response.ts
Show resolved
Hide resolved
Datadog ReportAll test runs ✅ 5 Total Test Services: 0 Failed, 5 Passed Test Services
|
* feat(j-s): Added acknowledged to case and subpoena response * fix(j-s): Add mock to response * Update subpoena.response.ts --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Mock birt fyrir mínar síður
What
Add acknowledged boolean to case and subpoena responses. Just returns false as is, we need to return info from RLS when we've connected that to RVG.
Why
So we can return them to Mínar Síður when ready
Checklist: