chore(j-s): Allow public prosecutor user to open case files

apps/judicial-system/backend/src/app/modules/case/case.controller.ts

@@ -548,6 +548,7 @@ export class CaseController {
   @RolesRules(
     prosecutorRule,
     prosecutorRepresentativeRule,
+    publicProsecutorStaffRule,
     districtCourtJudgeRule,
     districtCourtRegistrarRule,
     districtCourtAssistantRule,

apps/judicial-system/backend/src/app/modules/case/test/caseController/getCaseFilesRecordPdfRolesRules.spec.ts

@@ -4,6 +4,7 @@ import {
   districtCourtRegistrarRule,
   prosecutorRepresentativeRule,
   prosecutorRule,
+  publicProsecutorStaffRule,
 } from '../../../../guards'
 import { CaseController } from '../../case.controller'
 
@@ -19,9 +20,10 @@ describe('CaseController - Get case files record pdf rules', () => {
   })
 
   it('should give permission to roles', () => {
-    expect(rules).toHaveLength(5)
+    expect(rules).toHaveLength(6)
     expect(rules).toContain(prosecutorRule)
     expect(rules).toContain(prosecutorRepresentativeRule)
+    expect(rules).toContain(publicProsecutorStaffRule)
     expect(rules).toContain(districtCourtJudgeRule)
     expect(rules).toContain(districtCourtRegistrarRule)
     expect(rules).toContain(districtCourtAssistantRule)

apps/judicial-system/backend/src/app/modules/file/file.controller.ts

@@ -37,6 +37,7 @@ import {
   prisonSystemStaffRule,
   prosecutorRepresentativeRule,
   prosecutorRule,
+  publicProsecutorStaffRule,
 } from '../../guards'
 import {
   Case,
@@ -133,6 +134,7 @@ export class FileController {
   @RolesRules(
     prosecutorRule,
     prosecutorRepresentativeRule,
+    publicProsecutorStaffRule,
     districtCourtJudgeRule,
     districtCourtRegistrarRule,
     districtCourtAssistantRule,

apps/judicial-system/backend/src/app/modules/file/guards/test/viewCaseFileGuard.spec.ts

@@ -12,6 +12,7 @@ import {
   districtCourtRoles,
   InstitutionType,
   prosecutionRoles,
+  publicProsecutorRoles,
   User,
   UserRole,
 } from '@island.is/judicial-system/types'
@@ -210,6 +211,59 @@ describe('View Case File Guard', () => {
     })
   })
 
+  describe.each(publicProsecutorRoles)('role %s', (role) => {
+    describe.each(completedCaseStates)('%s cases', (state) => {
+      let then: Then
+
+      beforeEach(() => {
+        mockRequest.mockImplementationOnce(() => ({
+          user: {
+            role,
+            institution: {
+              type: InstitutionType.PROSECUTORS_OFFICE,
+              id: '8f9e2f6d-6a00-4a5e-b39b-95fd110d762e',
+            },
+          },
+          case: { state },
+        }))
+
+        then = givenWhenThen()
+      })
+
+      it('should activate', () => {
+        expect(then.result).toBe(true)
+      })
+    })
+
+    describe.each(
+      Object.values(CaseState).filter(
+        (state) => !completedCaseStates.includes(state),
+      ),
+    )('%s cases', (state) => {
+      let then: Then
+
+      beforeEach(() => {
+        mockRequest.mockImplementationOnce(() => ({
+          user: {
+            role,
+            institution: {
+              type: InstitutionType.PROSECUTORS_OFFICE,
+              id: '8f9e2f6d-6a00-4a5e-b39b-95fd110d762e',
+            },
+          },
+          case: { state },
+        }))
+
+        then = givenWhenThen()
+      })
+
+      it('should throw ForbiddenException', () => {
+        expect(then.error).toBeInstanceOf(ForbiddenException)
+        expect(then.error.message).toBe(`Forbidden for ${role}`)
+      })
+    })
+  })
+
   describe.each(Object.keys(CaseState))('in state %s', (state) => {
     describe.each(
       Object.keys(UserRole).filter(

apps/judicial-system/backend/src/app/modules/file/guards/viewCaseFile.guard.ts

@@ -14,6 +14,7 @@ import {
   isDistrictCourtUser,
   isPrisonSystemUser,
   isProsecutionUser,
+  isPublicProsecutorUser,
   User,
 } from '@island.is/judicial-system/types'
 
@@ -44,6 +45,10 @@ export class ViewCaseFileGuard implements CanActivate {
       return true
     }
 
+    if (isPublicProsecutorUser(user) && isCompletedCase(theCase.state)) {
+      return true
+    }
+
     if (
       isDistrictCourtUser(user) &&
       ([CaseState.SUBMITTED, CaseState.RECEIVED].includes(theCase.state) ||

apps/judicial-system/backend/src/app/modules/file/test/fileController/getCaseFileSignedUrlRolesRules.spec.ts

@@ -8,6 +8,7 @@ import {
   prisonSystemStaffRule,
   prosecutorRepresentativeRule,
   prosecutorRule,
+  publicProsecutorStaffRule,
 } from '../../../../guards'
 import { FileController } from '../../file.controller'
 
@@ -23,9 +24,10 @@ describe('FileController - Get case file signed url rules', () => {
   })
 
   it('should give permission to roles', () => {
-    expect(rules).toHaveLength(9)
+    expect(rules).toHaveLength(10)
     expect(rules).toContain(prosecutorRule)
     expect(rules).toContain(prosecutorRepresentativeRule)
+    expect(rules).toContain(publicProsecutorStaffRule)
     expect(rules).toContain(districtCourtJudgeRule)
     expect(rules).toContain(districtCourtRegistrarRule)
     expect(rules).toContain(districtCourtAssistantRule)