fix(storybook): Accordion item title formatting wrong for Icelandic characters #15564
Conversation
WalkthroughThe recent changes focus on updating the label definitions of Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Accordion
participant AccordionItem
User->>Accordion: Open Accordion
Accordion->>AccordionItem: Show Item Labels
AccordionItem-->>User: Display Labels
This diagram illustrates the interaction between the user and the accordion components, showing how the labels are presented without changing the underlying functionality. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- libs/island-ui/core/src/lib/Accordion/Accordion.stories.mdx (10 hunks)
Files skipped from review due to trivial changes (1)
- libs/island-ui/core/src/lib/Accordion/Accordion.stories.mdx
Datadog ReportAll test runs ✅ 35 Total Test Services: 0 Failed, 34 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (2) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15564 +/- ##
==========================================
- Coverage 37.02% 37.02% -0.01%
==========================================
Files 6556 6556
Lines 134022 134024 +2
Branches 38359 38360 +1
==========================================
Hits 49617 49617
- Misses 84405 84407 +2 Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…haracters (#15564) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
…haracters (#15564) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Accordion item title formatting wrong for Icelandic characters
What
<p>tag is getting inserted in the DOM storybookjs/storybook#18921 (comment) which I tried and it actually worked, by adding brackets the formatting is correct (see screenshots below)Screenshots / Gifs
Before
After
Summary by CodeRabbit
<AccordionItem />and<SidebarAccordion />components for improved consistency and flexibility.