chore(j-s): Completed case notifications #14832
Conversation
|
Warning Rate Limit Exceeded@oddsson has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 52 minutes and 56 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates to the judicial system's backend notifications involve refining the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/backend/src/app/messages/notifications.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/notification/notification.service.ts (3 hunks)
- libs/judicial-system/formatters/src/lib/formatters.ts (2 hunks)
Additional Context Used
Path-based Instructions (3)
libs/judicial-system/formatters/src/lib/formatters.ts (1)
Pattern
libs/**/*: "Confirm that the code adheres to the following:
- Reusability of components and hooks across different NextJS apps.
- TypeScript usage for defining props and exporting types.
- Effective tree-shaking and bundling practices."
apps/judicial-system/backend/src/app/messages/notifications.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
apps/judicial-system/backend/src/app/modules/notification/notification.service.ts (1)
Pattern
apps/**/*: "Confirm that the code adheres to the following:
- NextJS best practices, including file structure, API routes, and static generation methods.
- Efficient state management and server-side rendering techniques.
- Optimal use of TypeScript for component and utility type safety."
Additional comments not posted (6)
apps/judicial-system/backend/src/app/messages/notifications.ts (3)
300-301: The updatedcase_completed.subjectmessage ID and default message are appropriate and align with the PR objectives.
306-308: The updatedcase_completed.prosecutor_bodymessage includes additional details such as the case decision and a link to the case overview page, which improves clarity and informativeness.
313-315: The updatedcase_completed.defender_bodymessage includes additional details such as the case decision and conditional access information, which improves clarity and informativeness.apps/judicial-system/backend/src/app/modules/notification/notification.service.ts (3)
30-30: Import statement forgetHumanReadableCaseIndictmentRulingDecisionlooks good.
967-970: Usage ofgetHumanReadableCaseIndictmentRulingDecisionis correctly integrated into the notification body.
1005-1008: Usage ofgetHumanReadableCaseIndictmentRulingDecisionis correctly integrated into the notification body.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14832 +/- ##
==========================================
- Coverage 36.98% 36.97% -0.01%
==========================================
Files 6327 6327
Lines 129006 129015 +9
Branches 36817 36820 +3
==========================================
+ Hits 47707 47708 +1
- Misses 81299 81307 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
Datadog ReportAll test runs ❌ 5 Total Test Services: 1 Failed, 4 Passed Test Services
❌ Failed Tests (1)
🔻 Code Coverage Decreases vs Default Branch (3) |
oddsson
added
the
deprecated:automerge
…ted-case-notifications
There was a problem hiding this comment.
Actionable comments posted: 0
Review Details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- apps/judicial-system/backend/src/app/messages/notifications.ts (1 hunks)
- apps/judicial-system/backend/src/app/modules/notification/notification.service.ts (3 hunks)
- libs/judicial-system/formatters/src/lib/formatters.ts (2 hunks)
Files skipped from review due to trivial changes (1)
- apps/judicial-system/backend/src/app/modules/notification/notification.service.ts
Files skipped from review as they are similar to previous changes (2)
- apps/judicial-system/backend/src/app/messages/notifications.ts
- libs/judicial-system/formatters/src/lib/formatters.ts
Completed case notifications
Asana
What
Update text in notifications sent to prosecutors and defenders when an indictment is completed.
Why
We are adding the decision made by the judge in the email and making it a little more readable for the recipient.
Screenshots / Gifs
Checklist:
Summary by CodeRabbit
New Features
Improvements
Backend Enhancements