fix(search-indexer): Stop refreshing index immediately (#17069)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
island-is · Nov 28, 2024 · 7d3961e · 7d3961e
1 parent 9ea0c3d
commit 7d3961e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 20 deletions.
diff --git a/libs/content-search-indexer/src/lib/indexing.service.ts b/libs/content-search-indexer/src/lib/indexing.service.ts
@@ -61,8 +61,6 @@ export class IndexingService {
       let nextPageToken: string | undefined = undefined
       let postSyncOptions: SyncResponse['postSyncOptions']
 
-      const isIncrementalUpdate = syncType === 'fromLast'
-
       // Fetch initial page specifically in case importing is skipped (no need to wait for a new sync token if we don't need it)
       {
         const importerResponse = await importer.doSync({
@@ -83,11 +81,7 @@ export class IndexingService {
           postSyncOptions: importerResponsePostSyncOptions,
           ...elasticData
         } = importerResponse
-        await this.elasticService.bulk(
-          elasticIndex,
-          elasticData,
-          isIncrementalUpdate,
-        )
+        await this.elasticService.bulk(elasticIndex, elasticData)
 
         nextPageToken = importerResponseNextPageToken
         postSyncOptions = importerResponsePostSyncOptions
@@ -115,11 +109,7 @@ export class IndexingService {
               postSyncOptions: importerResponsePostSyncOptions,
               ...elasticData
             } = importerResponse
-            await this.elasticService.bulk(
-              elasticIndex,
-              elasticData,
-              isIncrementalUpdate,
-            )
+            await this.elasticService.bulk(elasticIndex, elasticData)
 
             nextPageToken = importerResponseNextPageToken
             postSyncOptions = importerResponsePostSyncOptions

diff --git a/libs/content-search-toolkit/src/services/elastic.service.ts b/libs/content-search-toolkit/src/services/elastic.service.ts
@@ -68,7 +68,7 @@ export class ElasticService {
   }
 
   // this can partially succeed
-  async bulk(index: string, documents: SyncRequest, refresh = false) {
+  async bulk(index: string, documents: SyncRequest) {
     logger.info('Processing documents', {
       index,
       added: documents.add.length,
@@ -106,14 +106,10 @@ export class ElasticService {
       return false
     }
 
-    await this.bulkRequest(index, requests, refresh)
+    await this.bulkRequest(index, requests)
   }
 
-  async bulkRequest(
-    index: string,
-    requests: Record<string, unknown>[],
-    refresh = false,
-  ) {
+  async bulkRequest(index: string, requests: Record<string, unknown>[]) {
     const chunkSize = 14
     let delay = INITIAL_DELAY
     let retries = MAX_RETRY_COUNT
@@ -129,7 +125,6 @@ export class ElasticService {
           const response = await client.bulk({
             index: index,
             body: requestChunk,
-            refresh: refresh ? 'true' : undefined,
           })
 
           // not all errors are thrown log if the response has any errors