fix: failed test and coderabbit

island-is · Sep 20, 2024 · 7cf3e27 · 7cf3e27
1 parent c568918
commit 7cf3e27
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 13 deletions.
diff --git a/...s/inao/financial-statement-political-party/src/fields/DelegationCheck/DelegationCheck.tsx b/...s/inao/financial-statement-political-party/src/fields/DelegationCheck/DelegationCheck.tsx
@@ -20,8 +20,6 @@ export const DelegationCheck = ({
       const userType = application.externalData.getUserType?.data
       const hasUserType = !!userType
 
-      console.log('UserType: ', userType)
-
       if (hasUserType) {
         setError(VALIDATOR, {
           type: 'custom',

diff --git a/...ao/financial-statement-political-party/src/fields/ElectionStatement/ElectionStatement.tsx b/...ao/financial-statement-political-party/src/fields/ElectionStatement/ElectionStatement.tsx
@@ -32,9 +32,9 @@ export const ElectionStatement = ({
     const incomeLimit = getValueViaPath(answers, 'election.incomeLimit')
 
     if (incomeLimit === GREATER) {
-      goToScreen && goToScreen('attachments.file')
+      goToScreen?.('attachments.file')
     } else {
-      goToScreen && goToScreen('election')
+      goToScreen?.('election')
     }
   }
 

diff --git a/...ation/templates/inao/financial-statement-political-party/src/fields/Overview/Overview.tsx b/...ation/templates/inao/financial-statement-political-party/src/fields/Overview/Overview.tsx
@@ -24,7 +24,7 @@ import {
   sectionColumn,
   starterColumnStyle,
 } from '../../components/css/overviewStyles.css'
-import { CapitalNumberOverview } from '../../components/CApitalNumberOverview'
+import { CapitalNumberOverview } from '../../components/CapitalNumberOverview'
 import { AssetDebtEquityOverview } from '../../components/AssetDebtEquityOverview'
 import { FileValueLine } from '../../components/FileValueLine'
 

diff --git a/...lates/inao/financial-statement-political-party/src/fields/PartyOverview/PartyOverview.tsx b/...lates/inao/financial-statement-political-party/src/fields/PartyOverview/PartyOverview.tsx
@@ -26,7 +26,7 @@ import {
   sectionColumn,
   starterColumnStyle,
 } from '../../components/css/overviewStyles.css'
-import { CapitalNumberOverview } from '../../components/CApitalNumberOverview'
+import { CapitalNumberOverview } from '../../components/CapitalNumberOverview'
 
 export const PartyOverview = ({
   application,

diff --git a/libs/application/templates/inao/financial-statement-political-party/src/utils/helpers.ts b/libs/application/templates/inao/financial-statement-political-party/src/utils/helpers.ts
@@ -41,10 +41,4 @@ export const formatCurrency = (answer: string) =>
 
 export const formatNumber = (num: number) => num.toLocaleString('de-DE')
 
-export const checkIfNegative = (inputNumber: string) => {
-  if (Number(inputNumber) < 0) {
-    return false
-  } else {
-    return true
-  }
-}
+export const checkIfNegative = (inputNumber: string) => Number(inputNumber) >= 0