TS-949 Create language selection

- Simplify code
island-is · Jan 23, 2025 · 4179b6b · 4179b6b
1 parent c07bba7
commit 4179b6b
Showing 1 changed file with 7 additions and 18 deletions.
diff --git a/libs/application/templates/new-primary-school/src/fields/LanguageSelection/index.tsx b/libs/application/templates/new-primary-school/src/fields/LanguageSelection/index.tsx
@@ -59,24 +59,13 @@ const LanguageSelection: FC<React.PropsWithChildren<FieldBaseProps>> = ({
   useEffect(() => {
     const { language1, language2, language3, language4 } =
       getApplicationAnswers(application.answers)
-    const selected: string[] = []
-    let visibleCount = 1
-    if (language1) {
-      selected.push(language1)
-      visibleCount = 1
-    }
-    if (language2) {
-      selected.push(language2)
-      visibleCount = 2
-    }
-    if (language3) {
-      selected.push(language3)
-      visibleCount = 3
-    }
-    if (language4) {
-      selected.push(language4)
-      visibleCount = 4
-    }
+
+    const selected = [language1, language2, language3, language4].filter(
+      Boolean,
+    )
+
+    // Ensure the visible count is at least 1
+    const visibleCount = Math.max(1, selected.length)
 
     setSelectedLanguages(selected)
     setVisibleLanguagesCount(visibleCount)