Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue #5924: #5938

Merged
merged 4 commits into from
Oct 14, 2023
Merged

Fix for Issue #5924: #5938

merged 4 commits into from
Oct 14, 2023

Commits on Apr 20, 2023

  1. Fix for Issue isl-org#5924:

    Changed TriangleMesh::materials_ to be a std::vector<std::pair<std::string, Material>> so that the order of materials when loading a mesh is respected.
    Using the unordered map caused issues when a Default Material and a texture were loaded and the texture would end up as the second material in the iterator.
    Now TriangleMesh::triangle_material_ids_ will indicate what material index should be used.
    A warning is given when passing a TriangleMesh to the visualizer and more than one material index is found, and the minimum value found in TriangleMesh::triangle_material_ids_ is used.
    If no triangle_material_ids_ exist then the first material in the order they are loaded will be used.
    dbs4261 committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    a09c8bc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    01fdc2e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6e156c1 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Merge master. Style fixes

    errissa committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    405698f View commit details
    Browse the repository at this point in the history