-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3.10 #5320
Python 3.10 #5320
Conversation
PyTorch 1.12 Tensorflow 2.9.1 CUDA 11.3 CUDNN 8.4 scipy 1.7.3
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
tf 2.9.1 wheel has new cxx11_abi Update wheel 0.37.1 scipy 1.7.3 Re-order pip install requirements to ensure jinja ver lock is honoured
CHange to Python 3.7 before merge Remove Python 3.6 refs
Use Python packaging lib for PEP 440 version comparisons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssheorey Did you have time to run the minimal example in #3324 ?
Reviewable status: 0 of 26 files reviewed, all discussions resolved (waiting on @sanskar107 and @yxlao)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 26 of 26 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @sanskar107 and @ssheorey)
docker/docker_build.sh
line 85 at r2 (raw file):
print_usage_and_exit_docker_build() { echo "$__usage_docker_build"
Seems like 4-space indentations are replaced with tabs. Shall we keep the 4-space indentation?
docker/docker_test.sh
line 61 at r2 (raw file):
print_usage_and_exit_docker_test() { echo "$__usage_docker_test"
Same, shall we keep the 4-space indentation?
util/ci_utils.sh
line 10 at r2 (raw file):
DEVELOPER_BUILD="${DEVELOPER_BUILD:-ON}" if [[ "$DEVELOPER_BUILD" != "OFF" ]]; then # Validate input coming from GHA input field DEVELOPER_BUILD="ON"
Same, shall we keep the 4-space indentation?
Tested official PyTorch 1.9+ works correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, tested with PyTorch 1.9 (CUDA 11.1) and PyTorch 1.12 (CUDA 11.6). Both work correctly. Test output in #3324
Reviewable status: 21 of 27 files reviewed, 3 unresolved discussions (waiting on @sanskar107 and @yxlao)
docker/docker_build.sh
line 85 at r2 (raw file):
Previously, yxlao (Yixing Lao) wrote…
Seems like 4-space indentations are replaced with tabs. Shall we keep the 4-space indentation?
Done.
docker/docker_test.sh
line 61 at r2 (raw file):
Previously, yxlao (Yixing Lao) wrote…
Same, shall we keep the 4-space indentation?
Done.
util/ci_utils.sh
line 10 at r2 (raw file):
Previously, yxlao (Yixing Lao) wrote…
Same, shall we keep the 4-space indentation?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Reviewable status: 21 of 27 files reviewed, 3 unresolved discussions (waiting on @sanskar107 and @yxlao)
Closes #3324
Closes #4535
TODO: Switch Python version in CI to 3.7 from 3.10 (current) before merging.
Companion Open3D-ML PR isl-org/Open3D-ML#554
Tensorflow 2.9+ switched to _GLIBCXX_USE_CXX11_ABI=1
PyTorch plans to from 1.13 (next release).
This change is