Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print warning if compiling pytorch ops with torch 1.7 and cuda 11 #3325

Closed
wants to merge 2 commits into from

Conversation

benjaminum
Copy link
Contributor

@benjaminum benjaminum commented Apr 22, 2021

Adds a warning if we compile the pytorch ops with torch 1.7 or later and cuda 11.
See #3324


This change is Reviewable

@update-docs
Copy link

update-docs bot commented Apr 22, 2021

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Contributor

@stotko stotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @benjaminum)


3rdparty/CMake/FindPytorch.cmake, line 65 at r1 (raw file):

        set_target_properties( torch_cpu PROPERTIES INTERFACE_COMPILE_OPTIONS "" )

        if( CUDA_VERSION VERSION_GREATER_EQUAL "11.0" AND

CUDAToolkit_VERSION instead of old deprecated CUDA_VERSION. The respective find_package(CUDAToolkit REQUIRED) call is already performed above, so the former is safely defined while the later is not.

Copy link
Contributor

@stotko stotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @benjaminum)

@benjaminum
Copy link
Contributor Author

Changes have been included in #3049

@benjaminum benjaminum closed this Apr 26, 2021
@reyanshsolis reyanshsolis deleted the benjaminum/torch_cuda11_warning branch March 22, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants