-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up util folder #2146
clean up util folder #2146
Conversation
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 57 of 59 files at r1, 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @benjaminum)
* clean up util folder * update relative dir * update relative dir
@yxlao The online documentation still references headless docker support: http://www.open3d.org/docs/release/tutorial/docker/docker-gui.html Did the feature never work? Dockerized headless CPU rendering is incredibly useful. |
@pwais dockerized headless CPU rendering should be feasible. Our documentation build runs headless rendering https://github.com/intel-isl/Open3D/blob/master/.github/workflows/documentation.yml. It's possible to cook your own Dockerfile by following the scripts in documentation.yml. |
@yxlao yup I saw the CI stuff 👍 but I'd rather not have to try to cook up my own Dockerfile when there appears to be one that works (tho it got removed :( ) in this commit... Is the functionality referenced in the current online docs going to be restored, or are the docs out of date and going to be deleted?
oh huh, is the python package i may be confused between open3d "headless rendering" mode and the Xvfb software rasterizer. when Open3d is build with headless rendering, can it use both the GPU and the CPU (via Xvfb) ? I've tried some of the jupyter examples and so far I got things to work in a docker container (based on lambda-stack ubuntu focal) https://github.com/lambdal/lambda-stack-dockerfiles/blob/master/Dockerfile.focal but that's via exposing host X11 into the container. I haven't gotten Xvfb + jupyter inside the container to work with the pypi release of Open3d; not sure if it's supposed to. |
* Add install with upgrade option when installing latest development package. * util/install-deps-python.sh was removed in #2146 * Grammar fix. * Move open3d_ml and arm to after docker. * organize TOC - Move C++ and Contribution to end and keep python section together. * Fix sphinx warnings (Title underline too short). * Fix extra heading drop when going one level down. * Fix cross reference links * Add files/directories to ignore for sphinx, reduces inconsistency warnings. * Fix `Unknown directive type "code_block"` warning. * Add uvmaps to official docs, fix - `WARNING: document isn't included in any toctree`. * Fix yaml lexer name - See https://pygments.org/languages/ * Fix warnings - `Inline substitution_reference start-string without end-string.` * Only copy open3d_tutorial.py once * Move list of classes to a global variable * Use f-strings as requested in PR * Add python_api_in as ignored directory. * Fix pybind docs with literal block for tree output * Fix doxygen docs with code block for tree outpu * Correct class names in doxygen docs for RedWood dataset
The only remaining files are as follows:
This change is