Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up util folder #2146

Merged
merged 3 commits into from
Aug 7, 2020
Merged

clean up util folder #2146

merged 3 commits into from
Aug 7, 2020

Conversation

yxlao
Copy link
Collaborator

@yxlao yxlao commented Aug 7, 2020

  • Remove unused scripts
  • Remove docker (outdated, not maintained)
  • Standardize naming

The only remaining files are as follows:

Open3D/util
├── check_cpp_style.cmake
├── check_style.py
├── install_deps_macos.sh
├── install_deps_ubuntu.sh
├── make_documentation.sh
└── run_ci.sh

This change is Reviewable

@yxlao yxlao requested a review from benjaminum August 7, 2020 05:49
@update-docs
Copy link

update-docs bot commented Aug 7, 2020

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

Copy link
Contributor

@griegler griegler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 57 of 59 files at r1, 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @benjaminum)

@yxlao yxlao merged commit 5457e4c into master Aug 7, 2020
@yxlao yxlao deleted the yixing/move-scripts branch August 7, 2020 09:23
sammo2828 pushed a commit to sammo2828/Open3D that referenced this pull request Aug 25, 2020
* clean up util folder

* update relative dir

* update relative dir
@pwais
Copy link

pwais commented Sep 30, 2020

@yxlao The online documentation still references headless docker support: http://www.open3d.org/docs/release/tutorial/docker/docker-gui.html Did the feature never work? Dockerized headless CPU rendering is incredibly useful.

@yxlao
Copy link
Collaborator Author

yxlao commented Oct 1, 2020

@pwais dockerized headless CPU rendering should be feasible. Our documentation build runs headless rendering https://github.com/intel-isl/Open3D/blob/master/.github/workflows/documentation.yml. It's possible to cook your own Dockerfile by following the scripts in documentation.yml.

@pwais
Copy link

pwais commented Oct 1, 2020

@yxlao yup I saw the CI stuff 👍 but I'd rather not have to try to cook up my own Dockerfile when there appears to be one that works (tho it got removed :( ) in this commit... Is the functionality referenced in the current online docs going to be restored, or are the docs out of date and going to be deleted?

Lastly, I'm not sure if you're familiar with this part of Open3D, but is there any way to configure Open3d do render-to-image without using Xvfb/mesa? I.e. is there any way to get Open3D to use "CPU-only functionality" to do rendering (sort of like putting pytorch or tensorflow into CPU mode)? If not, no big deal, but I wanted to ask given that it would be another way to do "headless" or CPU-only rendering. Also, this appears to be an Intel project, so I was hoping there might have been some feature here. I've looked through many of the examples and haven't found anything though.

oh huh, is the python package open3d on pypi right now actually built with headless rendering support?
https://github.com/intel-isl/Open3D/blob/8a7a77c10d4f0339fb5c52b913235f6e5a23b937/cpp/pybind/_build_config.py.in#L10

i may be confused between open3d "headless rendering" mode and the Xvfb software rasterizer. when Open3d is build with headless rendering, can it use both the GPU and the CPU (via Xvfb) ?

I've tried some of the jupyter examples and so far I got things to work in a docker container (based on lambda-stack ubuntu focal) https://github.com/lambdal/lambda-stack-dockerfiles/blob/master/Dockerfile.focal but that's via exposing host X11 into the container. I haven't gotten Xvfb + jupyter inside the container to work with the pypi release of Open3d; not sure if it's supposed to.

saurabheights added a commit to saurabheights/Open3D that referenced this pull request Aug 12, 2023
ssheorey pushed a commit that referenced this pull request Aug 17, 2023
* Add install with upgrade option when installing latest development package.
* util/install-deps-python.sh was removed in #2146
* Grammar fix.
* Move open3d_ml and arm to after docker.
* organize TOC - Move C++ and Contribution to end and keep python section together.
* Fix sphinx warnings (Title underline too short).
* Fix extra heading drop when going one level down.
* Fix cross reference links
* Add files/directories to ignore for sphinx, reduces inconsistency warnings.
* Fix `Unknown directive type "code_block"` warning.
* Add uvmaps to official docs, fix - `WARNING: document isn't included in any toctree`.
* Fix yaml lexer name - See https://pygments.org/languages/
* Fix warnings - `Inline substitution_reference start-string without end-string.`
* Only copy open3d_tutorial.py once
* Move list of classes to a global variable
* Use f-strings as requested in PR
* Add python_api_in as ignored directory.
* Fix pybind docs with literal block for tree output
* Fix doxygen docs with code block for tree outpu
* Correct class names in doxygen docs for RedWood dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants