Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tum facade dataset #613

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Conversation

ThomasFroech
Copy link
Contributor

@ThomasFroech ThomasFroech commented Aug 10, 2023

added dataset classes for the TUM-Facade dataset (https://github.com/OloOcki/tum-facade ) and updated the init file


This change is Reviewable

Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ThomasFroech this PR modifies the API for update_probs(). Can you explain the reasoning behind that?

@ssheorey
Copy link
Member

Hi @ThomasFroech can you add a readme.md for the dataset with this information:

Website:
Download:
Data License:
Leaderboard:
Citation:

@ThomasFroech
Copy link
Contributor Author

Hi @ssheorey,

Hi @ThomasFroech can you add a readme.md for the dataset with this information:

There is a README.md available in the original GitHub repo (https://github.com/OloOcki/tum-facade). I think that all important information is there. While the data can be downloaded from that source, I would recommend obtaining it from this location instead. Here, the data is organized into training, validation, and testing sets. The data structre is described in the small README.txt that is available, there:

https://tumde-my.sharepoint.com/:f:/g/personal/olaf_wysocki_tum_de/EjA8B_KGDyFEulRzmq-CG1QBBL4dZ7z5PoHeI8zMD0JxIQ?e=9MrMcl

Hi @ThomasFroech this PR modifies the API for update_probs(). Can you explain the reasoning behind that?

I'm sorry, but I'm not entirely sure about the specific point you're referring to. Would you kindly provide me with a hint or more details to help me better understand?

@ThomasFroech
Copy link
Contributor Author

@ssheorey

Hi @ThomasFroech this PR modifies the API for update_probs(). Can you explain the reasoning behind that?

My intention was solely to add the tumfacade.py file and make corresponding adjustments to the __init__.py file. I did not have any intention to alter or adapt any other components.

added --verbose parameter
@ssheorey ssheorey reopened this Dec 22, 2023
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ThomasFroech sorry about the confusion about the update_probs() - that change came from an unrelated commit.

  • Added documentation based on info provided.
  • Fixed style.

@ssheorey ssheorey merged commit 5ebe6e5 into isl-org:dev Dec 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants