RandLaNet update_probs label smoothing logic #569
Conversation
mariusud
changed the title
|
This pull request fixes 1 alert when merging e89ea4b into 1c45bfe - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
There was a problem hiding this comment.
@mariusud Can you give more details about the change to update_probs()?
Reviewed 13 of 14 files at r1.
Reviewable status: 13 of 14 files reviewed, 1 unresolved discussion (waiting on @mariusud)
ml3d/torch/models/randlanet.py line 450 at r1 (raw file):
Returns: updated probabilities and labels
Docstring for "Returns" needs to be updated
There was a problem hiding this comment.
Reviewable status: 4 of 14 files reviewed, 1 unresolved discussion (waiting on @benjaminum)
ml3d/torch/models/randlanet.py line 450 at r1 (raw file):
Previously, benjaminum (Benjamin Ummenhofer) wrote…
Docstring for "Returns" needs to be updated
Done
|
@mariusud the style check fails which can be easily fixed with |
mariusud
force-pushed
the
randlanet-faulty-logic
branch
from
92b98f7
to
aa04025
Compare
|
Sorry, Don't know about the Ubuntu CI. Seems it is also failing on your dev branch? |
|
@ssheorey Can you review the CI changes? |
There was a problem hiding this comment.
Reviewable status: 3 of 14 files reviewed, 1 unresolved discussion
Resolves #561
This change is