Closes #49 duplicate-banning factories #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qpwo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
==========================================
- Coverage 90.59% 90.51% -0.09%
==========================================
Files 6 6
Lines 617 622 +5
==========================================
+ Hits 559 563 +4
- Misses 58 59 +1
Continue to review full report at Codecov.
|
gabbard
suggested changes
Jun 10, 2019
gabbard
approved these changes
Jun 10, 2019
| @@ -92,6 +98,10 @@ def immutableset( | |||
| if value not in containment_set: | |||
| containment_set.add(value) | |||
| iteration_order.append(value) | |||
| elif forbid_duplicate_elements: | |||
| raise ValueError( | |||
| "Input collection has duplicate items and forbid_duplicate_elements=False" | |||
There was a problem hiding this comment.
This got merged before I could take a look, but could this be modified to give the repr of the duplicate element? This would make debugging much easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
immutableset_from_unique_elementsfactory andforbid_duplicate_elementskwarg